All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: "Li, Zhen-Hua" <zhen-hual-VXdhtT5mjnY@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/1] iommu/vt-d : clear old root entry for dump kernel
Date: Tue, 19 Aug 2014 13:02:39 +0200	[thread overview]
Message-ID: <20140819110239.GA16329@8bytes.org> (raw)
In-Reply-To: <1267BB84A242B24E81E0C0C8955CFFC061A4CA69-j39jTyOY9jISZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>

On Mon, Aug 18, 2014 at 11:27:01PM +0000, Li, Zhen-Hua wrote:
> : [fault reason 01] Present bit in root entry is clear
> It appears when iommu initializing in the kdump kernel.

Hmm, do you have an explanation how this can happen? From how I read the
code, the kdump kernel disables translation on the IOMMU, then sets a
new root entry, and then re-enabled translation. To me it looks like
there is no point in time where translation is enabled and the
root-entry is clear (present-bit==0).

But obviously I am missing something if you see the message above.

Btw, have you looked into this patch-set posted earlier this year:

	https://lkml.org/lkml/2014/4/24/836

It approaches the same problem-space, but also cares about in-flight
DMA.


	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: "Li, Zhen-Hua" <zhen-hual@hp.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] iommu/vt-d : clear old root entry for dump kernel
Date: Tue, 19 Aug 2014 13:02:39 +0200	[thread overview]
Message-ID: <20140819110239.GA16329@8bytes.org> (raw)
In-Reply-To: <1267BB84A242B24E81E0C0C8955CFFC061A4CA69@G9W0343.americas.hpqcorp.net>

On Mon, Aug 18, 2014 at 11:27:01PM +0000, Li, Zhen-Hua wrote:
> : [fault reason 01] Present bit in root entry is clear
> It appears when iommu initializing in the kdump kernel.

Hmm, do you have an explanation how this can happen? From how I read the
code, the kdump kernel disables translation on the IOMMU, then sets a
new root entry, and then re-enabled translation. To me it looks like
there is no point in time where translation is enabled and the
root-entry is clear (present-bit==0).

But obviously I am missing something if you see the message above.

Btw, have you looked into this patch-set posted earlier this year:

	https://lkml.org/lkml/2014/4/24/836

It approaches the same problem-space, but also cares about in-flight
DMA.


	Joerg


  parent reply	other threads:[~2014-08-19 11:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18  8:59 [PATCH 1/1] iommu/vt-d : clear old root entry for dump kernel Li, Zhen-Hua
2014-08-18  8:59 ` Li, Zhen-Hua
     [not found] ` <1408352352-14449-1-git-send-email-zhen-hual-VXdhtT5mjnY@public.gmane.org>
2014-08-18 23:01   ` Li, Zhen-Hua
2014-08-18 23:01     ` Li, Zhen-Hua
     [not found]     ` <1267BB84A242B24E81E0C0C8955CFFC061A4BA26-j39jTyOY9jISZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2014-08-18 23:23       ` Joerg Roedel
2014-08-18 23:23         ` Joerg Roedel
     [not found]         ` <20140818232328.GK9809-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-08-18 23:27           ` Li, Zhen-Hua
2014-08-18 23:27             ` Li, Zhen-Hua
     [not found]             ` <1267BB84A242B24E81E0C0C8955CFFC061A4CA69-j39jTyOY9jISZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2014-08-19 11:02               ` Joerg Roedel [this message]
2014-08-19 11:02                 ` Joerg Roedel
     [not found]                 ` <20140819110239.GA16329-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-08-20  9:54                   ` Li, ZhenHua
2014-08-20  9:54                     ` Li, ZhenHua
2014-08-18 23:47         ` Li, Zhen-Hua
2014-08-18 23:47           ` Li, Zhen-Hua
     [not found]           ` <1267BB84A242B24E81E0C0C8955CFFC061A4CA86-j39jTyOY9jISZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2014-08-18 23:59             ` Li, Zhen-Hua
2014-08-18 23:59               ` Li, Zhen-Hua
     [not found]               ` <1267BB84A242B24E81E0C0C8955CFFC061A4DACB-j39jTyOY9jISZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2014-08-19  5:49                 ` Li, ZhenHua
2014-08-19  5:49                   ` Li, ZhenHua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140819110239.GA16329@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=zhen-hual-VXdhtT5mjnY@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.