From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Cc: iommu
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH] iommu/vt-d: Don't store SIRTP request
Date: Tue, 19 Aug 2014 13:09:37 +0200 [thread overview]
Message-ID: <20140819110937.GA26492@8bytes.org> (raw)
In-Reply-To: <53E8A555.5010905-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
On Mon, Aug 11, 2014 at 01:13:25PM +0200, Jan Kiszka wrote:
> Don't store the SIRTP request bit in the register state. It will
> otherwise become sticky and could request an Interrupt Remap Table
> Pointer update on each command register write.
>
> Found while starting to emulate IR in QEMU, not by observing problems on
> real hardware.
>
> Signed-off-by: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/iommu/intel_irq_remapping.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks Jan.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: iommu <iommu@lists.linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jiang Liu <jiang.liu@linux.intel.com>
Subject: Re: [PATCH] iommu/vt-d: Don't store SIRTP request
Date: Tue, 19 Aug 2014 13:09:37 +0200 [thread overview]
Message-ID: <20140819110937.GA26492@8bytes.org> (raw)
In-Reply-To: <53E8A555.5010905@siemens.com>
On Mon, Aug 11, 2014 at 01:13:25PM +0200, Jan Kiszka wrote:
> Don't store the SIRTP request bit in the register state. It will
> otherwise become sticky and could request an Interrupt Remap Table
> Pointer update on each command register write.
>
> Found while starting to emulate IR in QEMU, not by observing problems on
> real hardware.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> drivers/iommu/intel_irq_remapping.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks Jan.
next prev parent reply other threads:[~2014-08-19 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 11:13 [PATCH] iommu/vt-d: Don't store SIRTP request Jan Kiszka
2014-08-11 11:13 ` Jan Kiszka
[not found] ` <53E8A555.5010905-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2014-08-19 11:09 ` Joerg Roedel [this message]
2014-08-19 11:09 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819110937.GA26492@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
--cc=jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.