CIFS module build verification system

CIFS module build verification system

[Pavel Shilovsky]

Hi,

During the second part of the GSoC program of this year I has been
working on build verification system for CIFS kernel module.

Now, I got the system ready to test module with Cthon and XFS test
suites. Both suites has some tests (that are not working with CIFS)
disabled. I was trying to make it easier to add new test suites
further.

The system is based on bash scripts that can be run from cron. The
scripts automatically pull the recent changes from the predefined git
repository, build the module and run tests against it.

The git repo for build verification system scripts:
http://git.altlinux.org/people/piastry/public/?p=cifs-tests.git;a=summary

The git repo for patched Cthon tests (merged by Steve Dickson into his tree):
http://git.altlinux.org/people/piastry/public/?p=cthon04.git;a=summary

The git repo for patched XFS tests:
http://git.altlinux.org/people/piastry/public/?p=xfstests.git;a=summary

-- 
Best regards,
Pavel Shilovsky.

Re: CIFS module build verification system

[Steve French]

This looks promising ... note the typo ("NFS" instead of "CIFS" in the
error message in the xfstest patch)

+    cifs)
+       # Don't know how to check an NFS filesystem, yet.

On Mon, Aug 18, 2014 at 12:46 PM, Pavel Shilovsky <pshilovsky-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
> Hi,
>
> During the second part of the GSoC program of this year I has been
> working on build verification system for CIFS kernel module.
>
> Now, I got the system ready to test module with Cthon and XFS test
> suites. Both suites has some tests (that are not working with CIFS)
> disabled. I was trying to make it easier to add new test suites
> further.
>
> The system is based on bash scripts that can be run from cron. The
> scripts automatically pull the recent changes from the predefined git
> repository, build the module and run tests against it.
>
> The git repo for build verification system scripts:
> http://git.altlinux.org/people/piastry/public/?p=cifs-tests.git;a=summary
>
> The git repo for patched Cthon tests (merged by Steve Dickson into his tree):
> http://git.altlinux.org/people/piastry/public/?p=cthon04.git;a=summary
>
> The git repo for patched XFS tests:
> http://git.altlinux.org/people/piastry/public/?p=xfstests.git;a=summary
>
> --
> Best regards,
> Pavel Shilovsky.



-- 
Thanks,

Steve

Re: CIFS module build verification system

[David Disseldorp]

Hi Pavel,

On Mon, 18 Aug 2014 21:46:44 +0400, Pavel Shilovsky wrote:

> Hi,
> 
> During the second part of the GSoC program of this year I has been
> working on build verification system for CIFS kernel module.
> 
> Now, I got the system ready to test module with Cthon and XFS test
> suites. Both suites has some tests (that are not working with CIFS)
> disabled. I was trying to make it easier to add new test suites
> further.
> 
> The system is based on bash scripts that can be run from cron. The
> scripts automatically pull the recent changes from the predefined git
> repository, build the module and run tests against it.

Thanks for putting this together!

> The git repo for build verification system scripts:
> http://git.altlinux.org/people/piastry/public/?p=cifs-tests.git;a=summary
> 
> The git repo for patched Cthon tests (merged by Steve Dickson into his tree):
> http://git.altlinux.org/people/piastry/public/?p=cthon04.git;a=summary

I haven't looked at your cifs-tests or cthon04 tests yet.

> The git repo for patched XFS tests:
> http://git.altlinux.org/people/piastry/public/?p=xfstests.git;a=summary

        nfs)
                export MKFS_OPTIONS=$NFS_MKFS_OPTIONS
                ;;
+       nfs)
+               export MKFS_OPTIONS=$CIFS_MKFS_OPTIONS
+               ;;

Should be "cifs)".

Would be good to add an auto group to tests/cifs/group, which could be
added to as existing tests are made to pass on cifs.

Also, a brief description in README of how to run against a cifs mount
would be useful. E.g.
http://git.samba.org/?p=ddiss/fstests.git;a=commitdiff;h=b99c5b12799b4db3edcb6430e000db6afb5db9a9

Re: CIFS module build verification system

[Pavel Shilovsky]

2014-08-18 21:46 GMT+04:00 Pavel Shilovsky <pshilovsky-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>:
> Hi,
>
> During the second part of the GSoC program of this year I has been
> working on build verification system for CIFS kernel module.
>
> Now, I got the system ready to test module with Cthon and XFS test
> suites. Both suites has some tests (that are not working with CIFS)
> disabled. I was trying to make it easier to add new test suites
> further.
>
> The system is based on bash scripts that can be run from cron. The
> scripts automatically pull the recent changes from the predefined git
> repository, build the module and run tests against it.
>
> The git repo for build verification system scripts:
> http://git.altlinux.org/people/piastry/public/?p=cifs-tests.git;a=summary
>
> The git repo for patched Cthon tests (merged by Steve Dickson into his tree):
> http://git.altlinux.org/people/piastry/public/?p=cthon04.git;a=summary
>
> The git repo for patched XFS tests:
> http://git.altlinux.org/people/piastry/public/?p=xfstests.git;a=summary

Hi Steve, David,

Thank you for your notes and suggestions!

Do you understand right that I can squash David's commit (started with
"SQUASH") into my patch?

Not sure about group file. CIFS (as NFS) doesn't have it's own tests
now. Do you mean to add "test/cifs" directory with an empty (except a
commented header) group file inside (to let us add cifs specific tests
in future)?

-- 
Best regards,
Pavel Shilovsky.

Re: CIFS module build verification system

[David Disseldorp]

On Wed, 20 Aug 2014 11:32:59 +0400, Pavel Shilovsky wrote:

...
> > The git repo for build verification system scripts:
> > http://git.altlinux.org/people/piastry/public/?p=cifs-tests.git;a=summary
> >
> > The git repo for patched Cthon tests (merged by Steve Dickson into his tree):
> > http://git.altlinux.org/people/piastry/public/?p=cthon04.git;a=summary
> >
> > The git repo for patched XFS tests:
> > http://git.altlinux.org/people/piastry/public/?p=xfstests.git;a=summary
> 
> Hi Steve, David,
> 
> Thank you for your notes and suggestions!
> 
> Do you understand right that I can squash David's commit (started with
> "SQUASH") into my patch?

Sure, go for it.

> Not sure about group file. CIFS (as NFS) doesn't have it's own tests
> now. Do you mean to add "test/cifs" directory with an empty (except a
> commented header) group file inside (to let us add cifs specific tests
> in future)?

My mistake, I thought the generic tests could be regrouped
per-filesystem. An empty template would be fine.

Cheers, David

Re: CIFS module build verification system

[David Disseldorp]

On Wed, 20 Aug 2014 11:20:04 +0200, David Disseldorp wrote:

> > Do you understand right that I can squash David's commit (started with
> > "SQUASH") into my patch?  
> 
> Sure, go for it.

Also, please post your next round to the fstests mailing list
(fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) for feedback. I'd like to get this work
upstream.

Cheers, David

Re: CIFS module build verification system

[Pavel Shilovsky]

> 22 авг. 2014 г., в 17:49, David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org> написал(а):
> 
> On Wed, 20 Aug 2014 11:20:04 +0200, David Disseldorp wrote:
> 
>>> Do you understand right that I can squash David's commit (started with
>>> "SQUASH") into my patch?  
>> 
>> Sure, go for it.
> 
> Also, please post your next round to the fstests mailing list
> (fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) for feedback. I'd like to get this work
> upstream.

Good idea, thanks. So, I will send two patches: my main patch (with your squash commit inside) and your Readme patch. Also I can squash the Readme one too and post one big patch -- what is more preferable?

Steve, David, do you want me to add your reviewed-by/acked-by to the main patch?

Re: CIFS module build verification system

[David Disseldorp]

On Fri, 22 Aug 2014 19:04:31 +0400, Pavel Shilovsky wrote:

> Good idea, thanks. So, I will send two patches: my main patch (with your squash commit inside) and your Readme patch. Also I can squash the Readme one too and post one big patch -- what is more preferable?

One patch with the two commits from my repo squashed in should be fine.

> Steve, David, do you want me to add your reviewed-by/acked-by to the main patch?

If it's just your original change with the other two patches squashed,
then please add Reviewed-by: David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org>

Cheers, David