From: Lee Jones <lee.jones@linaro.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: pekon@pek-sem.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com
Subject: Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver
Date: Wed, 20 Aug 2014 07:47:08 +0100 [thread overview]
Message-ID: <20140820064708.GC4266@lee--X1> (raw)
In-Reply-To: <20140819013110.GO18411@ld-irv-0074>
On Mon, 18 Aug 2014, Brian Norris wrote:
> On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote:
> > On Thu, 14 Aug 2014, Brian Norris wrote:
> > > Particularly, take a hard look at rewriting
> > > include/linux/mtd/stm_nand_bbt.h.
> >
> > I don't think there is any need - although this change is required:
> >
> > -#if defined(MTD_NAND_STM_BBT)
> > +#if defined(MTD_NAND_STM_BCH_BBT)
>
> You're still missing a GPL header and #include guards.
>
> Your whole patch series (both v1 and v2) also has a few legit
> checkpatch.pl warnings. Please fix these.
Will fix all of the above.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] mtd: nand: Support for new DT NAND driver
Date: Wed, 20 Aug 2014 07:47:08 +0100 [thread overview]
Message-ID: <20140820064708.GC4266@lee--X1> (raw)
In-Reply-To: <20140819013110.GO18411@ld-irv-0074>
On Mon, 18 Aug 2014, Brian Norris wrote:
> On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote:
> > On Thu, 14 Aug 2014, Brian Norris wrote:
> > > Particularly, take a hard look at rewriting
> > > include/linux/mtd/stm_nand_bbt.h.
> >
> > I don't think there is any need - although this change is required:
> >
> > -#if defined(MTD_NAND_STM_BBT)
> > +#if defined(MTD_NAND_STM_BCH_BBT)
>
> You're still missing a GPL header and #include guards.
>
> Your whole patch series (both v1 and v2) also has a few legit
> checkpatch.pl warnings. Please fix these.
Will fix all of the above.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
pekon@pek-sem.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver
Date: Wed, 20 Aug 2014 07:47:08 +0100 [thread overview]
Message-ID: <20140820064708.GC4266@lee--X1> (raw)
In-Reply-To: <20140819013110.GO18411@ld-irv-0074>
On Mon, 18 Aug 2014, Brian Norris wrote:
> On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote:
> > On Thu, 14 Aug 2014, Brian Norris wrote:
> > > Particularly, take a hard look at rewriting
> > > include/linux/mtd/stm_nand_bbt.h.
> >
> > I don't think there is any need - although this change is required:
> >
> > -#if defined(MTD_NAND_STM_BBT)
> > +#if defined(MTD_NAND_STM_BCH_BBT)
>
> You're still missing a GPL header and #include guards.
>
> Your whole patch series (both v1 and v2) also has a few legit
> checkpatch.pl warnings. Please fix these.
Will fix all of the above.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-08-20 6:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 9:11 [PATCH 0/8] mtd: nand: Support for new DT NAND driver Lee Jones
2014-08-13 9:11 ` Lee Jones
2014-08-13 9:11 ` Lee Jones
2014-08-13 9:12 ` [PATCH 1/8] ARM: multi-v7: Enable ST BCH NAND Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` [PATCH 2/8] ARM: sti: Add two new clock definitions for use with ST's NAND controllers Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` [PATCH 3/8] ARM: sti: Add BCH (NAND Flash) Controller support for STiH41x (Orly) SoCs Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` [PATCH 4/8] ARM: sti: Enable BCH NAND for STiH416 B2020-RevE Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` [PATCH 5/8] mtd: nand: stm_nand_bch: provide Device Tree documentation Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` [PATCH 6/8] mtd: nand: add shared register defines for ST's NAND Controller drivers Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` [PATCH 7/8] mtd: nand: stm_nand_bch: add support for ST's BCH NAND controller Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` [PATCH 8/8] mtd: nand: stm_nand_bch: provide ST's implementation of Back Block Table Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 9:12 ` Lee Jones
2014-08-13 15:44 ` [PATCH 0/8] mtd: nand: Support for new DT NAND driver pekon
2014-08-13 15:44 ` pekon
2014-08-13 15:44 ` pekon at pek-sem.com
2014-08-14 22:40 ` Brian Norris
2014-08-14 22:40 ` Brian Norris
2014-08-14 22:40 ` Brian Norris
2014-08-18 8:39 ` Lee Jones
2014-08-18 8:39 ` Lee Jones
2014-08-18 8:39 ` Lee Jones
2014-08-18 10:06 ` Lee Jones
2014-08-18 10:06 ` Lee Jones
2014-08-18 10:06 ` Lee Jones
2014-08-19 1:31 ` Brian Norris
2014-08-19 1:31 ` Brian Norris
2014-08-19 1:31 ` Brian Norris
2014-08-20 6:47 ` Lee Jones [this message]
2014-08-20 6:47 ` Lee Jones
2014-08-20 6:47 ` Lee Jones
2014-08-19 19:06 ` Brian Norris
2014-08-19 19:06 ` Brian Norris
2014-08-19 19:06 ` Brian Norris
2014-08-20 6:48 ` Lee Jones
2014-08-20 6:48 ` Lee Jones
2014-08-20 6:48 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820064708.GC4266@lee--X1 \
--to=lee.jones@linaro.org \
--cc=computersforpeace@gmail.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@pek-sem.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.