From: Thierry Reding <thierry.reding@gmail.com>
To: "Gaël PORTAY" <gael.portay@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH 2/3] ARM: at91/tclib: move initialization from alloc to probe
Date: Wed, 20 Aug 2014 09:39:29 +0200 [thread overview]
Message-ID: <20140820073929.GJ13793@ulmo> (raw)
In-Reply-To: <1408486072-19268-3-git-send-email-gael.portay@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
On Wed, Aug 20, 2014 at 12:07:51AM +0200, Gaël PORTAY wrote:
> Move resource retrieval from atmel_tc_alloc to tc_probe to avoid lately
> reporting resource related issues when a TC block user request a TC block.
>
> Moreover, resources retrieval are usually done in the probe function,
> thus moving them add some consistency with other drivers.
>
> Initialization is done once, ie not every time a tc block is requested.
> If it fails, the device is not appended to the list of tc blocks.
>
> Furhermore, the device id is retrieved at probe as well, avoiding parsing
> DT every time the user requests of tc block.
>
> Signed-off-by: Gaël PORTAY <gael.portay@gmail.com>
> ---
> drivers/clocksource/tcb_clksrc.c | 2 +-
> drivers/misc/atmel_tclib.c | 71 +++++++++++++---------------------------
> drivers/pwm/pwm-atmel-tcb.c | 2 +-
> include/linux/atmel_tc.h | 8 +++--
> 4 files changed, 29 insertions(+), 54 deletions(-)
For the PWM driver part:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: at91/tclib: move initialization from alloc to probe
Date: Wed, 20 Aug 2014 09:39:29 +0200 [thread overview]
Message-ID: <20140820073929.GJ13793@ulmo> (raw)
In-Reply-To: <1408486072-19268-3-git-send-email-gael.portay@gmail.com>
On Wed, Aug 20, 2014 at 12:07:51AM +0200, Ga?l PORTAY wrote:
> Move resource retrieval from atmel_tc_alloc to tc_probe to avoid lately
> reporting resource related issues when a TC block user request a TC block.
>
> Moreover, resources retrieval are usually done in the probe function,
> thus moving them add some consistency with other drivers.
>
> Initialization is done once, ie not every time a tc block is requested.
> If it fails, the device is not appended to the list of tc blocks.
>
> Furhermore, the device id is retrieved at probe as well, avoiding parsing
> DT every time the user requests of tc block.
>
> Signed-off-by: Ga?l PORTAY <gael.portay@gmail.com>
> ---
> drivers/clocksource/tcb_clksrc.c | 2 +-
> drivers/misc/atmel_tclib.c | 71 +++++++++++++---------------------------
> drivers/pwm/pwm-atmel-tcb.c | 2 +-
> include/linux/atmel_tc.h | 8 +++--
> 4 files changed, 29 insertions(+), 54 deletions(-)
For the PWM driver part:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140820/16a4665b/attachment.sig>
next prev parent reply other threads:[~2014-08-20 7:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 22:07 [PATCH 0/3] ARM: at91/tclib: fix segmentation fault Gaël PORTAY
2014-08-19 22:07 ` Gaël PORTAY
2014-08-19 22:07 ` [PATCH 1/3] ARM: at91/tclib: prefer using of devm_* functions Gaël PORTAY
2014-08-19 22:07 ` Gaël PORTAY
2014-08-20 8:19 ` Boris BREZILLON
2014-08-20 8:19 ` Boris BREZILLON
2014-08-19 22:07 ` [PATCH 2/3] ARM: at91/tclib: move initialization from alloc to probe Gaël PORTAY
2014-08-19 22:07 ` Gaël PORTAY
2014-08-20 7:39 ` Thierry Reding [this message]
2014-08-20 7:39 ` Thierry Reding
2014-08-20 8:16 ` Boris BREZILLON
2014-08-20 8:16 ` Boris BREZILLON
2014-08-19 22:07 ` [PATCH 3/3] ARM: at91/tclib: mask interruptions at shutdown and probe Gaël PORTAY
2014-08-19 22:07 ` Gaël PORTAY
2014-08-19 22:11 ` Jean-Christophe PLAGNIOL-VILLARD
2014-08-19 22:11 ` Jean-Christophe PLAGNIOL-VILLARD
2014-08-19 23:01 ` Boris BREZILLON
2014-08-19 23:01 ` Boris BREZILLON
2014-08-20 7:31 ` Thierry Reding
2014-08-20 7:31 ` Thierry Reding
2014-08-20 8:14 ` Boris BREZILLON
2014-08-20 8:14 ` Boris BREZILLON
2014-08-20 8:28 ` Thierry Reding
2014-08-20 8:28 ` Thierry Reding
2014-08-20 9:06 ` Boris BREZILLON
2014-08-20 9:06 ` Boris BREZILLON
2014-08-20 9:48 ` Thierry Reding
2014-08-20 9:48 ` Thierry Reding
2014-08-20 10:07 ` Boris BREZILLON
2014-08-20 10:07 ` Boris BREZILLON
2014-08-27 15:27 ` Gaël PORTAY
2014-08-21 3:32 ` Arnd Bergmann
2014-08-21 3:32 ` Arnd Bergmann
2014-08-21 9:43 ` Gaël PORTAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820073929.GJ13793@ulmo \
--to=thierry.reding@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=daniel.lezcano@linaro.org \
--cc=gael.portay@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.