From: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org
Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
skuribay-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org,
Romain.Baeriswyl-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org,
rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org,
yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org
Subject: Re: [PATCH] i2c: designware: deduce speed mode from device tree setting
Date: Wed, 20 Aug 2014 10:52:22 +0300 [thread overview]
Message-ID: <20140820075222.GA1660@lahna.fi.intel.com> (raw)
In-Reply-To: <1408479529-24249-1-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
On Tue, Aug 19, 2014 at 03:18:49PM -0500, atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote:
> From: Alan Tull <atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
>
> Use the documented, but unimplemented "clock-frequency"
> Device Tree setting as a guide on whether to set the speed
> mode bits in DW_IC_CON to standard or fast i2c mode.
>
> Previously, the driver was hardwired to fast mode. Default
> to fast mode if the "clock-frequency" property is not present
> for backwards compatiblity.
>
> Signed-off-by: Alan Tull <atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
I don't know much about the Device Tree bindings but the patch looks
good to me,
Acked-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: atull@opensource.altera.com
Cc: wsa@the-dreams.de, baruch@tkos.co.il, grant.likely@linaro.org,
robh+dt@kernel.org, skuribay@pobox.com,
Romain.Baeriswyl@abilis.com, rafael.j.wysocki@intel.com,
alan@linux.intel.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
delicious.quinoa@gmail.com, dinguyen@opensource.altera.com,
yvanderv@opensource.altera.com
Subject: Re: [PATCH] i2c: designware: deduce speed mode from device tree setting
Date: Wed, 20 Aug 2014 10:52:22 +0300 [thread overview]
Message-ID: <20140820075222.GA1660@lahna.fi.intel.com> (raw)
In-Reply-To: <1408479529-24249-1-git-send-email-atull@opensource.altera.com>
On Tue, Aug 19, 2014 at 03:18:49PM -0500, atull@opensource.altera.com wrote:
> From: Alan Tull <atull@opensource.altera.com>
>
> Use the documented, but unimplemented "clock-frequency"
> Device Tree setting as a guide on whether to set the speed
> mode bits in DW_IC_CON to standard or fast i2c mode.
>
> Previously, the driver was hardwired to fast mode. Default
> to fast mode if the "clock-frequency" property is not present
> for backwards compatiblity.
>
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
I don't know much about the Device Tree bindings but the patch looks
good to me,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2014-08-20 7:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 20:18 [PATCH] i2c: designware: deduce speed mode from device tree setting atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-08-19 20:18 ` atull
[not found] ` <1408479529-24249-1-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-08-20 7:52 ` Mika Westerberg [this message]
2014-08-20 7:52 ` Mika Westerberg
2014-08-20 9:22 ` Mark Rutland
2014-08-20 9:22 ` Mark Rutland
2014-08-20 9:49 ` Romain Baeriswyl
2014-08-20 9:49 ` Romain Baeriswyl
2014-08-20 12:07 ` Romain Baeriswyl
[not found] ` <944257148.1724.1408528177642.JavaMail.root-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>
2014-08-20 12:32 ` Wolfram Sang
2014-08-20 12:32 ` Wolfram Sang
2014-08-20 14:24 ` atull
2014-08-20 14:24 ` atull
2014-08-20 14:38 ` Romain Baeriswyl
2014-08-20 14:38 ` Romain Baeriswyl
[not found] ` <1791089693.2989.1408545513401.JavaMail.root-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>
2014-08-20 15:12 ` atull
2014-08-20 15:12 ` atull
2014-08-20 12:36 ` Wolfram Sang
2014-08-20 12:42 ` Mark Rutland
2014-08-20 14:29 ` [PATCH] i2c designware add support of I2C standard mode Romain Baeriswyl
2014-08-20 14:29 ` Romain Baeriswyl
2014-09-18 15:52 ` atull
2014-09-18 15:52 ` atull
[not found] ` <1408544948-22339-1-git-send-email-romainba-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>
2014-08-20 14:32 ` atull
2014-08-20 14:32 ` atull
2014-08-20 15:25 ` atull
2014-08-20 15:25 ` atull
2014-09-20 9:24 ` Wolfram Sang
2014-09-20 9:24 ` Wolfram Sang
2014-09-28 3:40 ` atull
2014-09-28 3:40 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820075222.GA1660@lahna.fi.intel.com \
--to=mika.westerberg-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=Romain.Baeriswyl-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org \
--cc=alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=skuribay-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
--cc=yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.