From: Dave Chinner <david@fromorbit.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/6] common: _scratch_mkfs_sized should inherent default block size from test_dev
Date: Thu, 21 Aug 2014 09:14:50 +1000 [thread overview]
Message-ID: <20140820231450.GI26465@dastard> (raw)
In-Reply-To: <1408194791-1797-2-git-send-email-dmonakhov@openvz.org>
On Sat, Aug 16, 2014 at 05:13:07PM +0400, Dmitry Monakhov wrote:
> Currently default block size is frozen to 4096 which is bad for
> various reasons for example:
> 1) It ignores MKFS_OPT
It still ignores MKFS_OPTIONS. The test device is not made with
those parameters unless you specifically remake it before every
xfstests run with a different configuration.
> 2) Not works for architectures where PG_SIZE != 4096
That I don't understand. 4k block size filesystems work just fine
on architectures with page size > 4k....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-08-20 23:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 13:13 [PATCH 1/6] common: add _mkfs_dev helper Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 2/6] common: _scratch_mkfs_sized should inherent default block size from test_dev Dmitry Monakhov
2014-08-20 23:14 ` Dave Chinner [this message]
2014-08-21 7:36 ` Dmitry Monakhov
2014-08-21 9:23 ` Dave Chinner
2014-08-21 14:01 ` Theodore Ts'o
2014-08-21 20:44 ` Dave Chinner
2014-08-22 13:24 ` Dmitry Monakhov
2014-08-22 15:09 ` Theodore Ts'o
2014-08-22 15:48 ` Dmitry Monakhov
2014-08-22 16:37 ` Theodore Ts'o
2014-08-23 0:31 ` Dave Chinner
2014-08-16 13:13 ` [PATCH 3/6] src/e4compact cleanup Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 4/6] src/e4compact: handle various block_size correctly Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 5/6] src/e4compact: add sparse file optimization Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 6/6] ext4/308: add new defrag compact test case Dmitry Monakhov
2014-09-08 12:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820231450.GI26465@dastard \
--to=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.