From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>, fstests@vger.kernel.org
Subject: Re: [PATCH 2/6] common: _scratch_mkfs_sized should inherent default block size from test_dev
Date: Fri, 22 Aug 2014 06:44:40 +1000 [thread overview]
Message-ID: <20140821204440.GN26465@dastard> (raw)
In-Reply-To: <20140821140106.GH11085@thunk.org>
On Thu, Aug 21, 2014 at 10:01:06AM -0400, Theodore Ts'o wrote:
> On that note, what is dbsize supposed to be? It appears to be set in
> _filter_mkfs? It appears from context that this is supposed to be the
> data block size? Currently this gets hard coded to 4k for non-xfs
> file systems, and it assumes a 256 byte inode.
>
> It looks like we should be extracting this information from dumpe2fs
> for extN file systems?
*nod*
Most of the special mkfs sauce that is used by XFS specific tests
simply has not been written for other filesystems. The hard coded
results from _filter_mkfs are just there so that generic tests that
use dbsize/isize mostly work.
So if want you to add this "reflect reality" functionality for ext4
you are more than welcome to do it. :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-08-21 20:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 13:13 [PATCH 1/6] common: add _mkfs_dev helper Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 2/6] common: _scratch_mkfs_sized should inherent default block size from test_dev Dmitry Monakhov
2014-08-20 23:14 ` Dave Chinner
2014-08-21 7:36 ` Dmitry Monakhov
2014-08-21 9:23 ` Dave Chinner
2014-08-21 14:01 ` Theodore Ts'o
2014-08-21 20:44 ` Dave Chinner [this message]
2014-08-22 13:24 ` Dmitry Monakhov
2014-08-22 15:09 ` Theodore Ts'o
2014-08-22 15:48 ` Dmitry Monakhov
2014-08-22 16:37 ` Theodore Ts'o
2014-08-23 0:31 ` Dave Chinner
2014-08-16 13:13 ` [PATCH 3/6] src/e4compact cleanup Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 4/6] src/e4compact: handle various block_size correctly Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 5/6] src/e4compact: add sparse file optimization Dmitry Monakhov
2014-08-16 13:13 ` [PATCH 6/6] ext4/308: add new defrag compact test case Dmitry Monakhov
2014-09-08 12:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821204440.GN26465@dastard \
--to=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.