From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Doug Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Caesar Wang <caesar.wang@rock-chips.com>,
Sonny Rao <sonnyrao@chromium.org>,
Olof Johansson <olof@lixom.net>,
Eddie Cai <eddie.cai@rock-chips.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-pwm <linux-pwm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
hpa@zytor.com
Subject: Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288
Date: Thu, 21 Aug 2014 08:40:27 +0200 [thread overview]
Message-ID: <20140821064026.GC4486@ulmo> (raw)
In-Reply-To: <387c82a0-efeb-431d-b8a5-200f24bc47ff@email.android.com>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
On Wed, Aug 20, 2014 at 02:29:17PM -0500, Dmitry Torokhov wrote:
> On August 20, 2014 1:54:11 PM CDT, Doug Anderson <dianders@chromium.org> wrote:
> >On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding
> ><thierry.reding@gmail.com> wrote:
> >> On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote:
> >>> The rk3288 has the ability to invert
> >>> + struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
> >>> +
> >>> + if (!pc->data->has_invert)
> >>> + return -ENOSYS;
> >>> +
>
> At the kernel summit hpa also mentioned that ENOSYS should only be
> used for missing syscalls. Not sure what error code would suit better
> here though...
I'd be interested in the rationale why ENOSYS shouldn't be used within
the kernel. As long as it doesn't leak to userspace where it could
possibly confuse applications I don't see any harm in using it.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288
Date: Thu, 21 Aug 2014 08:40:27 +0200 [thread overview]
Message-ID: <20140821064026.GC4486@ulmo> (raw)
In-Reply-To: <387c82a0-efeb-431d-b8a5-200f24bc47ff@email.android.com>
On Wed, Aug 20, 2014 at 02:29:17PM -0500, Dmitry Torokhov wrote:
> On August 20, 2014 1:54:11 PM CDT, Doug Anderson <dianders@chromium.org> wrote:
> >On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding
> ><thierry.reding@gmail.com> wrote:
> >> On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote:
> >>> The rk3288 has the ability to invert
> >>> + struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
> >>> +
> >>> + if (!pc->data->has_invert)
> >>> + return -ENOSYS;
> >>> +
>
> At the kernel summit hpa also mentioned that ENOSYS should only be
> used for missing syscalls. Not sure what error code would suit better
> here though...
I'd be interested in the rationale why ENOSYS shouldn't be used within
the kernel. As long as it doesn't leak to userspace where it could
possibly confuse applications I don't see any harm in using it.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140821/44ef4883/attachment.sig>
next prev parent reply other threads:[~2014-08-21 6:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 16:07 [PATCH v3 0/4] PWM changes for rk3288-evb Doug Anderson
2014-08-19 16:07 ` Doug Anderson
2014-08-19 16:07 ` [PATCH v3 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP Doug Anderson
2014-08-19 16:07 ` Doug Anderson
[not found] ` <1408464476-28316-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-08-19 16:07 ` [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288 Doug Anderson
2014-08-19 16:07 ` Doug Anderson
2014-08-19 16:07 ` Doug Anderson
2014-08-19 22:15 ` Caesar Wang
2014-08-19 22:15 ` Caesar Wang
2014-08-20 10:04 ` Thierry Reding
2014-08-20 10:04 ` Thierry Reding
2014-08-20 18:54 ` Doug Anderson
2014-08-20 18:54 ` Doug Anderson
2014-08-20 19:29 ` Dmitry Torokhov
2014-08-20 19:29 ` Dmitry Torokhov
2014-08-20 19:31 ` Doug Anderson
2014-08-20 19:31 ` Doug Anderson
2014-08-21 6:40 ` Thierry Reding [this message]
2014-08-21 6:40 ` Thierry Reding
2014-08-19 16:07 ` [PATCH v3 3/4] ARM: dts: Add main PWM info to rk3288 Doug Anderson
2014-08-19 16:07 ` Doug Anderson
2014-08-19 16:07 ` Doug Anderson
2014-08-19 16:07 ` [PATCH v3 4/4] ARM: dts: Enable PWM backlight on rk3288-EVB Doug Anderson
2014-08-19 16:07 ` Doug Anderson
2014-08-19 16:07 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821064026.GC4486@ulmo \
--to=thierry.reding@gmail.com \
--cc=caesar.wang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eddie.cai@rock-chips.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=hpa@zytor.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.