From: Andrea Righi <andrea-oIIqvOZpAevzfdHfmsDf5w@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matt Heaton <matt-oIIqvOZpAevzfdHfmsDf5w@public.gmane.org>
Subject: Re: [PATCH] cgroup: add tracepoints to track cgroup events
Date: Thu, 21 Aug 2014 09:35:41 -0600 [thread overview]
Message-ID: <20140821153541.GA7625@Dell> (raw)
In-Reply-To: <20140821141330.GA1766-9pTldWuhBndy/B6EtB590w@public.gmane.org>
On Thu, Aug 21, 2014 at 09:13:30AM -0500, Tejun Heo wrote:
> Hello,
>
> On Wed, Aug 20, 2014 at 09:46:25PM -0600, Andrea Righi wrote:
> > This patch adds the following tracepoints:
> > o trace_cgroup_create when a new cgroup is created
> > o trace_cgroup_destroy when a cgroup is removed
> > o trace_cgroup_task_migrate when a task/thread is moved from a cgroup to another
> >
> > The purpose of these tracepoints is to identify and help cgroup "managers" to
> > diagnose problems and detect when they are doing an excessive amount of work.
>
> Using TPs for this looks like a really roundabout way of doing this
> when the whole interface is based on filesystem. Extending
> kernfs_notity to support directory events seems like a better way to
> do this.
>
> Thanks.
>
> --
> tejun
Agreed. Thanks for the suggestion, Tejun.
-Andrea
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Righi <andrea@betterlinux.com>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Heaton <matt@betterlinux.com>
Subject: Re: [PATCH] cgroup: add tracepoints to track cgroup events
Date: Thu, 21 Aug 2014 09:35:41 -0600 [thread overview]
Message-ID: <20140821153541.GA7625@Dell> (raw)
In-Reply-To: <20140821141330.GA1766@mtj.dyndns.org>
On Thu, Aug 21, 2014 at 09:13:30AM -0500, Tejun Heo wrote:
> Hello,
>
> On Wed, Aug 20, 2014 at 09:46:25PM -0600, Andrea Righi wrote:
> > This patch adds the following tracepoints:
> > o trace_cgroup_create when a new cgroup is created
> > o trace_cgroup_destroy when a cgroup is removed
> > o trace_cgroup_task_migrate when a task/thread is moved from a cgroup to another
> >
> > The purpose of these tracepoints is to identify and help cgroup "managers" to
> > diagnose problems and detect when they are doing an excessive amount of work.
>
> Using TPs for this looks like a really roundabout way of doing this
> when the whole interface is based on filesystem. Extending
> kernfs_notity to support directory events seems like a better way to
> do this.
>
> Thanks.
>
> --
> tejun
Agreed. Thanks for the suggestion, Tejun.
-Andrea
next prev parent reply other threads:[~2014-08-21 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 3:46 [PATCH] cgroup: add tracepoints to track cgroup events Andrea Righi
2014-08-21 3:46 ` Andrea Righi
[not found] ` <1408592785-6700-1-git-send-email-andrea-oIIqvOZpAevzfdHfmsDf5w@public.gmane.org>
2014-08-21 14:13 ` Tejun Heo
2014-08-21 14:13 ` Tejun Heo
[not found] ` <20140821141330.GA1766-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-08-21 15:35 ` Andrea Righi [this message]
2014-08-21 15:35 ` Andrea Righi
2014-08-21 17:00 ` Andrea Righi
2014-08-21 17:07 ` Tejun Heo
[not found] ` <20140821170701.GA3940-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-08-21 17:45 ` Andrea Righi
2014-08-21 17:45 ` Andrea Righi
2014-08-21 23:45 ` Steven Rostedt
[not found] ` <20140821194514.0e97b26a-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2014-08-22 4:05 ` Andrea Righi
2014-08-22 4:05 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821153541.GA7625@Dell \
--to=andrea-oiiqvozpaevzfdhfmsdf5w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=matt-oIIqvOZpAevzfdHfmsDf5w@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.