Re: [meta-oe][PATCH] lmbench: if a machine config file exists, install it

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1957 bytes --]

On Fri, Aug 22, 2014 at 01:16:03PM -0700, Christopher Larson wrote:
> On Tue, Aug 19, 2014 at 5:07 AM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
> 
> > On Tue, Aug 19, 2014 at 04:49:24PM +0500, Yasir-Khan wrote:
> > > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> > > Signed-off-by: Yasir-Khan <yasir_khan@mentor.com>
> > > ---
> > >  .../recipes-benchmark/lmbench/lmbench_3.0-a9.bb    |    7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
> > b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
> > > index 41db150..a3873a6 100644
> > > --- a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
> > > +++ b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
> > > @@ -60,6 +60,13 @@ do_install () {
> > >             ${D}${bindir}/lmbench-run
> > >      install -m 0755 ${S}/scripts/lmbench ${D}${bindir}
> > >      install -m 0755 ${S}/scripts/* ${D}${datadir}/lmbench/scripts
> > > +
> > > +    # If the machine installs a config file, install it to the
> > appropriate place
> > > +    if [ -f ${WORKDIR}/CONFIG.${MACHINE} ]; then
> > > +        install -D 0644 ${WORKDIR}/CONFIG.${MACHINE} \
> > > +                        ${D}/${datadir}/lmbench
> > /bin/${TARGET_PREFIX}/CONFIG.${MACHINE}
> > > +    fi
> >
> > that makes lmbench MACHINE_ARCH and PACKAGE_ARCH isn't set that way.
> 
> 
> 
> Any objection to creating an lmbench-config package, either in lmbench or
> in its own recipe, making that machine specific, and rrecommending it from
> lmbench? IIRC that's how we usually handle such things (e.g. alsa-state
> pulls in alsa-states which is usually empty, but which bsps can append to
> pull in the machine specific configuration).

I'm fine with separate recipe, rdepended from main one and excluded with
SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]