* [meta-oe][PATCH] lmbench: if a machine config file exists, install it @ 2014-08-19 11:49 Yasir-Khan 2014-08-19 12:07 ` Martin Jansa 0 siblings, 1 reply; 4+ messages in thread From: Yasir-Khan @ 2014-08-19 11:49 UTC (permalink / raw) To: openembedded-devel; +Cc: Christopher Larson Signed-off-by: Christopher Larson <chris_larson@mentor.com> Signed-off-by: Yasir-Khan <yasir_khan@mentor.com> --- .../recipes-benchmark/lmbench/lmbench_3.0-a9.bb | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb index 41db150..a3873a6 100644 --- a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb +++ b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb @@ -60,6 +60,13 @@ do_install () { ${D}${bindir}/lmbench-run install -m 0755 ${S}/scripts/lmbench ${D}${bindir} install -m 0755 ${S}/scripts/* ${D}${datadir}/lmbench/scripts + + # If the machine installs a config file, install it to the appropriate place + if [ -f ${WORKDIR}/CONFIG.${MACHINE} ]; then + install -D 0644 ${WORKDIR}/CONFIG.${MACHINE} \ + ${D}/${datadir}/lmbench/bin/${TARGET_PREFIX}/CONFIG.${MACHINE} + fi + } pkg_postinst_${PN} () { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-oe][PATCH] lmbench: if a machine config file exists, install it 2014-08-19 11:49 [meta-oe][PATCH] lmbench: if a machine config file exists, install it Yasir-Khan @ 2014-08-19 12:07 ` Martin Jansa 2014-08-22 20:16 ` Christopher Larson 0 siblings, 1 reply; 4+ messages in thread From: Martin Jansa @ 2014-08-19 12:07 UTC (permalink / raw) To: openembedded-devel; +Cc: Christopher Larson [-- Attachment #1: Type: text/plain, Size: 1482 bytes --] On Tue, Aug 19, 2014 at 04:49:24PM +0500, Yasir-Khan wrote: > Signed-off-by: Christopher Larson <chris_larson@mentor.com> > Signed-off-by: Yasir-Khan <yasir_khan@mentor.com> > --- > .../recipes-benchmark/lmbench/lmbench_3.0-a9.bb | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > index 41db150..a3873a6 100644 > --- a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > +++ b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > @@ -60,6 +60,13 @@ do_install () { > ${D}${bindir}/lmbench-run > install -m 0755 ${S}/scripts/lmbench ${D}${bindir} > install -m 0755 ${S}/scripts/* ${D}${datadir}/lmbench/scripts > + > + # If the machine installs a config file, install it to the appropriate place > + if [ -f ${WORKDIR}/CONFIG.${MACHINE} ]; then > + install -D 0644 ${WORKDIR}/CONFIG.${MACHINE} \ > + ${D}/${datadir}/lmbench/bin/${TARGET_PREFIX}/CONFIG.${MACHINE} > + fi that makes lmbench MACHINE_ARCH and PACKAGE_ARCH isn't set that way. > > pkg_postinst_${PN} () { > -- > 1.7.9.5 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 188 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-oe][PATCH] lmbench: if a machine config file exists, install it 2014-08-19 12:07 ` Martin Jansa @ 2014-08-22 20:16 ` Christopher Larson 2014-08-22 21:09 ` Martin Jansa 0 siblings, 1 reply; 4+ messages in thread From: Christopher Larson @ 2014-08-22 20:16 UTC (permalink / raw) To: Openembedded Discussion On Tue, Aug 19, 2014 at 5:07 AM, Martin Jansa <martin.jansa@gmail.com> wrote: > On Tue, Aug 19, 2014 at 04:49:24PM +0500, Yasir-Khan wrote: > > Signed-off-by: Christopher Larson <chris_larson@mentor.com> > > Signed-off-by: Yasir-Khan <yasir_khan@mentor.com> > > --- > > .../recipes-benchmark/lmbench/lmbench_3.0-a9.bb | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > > index 41db150..a3873a6 100644 > > --- a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > > +++ b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > > @@ -60,6 +60,13 @@ do_install () { > > ${D}${bindir}/lmbench-run > > install -m 0755 ${S}/scripts/lmbench ${D}${bindir} > > install -m 0755 ${S}/scripts/* ${D}${datadir}/lmbench/scripts > > + > > + # If the machine installs a config file, install it to the > appropriate place > > + if [ -f ${WORKDIR}/CONFIG.${MACHINE} ]; then > > + install -D 0644 ${WORKDIR}/CONFIG.${MACHINE} \ > > + ${D}/${datadir}/lmbench > /bin/${TARGET_PREFIX}/CONFIG.${MACHINE} > > + fi > > that makes lmbench MACHINE_ARCH and PACKAGE_ARCH isn't set that way. Any objection to creating an lmbench-config package, either in lmbench or in its own recipe, making that machine specific, and rrecommending it from lmbench? IIRC that's how we usually handle such things (e.g. alsa-state pulls in alsa-states which is usually empty, but which bsps can append to pull in the machine specific configuration). -Chris ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-oe][PATCH] lmbench: if a machine config file exists, install it 2014-08-22 20:16 ` Christopher Larson @ 2014-08-22 21:09 ` Martin Jansa 0 siblings, 0 replies; 4+ messages in thread From: Martin Jansa @ 2014-08-22 21:09 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 1957 bytes --] On Fri, Aug 22, 2014 at 01:16:03PM -0700, Christopher Larson wrote: > On Tue, Aug 19, 2014 at 5:07 AM, Martin Jansa <martin.jansa@gmail.com> > wrote: > > > On Tue, Aug 19, 2014 at 04:49:24PM +0500, Yasir-Khan wrote: > > > Signed-off-by: Christopher Larson <chris_larson@mentor.com> > > > Signed-off-by: Yasir-Khan <yasir_khan@mentor.com> > > > --- > > > .../recipes-benchmark/lmbench/lmbench_3.0-a9.bb | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > > b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > > > index 41db150..a3873a6 100644 > > > --- a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > > > +++ b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb > > > @@ -60,6 +60,13 @@ do_install () { > > > ${D}${bindir}/lmbench-run > > > install -m 0755 ${S}/scripts/lmbench ${D}${bindir} > > > install -m 0755 ${S}/scripts/* ${D}${datadir}/lmbench/scripts > > > + > > > + # If the machine installs a config file, install it to the > > appropriate place > > > + if [ -f ${WORKDIR}/CONFIG.${MACHINE} ]; then > > > + install -D 0644 ${WORKDIR}/CONFIG.${MACHINE} \ > > > + ${D}/${datadir}/lmbench > > /bin/${TARGET_PREFIX}/CONFIG.${MACHINE} > > > + fi > > > > that makes lmbench MACHINE_ARCH and PACKAGE_ARCH isn't set that way. > > > > Any objection to creating an lmbench-config package, either in lmbench or > in its own recipe, making that machine specific, and rrecommending it from > lmbench? IIRC that's how we usually handle such things (e.g. alsa-state > pulls in alsa-states which is usually empty, but which bsps can append to > pull in the machine specific configuration). I'm fine with separate recipe, rdepended from main one and excluded with SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 188 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-22 21:09 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-19 11:49 [meta-oe][PATCH] lmbench: if a machine config file exists, install it Yasir-Khan 2014-08-19 12:07 ` Martin Jansa 2014-08-22 20:16 ` Christopher Larson 2014-08-22 21:09 ` Martin Jansa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.