From: Tony Lindgren <tony@atomide.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] ARM: OMAP2+: omap_device: remove warning that clk alias already exists
Date: Fri, 22 Aug 2014 16:07:00 -0700 [thread overview]
Message-ID: <20140822230700.GA17254@atomide.com> (raw)
In-Reply-To: <1407156844-21548-1-git-send-email-mpa@pengutronix.de>
* Markus Pargmann <mpa@pengutronix.de> [140804 05:56]:
> When an alias for a clock already exists the warning is printed. For
> every module with a main_clk defined, a clk alias for fck is added.
> There are some components that have the same main_clk defined, so this
> is a really normal situation.
>
> For example the am33xx edma device has 4 components using the same main
> clock. So there are three warnings in the boot log for this already
> existing clock alias:
> platform 49000000.edma: alias fck already exists
> platform 49000000.edma: alias fck already exists
> platform 49000000.edma: alias fck already exists
>
> As this is only interesting for developers, this patch changes the
> message to a debug message.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> arch/arm/mach-omap2/omap_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index 01ef59def44b..d22c30d3ccfa 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -56,7 +56,7 @@ static void _add_clkdev(struct omap_device *od, const char *clk_alias,
>
> r = clk_get_sys(dev_name(&od->pdev->dev), clk_alias);
> if (!IS_ERR(r)) {
> - dev_warn(&od->pdev->dev,
> + dev_dbg(&od->pdev->dev,
> "alias %s already exists\n", clk_alias);
> clk_put(r);
> return;
Thanks applying into omap-for-v3.17/fixes.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: omap_device: remove warning that clk alias already exists
Date: Fri, 22 Aug 2014 16:07:00 -0700 [thread overview]
Message-ID: <20140822230700.GA17254@atomide.com> (raw)
In-Reply-To: <1407156844-21548-1-git-send-email-mpa@pengutronix.de>
* Markus Pargmann <mpa@pengutronix.de> [140804 05:56]:
> When an alias for a clock already exists the warning is printed. For
> every module with a main_clk defined, a clk alias for fck is added.
> There are some components that have the same main_clk defined, so this
> is a really normal situation.
>
> For example the am33xx edma device has 4 components using the same main
> clock. So there are three warnings in the boot log for this already
> existing clock alias:
> platform 49000000.edma: alias fck already exists
> platform 49000000.edma: alias fck already exists
> platform 49000000.edma: alias fck already exists
>
> As this is only interesting for developers, this patch changes the
> message to a debug message.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> arch/arm/mach-omap2/omap_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index 01ef59def44b..d22c30d3ccfa 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -56,7 +56,7 @@ static void _add_clkdev(struct omap_device *od, const char *clk_alias,
>
> r = clk_get_sys(dev_name(&od->pdev->dev), clk_alias);
> if (!IS_ERR(r)) {
> - dev_warn(&od->pdev->dev,
> + dev_dbg(&od->pdev->dev,
> "alias %s already exists\n", clk_alias);
> clk_put(r);
> return;
Thanks applying into omap-for-v3.17/fixes.
Tony
next prev parent reply other threads:[~2014-08-22 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 12:54 [PATCH] ARM: OMAP2+: omap_device: remove warning that clk alias already exists Markus Pargmann
2014-08-04 12:54 ` Markus Pargmann
2014-08-22 23:07 ` Tony Lindgren [this message]
2014-08-22 23:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822230700.GA17254@atomide.com \
--to=tony@atomide.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.