From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Josh Triplett <josh@joshtriplett.org>,
Paul Mackerras <paulus@samba.org>,
kernel-janitors@vger.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] video: fbdev: aty: use c99 initializers in structures
Date: Mon, 25 Aug 2014 10:16:16 +0000 [thread overview]
Message-ID: <20140825101616.GD5046@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.02.1408231731550.2068@localhost6.localdomain6>
On Sat, Aug 23, 2014 at 05:32:37PM +0200, Julia Lawall wrote:
> >
> > The closing brace should be in column 0 of the next line. Also, the
> > final field initializer should have a comma after it. (Likewise for the
> > remaining changes in this file.)
>
> In general, I haven't changed the presence or absence of trailing commas.
> Should I add them everywhere?
Probably, yeah. Trailing commas are better.
It's not worth resending, but the script should add them I think.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Josh Triplett <josh@joshtriplett.org>,
Paul Mackerras <paulus@samba.org>,
kernel-janitors@vger.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] video: fbdev: aty: use c99 initializers in structures
Date: Mon, 25 Aug 2014 13:16:16 +0300 [thread overview]
Message-ID: <20140825101616.GD5046@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.02.1408231731550.2068@localhost6.localdomain6>
On Sat, Aug 23, 2014 at 05:32:37PM +0200, Julia Lawall wrote:
> >
> > The closing brace should be in column 0 of the next line. Also, the
> > final field initializer should have a comma after it. (Likewise for the
> > remaining changes in this file.)
>
> In general, I haven't changed the presence or absence of trailing commas.
> Should I add them everywhere?
Probably, yeah. Trailing commas are better.
It's not worth resending, but the script should add them I think.
regards,
dan carpenter
next prev parent reply other threads:[~2014-08-25 10:16 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 11:20 [PATCH 0/9] use c99 initializers in structures Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` [PATCH 1/9] [media] v4l: ti-vpe: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` [PATCH 2/9] video: fbdev: matrox: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` [PATCH 3/9] pwm: lpss: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-25 9:44 ` Thierry Reding
2014-08-25 9:44 ` Thierry Reding
2014-08-23 11:20 ` [PATCH 4/9] NFC: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` [PATCH 5/9] lustre: obdclass: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` [PATCH 6/9] drm: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 15:16 ` Josh Triplett
2014-08-23 15:16 ` Josh Triplett
2014-08-23 16:09 ` [PATCH 6/9 v2] " Julia Lawall
2014-08-23 16:09 ` Julia Lawall
2014-08-25 13:18 ` Daniel Vetter
2014-08-25 13:18 ` Daniel Vetter
2014-08-23 11:20 ` [PATCH 7/9] OMAPDSS: DSI: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 11:20 ` [PATCH 8/9] video: fbdev: aty: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 15:20 ` Josh Triplett
2014-08-23 15:20 ` Josh Triplett
2014-08-23 15:32 ` Julia Lawall
2014-08-23 15:32 ` Julia Lawall
2014-08-23 16:03 ` Josh Triplett
2014-08-23 16:03 ` Josh Triplett
2014-08-25 10:16 ` Dan Carpenter [this message]
2014-08-25 10:16 ` Dan Carpenter
2014-08-23 15:50 ` [PATCH 8/9 v2] " Julia Lawall
2014-08-23 15:50 ` Julia Lawall
2014-08-23 16:03 ` Josh Triplett
2014-08-23 16:03 ` Josh Triplett
2014-08-26 10:43 ` Tomi Valkeinen
2014-08-26 10:43 ` Tomi Valkeinen
2014-08-23 11:20 ` [PATCH 9/9] rtc: " Julia Lawall
2014-08-23 11:20 ` Julia Lawall
2014-08-23 15:21 ` [PATCH 0/9] " Josh Triplett
2014-08-23 15:21 ` Josh Triplett
2014-08-23 15:21 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825101616.GD5046@mwanda \
--to=dan.carpenter@oracle.com \
--cc=josh@joshtriplett.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.