From: Thierry Reding <thierry.reding@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Caesar Wang <caesar.wang@rock-chips.com>,
Sonny Rao <sonnyrao@chromium.org>,
olof@lixom.net, Eddie Cai <eddie.cai@rock-chips.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/3] pwm: rockchip: Allow polarity invert on rk3288
Date: Tue, 26 Aug 2014 15:41:39 +0200 [thread overview]
Message-ID: <20140826134138.GA2980@ulmo> (raw)
In-Reply-To: <1409007567-23523-2-git-send-email-dianders@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Mon, Aug 25, 2014 at 03:59:25PM -0700, Doug Anderson wrote:
> The rk3288 has the ability to invert the polarity of the PWM. Let's
> enable that ability. Note that this increases pwm_cells to 3 for
> rk3288.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Reviewed-by: Caesar Wang <caesar.wang@rock-chips.com>
> ---
> Changes in v5: None
> Changes in v4:
> - Updated comment not to add caveats about pwm_cells 3.
> - rockchip_pwm_set_polarity() is now static.
> - Separate pwm_ops for v1 and v2; no set_polarity() in v1.
> - Added a blank line.
>
> Changes in v3:
> - Don't store a private copy of polarity.
> - Use true instead of 1.
> - Cleanup init order with "has_invert".
>
> .../devicetree/bindings/pwm/pwm-rockchip.txt | 4 +-
> drivers/pwm/pwm-rockchip.c | 57 ++++++++++++++++++----
> 2 files changed, 50 insertions(+), 11 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] pwm: rockchip: Allow polarity invert on rk3288
Date: Tue, 26 Aug 2014 15:41:39 +0200 [thread overview]
Message-ID: <20140826134138.GA2980@ulmo> (raw)
In-Reply-To: <1409007567-23523-2-git-send-email-dianders@chromium.org>
On Mon, Aug 25, 2014 at 03:59:25PM -0700, Doug Anderson wrote:
> The rk3288 has the ability to invert the polarity of the PWM. Let's
> enable that ability. Note that this increases pwm_cells to 3 for
> rk3288.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Reviewed-by: Caesar Wang <caesar.wang@rock-chips.com>
> ---
> Changes in v5: None
> Changes in v4:
> - Updated comment not to add caveats about pwm_cells 3.
> - rockchip_pwm_set_polarity() is now static.
> - Separate pwm_ops for v1 and v2; no set_polarity() in v1.
> - Added a blank line.
>
> Changes in v3:
> - Don't store a private copy of polarity.
> - Use true instead of 1.
> - Cleanup init order with "has_invert".
>
> .../devicetree/bindings/pwm/pwm-rockchip.txt | 4 +-
> drivers/pwm/pwm-rockchip.c | 57 ++++++++++++++++++----
> 2 files changed, 50 insertions(+), 11 deletions(-)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140826/3b9f1c55/attachment.sig>
next prev parent reply other threads:[~2014-08-26 13:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 22:59 [PATCH v5 0/3] PWM changes for rk3288-evb Doug Anderson
2014-08-25 22:59 ` Doug Anderson
2014-08-25 22:59 ` Doug Anderson
[not found] ` <1409007567-23523-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-08-25 22:59 ` [PATCH v5 1/3] pwm: rockchip: Allow polarity invert on rk3288 Doug Anderson
2014-08-25 22:59 ` Doug Anderson
2014-08-25 22:59 ` Doug Anderson
2014-08-26 13:41 ` Thierry Reding [this message]
2014-08-26 13:41 ` Thierry Reding
2014-08-25 22:59 ` [PATCH v5 2/3] ARM: dts: Add main PWM info to rk3288 Doug Anderson
2014-08-25 22:59 ` Doug Anderson
2014-08-27 21:32 ` Heiko Stübner
2014-08-27 21:32 ` Heiko Stübner
2014-08-25 22:59 ` [PATCH v5 3/3] ARM: dts: Enable PWM backlight on rk3288-evb Doug Anderson
2014-08-25 22:59 ` Doug Anderson
2014-08-25 22:59 ` Doug Anderson
2014-08-27 21:33 ` Heiko Stübner
2014-08-27 21:33 ` Heiko Stübner
2014-08-27 21:33 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826134138.GA2980@ulmo \
--to=thierry.reding@gmail.com \
--cc=caesar.wang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eddie.cai@rock-chips.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.