From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] arm64: Fix INVALID_HWID definition
Date: Tue, 26 Aug 2014 16:57:16 +0100 [thread overview]
Message-ID: <20140826155715.GH16482@arm.com> (raw)
In-Reply-To: <6f84108ac880ef48548208738cbb169fba2fa51a.1408736066.git.geoff@infradead.org>
On Fri, Aug 22, 2014 at 08:49:16PM +0100, Geoff Levand wrote:
> Change the preprocessor macro INVALID_HWID definition from ULONG_MAX to (~0)
> to allow INVALID_HWID to be used within assembly source files.
>
> Commit 3e98fdacc59bbbdbb659be1a144ccc48ed4860fa (arm64: kernel: make the pen of
> the secondary a 64-bit unsigned value) added the preprocessor macro INVALID_HWID
> to asm/cputype.h with it defined to be ULONG_MAX. Use of INVALID_HWID in an
> assembly source file that includes cputype.h will generate an assembler
> undefined symbol ULONG_MAX build error. The kernel does define a ULONG_MAX in
> kernel.h, but that file not setup to be included in assembly files.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> arch/arm64/include/asm/cputype.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index 379d0b8..6b68380 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -16,7 +16,7 @@
> #ifndef __ASM_CPUTYPE_H
> #define __ASM_CPUTYPE_H
>
> -#define INVALID_HWID ULONG_MAX
> +#define INVALID_HWID UL(~0)
Does it actually expand to ULONG_MAX? ~0 is an int.
--
Catalin
next prev parent reply other threads:[~2014-08-26 15:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 19:49 [PATCH 0/9] arm64: minor fixups and enhancements Geoff Levand
2014-08-22 19:49 ` [PATCH 1/9] arm64: Fix efi kernel entry Geoff Levand
2014-08-26 15:55 ` Catalin Marinas
2014-08-26 16:19 ` Ard Biesheuvel
2014-08-26 18:42 ` Geoff Levand
2014-08-22 19:49 ` [PATCH 5/9] arm64: Fix include header order in vmlinux.lds.S Geoff Levand
2014-08-26 16:27 ` Mark Rutland
2014-08-26 19:27 ` Geoff Levand
2014-08-27 8:24 ` Catalin Marinas
2014-08-29 21:53 ` Geoff Levand
2014-08-22 19:49 ` [PATCH 3/9] arm64: Remove unneeded extern keyword Geoff Levand
2014-08-26 16:11 ` Mark Rutland
2014-08-22 19:49 ` [PATCH 4/9] arm64: Remove unused variable in head.S Geoff Levand
2014-08-27 8:40 ` Will Deacon
2014-08-22 19:49 ` [PATCH 6/9] arm64: Add new routine local_disable Geoff Levand
2014-08-26 16:04 ` Catalin Marinas
2014-08-26 16:23 ` Mark Rutland
2014-08-22 19:49 ` [PATCH 7/9] arm64: Add atomic macros to assembler.h Geoff Levand
2014-08-26 16:05 ` Catalin Marinas
2014-08-26 19:40 ` Geoff Levand
2014-08-27 8:25 ` Catalin Marinas
2014-08-22 19:49 ` [PATCH 2/9] arm64: Fix INVALID_HWID definition Geoff Levand
2014-08-26 15:57 ` Catalin Marinas [this message]
2014-08-26 18:18 ` Geoff Levand
2014-08-27 8:21 ` Catalin Marinas
2014-08-26 16:31 ` Mark Rutland
2014-08-26 17:38 ` Geoff Levand
2014-08-22 19:49 ` [PATCH 9/9] arm64: Add new cpu-return-addr device tree binding Geoff Levand
2014-08-22 19:49 ` Geoff Levand
2014-08-27 8:30 ` Catalin Marinas
2014-08-27 8:30 ` Catalin Marinas
2014-08-29 21:45 ` Geoff Levand
2014-08-29 21:45 ` Geoff Levand
2014-08-22 19:49 ` [PATCH 8/9] arm64: Add missing AT() macros to vmlinux.lds.S Geoff Levand
2014-08-26 16:08 ` Catalin Marinas
2014-08-26 19:33 ` Geoff Levand
2014-08-27 6:53 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826155715.GH16482@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.