* [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error
@ 2014-08-21 13:03 arei.gonglei
2014-08-25 3:29 ` [Qemu-devel] " Gonglei (Arei)
2014-08-27 13:06 ` Luiz Capitulino
0 siblings, 2 replies; 4+ messages in thread
From: arei.gonglei @ 2014-08-21 13:03 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.crosthwaite, Gonglei, weidong.huang, lcapitulino
From: Gonglei <arei.gonglei@huawei.com>
error: 'i' undeclared (first use in this function)
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
v2:
avoid to mix code and declarations, add a pair of {}, thanks Peter.
---
monitor.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 34cee74..667efb7 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4747,8 +4747,11 @@ static void monitor_find_completion(void *opaque,
return;
}
#ifdef DEBUG_COMPLETION
- for (i = 0; i < nb_args; i++) {
- monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
+ {
+ int i;
+ for (i = 0; i < nb_args; i++) {
+ monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
+ }
}
#endif
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [PATCH v2] monitor: fix debug print compiling error
2014-08-21 13:03 [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error arei.gonglei
@ 2014-08-25 3:29 ` Gonglei (Arei)
2014-08-27 13:06 ` Luiz Capitulino
1 sibling, 0 replies; 4+ messages in thread
From: Gonglei (Arei) @ 2014-08-25 3:29 UTC (permalink / raw)
To: Gonglei (Arei), qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Michael Tokarev,
peter.crosthwaite@xilinx.com, Huangweidong (C),
lcapitulino@redhat.com
Hi,
Cc'ing qemu-trivial. Please consider receiving, thanks.
Best regards,
-Gonglei
> -----Original Message-----
> From: Gonglei (Arei)
> Sent: Thursday, August 21, 2014 9:03 PM
> To: qemu-devel@nongnu.org
> Cc: lcapitulino@redhat.com; Huangweidong (C); peter.crosthwaite@xilinx.com;
> Gonglei (Arei)
> Subject: [PATCH v2] monitor: fix debug print compiling error
>
> From: Gonglei <arei.gonglei@huawei.com>
>
> error: 'i' undeclared (first use in this function)
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> v2:
> avoid to mix code and declarations, add a pair of {}, thanks Peter.
> ---
> monitor.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 34cee74..667efb7 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4747,8 +4747,11 @@ static void monitor_find_completion(void *opaque,
> return;
> }
> #ifdef DEBUG_COMPLETION
> - for (i = 0; i < nb_args; i++) {
> - monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
> + {
> + int i;
> + for (i = 0; i < nb_args; i++) {
> + monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
> + }
> }
> #endif
>
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error
@ 2014-08-25 3:29 ` Gonglei (Arei)
0 siblings, 0 replies; 4+ messages in thread
From: Gonglei (Arei) @ 2014-08-25 3:29 UTC (permalink / raw)
To: Gonglei (Arei), qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Michael Tokarev,
peter.crosthwaite@xilinx.com, Huangweidong (C),
lcapitulino@redhat.com
Hi,
Cc'ing qemu-trivial. Please consider receiving, thanks.
Best regards,
-Gonglei
> -----Original Message-----
> From: Gonglei (Arei)
> Sent: Thursday, August 21, 2014 9:03 PM
> To: qemu-devel@nongnu.org
> Cc: lcapitulino@redhat.com; Huangweidong (C); peter.crosthwaite@xilinx.com;
> Gonglei (Arei)
> Subject: [PATCH v2] monitor: fix debug print compiling error
>
> From: Gonglei <arei.gonglei@huawei.com>
>
> error: 'i' undeclared (first use in this function)
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> v2:
> avoid to mix code and declarations, add a pair of {}, thanks Peter.
> ---
> monitor.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 34cee74..667efb7 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4747,8 +4747,11 @@ static void monitor_find_completion(void *opaque,
> return;
> }
> #ifdef DEBUG_COMPLETION
> - for (i = 0; i < nb_args; i++) {
> - monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
> + {
> + int i;
> + for (i = 0; i < nb_args; i++) {
> + monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
> + }
> }
> #endif
>
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error
2014-08-21 13:03 [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error arei.gonglei
2014-08-25 3:29 ` [Qemu-devel] " Gonglei (Arei)
@ 2014-08-27 13:06 ` Luiz Capitulino
1 sibling, 0 replies; 4+ messages in thread
From: Luiz Capitulino @ 2014-08-27 13:06 UTC (permalink / raw)
To: arei.gonglei; +Cc: peter.crosthwaite, weidong.huang, qemu-devel
On Thu, 21 Aug 2014 21:03:09 +0800
<arei.gonglei@huawei.com> wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> error: 'i' undeclared (first use in this function)
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Applied to the qmp branch, thanks.
> ---
> v2:
> avoid to mix code and declarations, add a pair of {}, thanks Peter.
> ---
> monitor.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 34cee74..667efb7 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4747,8 +4747,11 @@ static void monitor_find_completion(void *opaque,
> return;
> }
> #ifdef DEBUG_COMPLETION
> - for (i = 0; i < nb_args; i++) {
> - monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
> + {
> + int i;
> + for (i = 0; i < nb_args; i++) {
> + monitor_printf(mon, "arg%d = '%s'\n", i, args[i]);
> + }
> }
> #endif
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-27 13:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-21 13:03 [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error arei.gonglei
2014-08-25 3:29 ` [Qemu-trivial] " Gonglei (Arei)
2014-08-25 3:29 ` [Qemu-devel] " Gonglei (Arei)
2014-08-27 13:06 ` Luiz Capitulino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.