From: Olof Johansson <olof@lixom.net>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: linux-serial@vger.kernel.org, naveenkrishna.ch@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, cpgs@samsung.com,
Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 14/14] tty/serial: samsung: add support for exynos7
Date: Wed, 27 Aug 2014 21:04:09 -0700 [thread overview]
Message-ID: <20140828040409.GE4972@localhost> (raw)
In-Reply-To: <1409132795-1991-1-git-send-email-ch.naveen@samsung.com>
On Wed, Aug 27, 2014 at 03:16:35PM +0530, Naveen Krishna Chatradhi wrote:
> From: Alim Akhtar <alim.akhtar@samsung.com>
>
> This patch enables upcoming exynos7 SoCs serial driver.
> This also modifies various dependencies for Kconfig
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/tty/serial/Kconfig | 6 +++---
> drivers/tty/serial/samsung.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 26cec64..f858d57 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -220,7 +220,7 @@ config SERIAL_CLPS711X_CONSOLE
>
> config SERIAL_SAMSUNG
> tristate "Samsung SoC serial support"
> - depends on PLAT_SAMSUNG
> + depends on PLAT_SAMSUNG || ARCH_EXYNOS7
Same here, PLAT_SAMSUNG || ARCH_EXYNOS please.
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1770,7 +1770,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
> #define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL
> #endif
>
> -#if defined(CONFIG_ARCH_EXYNOS)
> +#if defined(CONFIG_ARCH_EXYNOS) || defined(CONFIG_ARCH_EXYNOS7)
And then this change won't be needed either.
> static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
> .info = &(struct s3c24xx_uart_info) {
> .name = "Samsung Exynos4 UART",
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/14] tty/serial: samsung: add support for exynos7
Date: Wed, 27 Aug 2014 21:04:09 -0700 [thread overview]
Message-ID: <20140828040409.GE4972@localhost> (raw)
In-Reply-To: <1409132795-1991-1-git-send-email-ch.naveen@samsung.com>
On Wed, Aug 27, 2014 at 03:16:35PM +0530, Naveen Krishna Chatradhi wrote:
> From: Alim Akhtar <alim.akhtar@samsung.com>
>
> This patch enables upcoming exynos7 SoCs serial driver.
> This also modifies various dependencies for Kconfig
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/tty/serial/Kconfig | 6 +++---
> drivers/tty/serial/samsung.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 26cec64..f858d57 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -220,7 +220,7 @@ config SERIAL_CLPS711X_CONSOLE
>
> config SERIAL_SAMSUNG
> tristate "Samsung SoC serial support"
> - depends on PLAT_SAMSUNG
> + depends on PLAT_SAMSUNG || ARCH_EXYNOS7
Same here, PLAT_SAMSUNG || ARCH_EXYNOS please.
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1770,7 +1770,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
> #define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL
> #endif
>
> -#if defined(CONFIG_ARCH_EXYNOS)
> +#if defined(CONFIG_ARCH_EXYNOS) || defined(CONFIG_ARCH_EXYNOS7)
And then this change won't be needed either.
> static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
> .info = &(struct s3c24xx_uart_info) {
> .name = "Samsung Exynos4 UART",
-Olof
next prev parent reply other threads:[~2014-08-28 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 9:46 [PATCH 14/14] tty/serial: samsung: add support for exynos7 Naveen Krishna Chatradhi
2014-08-27 9:46 ` Naveen Krishna Chatradhi
2014-08-28 4:04 ` Olof Johansson [this message]
2014-08-28 4:04 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828040409.GE4972@localhost \
--to=olof@lixom.net \
--cc=alim.akhtar@samsung.com \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.