From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] apf27dev: add max1027 in the dts
Date: Mon, 1 Sep 2014 16:24:14 +0800 [thread overview]
Message-ID: <20140901082413.GE3135@dragon> (raw)
In-Reply-To: <1409517629-5918-1-git-send-email-tremyfr@gmail.com>
On Sun, Aug 31, 2014 at 10:40:29PM +0200, Philippe Reynes wrote:
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> arch/arm/boot/dts/imx27-apf27dev.dts | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> Changelog:
> v3: (thanks Alexander Shiyan for the feedback)
> - add datasheet pin name as comment
>
> v2: (thanks Alexander Shiyan for the feedback)
> - spi mode 0 is the default so no need to explicitly define it
>
> diff --git a/arch/arm/boot/dts/imx27-apf27dev.dts b/arch/arm/boot/dts/imx27-apf27dev.dts
> index b982309..0c08fbb 100644
> --- a/arch/arm/boot/dts/imx27-apf27dev.dts
> +++ b/arch/arm/boot/dts/imx27-apf27dev.dts
> @@ -82,6 +82,16 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_cspi1 &pinctrl_cspi1_cs>;
> status = "okay";
> +
> + adc at 0 {
> + compatible = "maxim,max1027";
> + reg = <0>;
> + interrupt-parent = <&gpio5>;
> + interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_max1027>;
> + spi-max-frequency = <10000000>;
> + };
> };
>
> &cspi2 {
> @@ -230,6 +240,13 @@
> pinctrl_sdhc2_cd: sdhc2cdgrp {
> fsl,pins = <MX27_PAD_TOUT__GPIO3_14 0x0>;
> };
> +
> + pinctrl_max1027: max1027 {
The pinctrl entries are alphabetically sorted in there. Can you also do
that for your addition?
> + fsl,pins = <
> + MX27_PAD_UART1_CTS__GPIO5_14 0 /* CNVST */
> + MX27_PAD_UART1_RTS__GPIO5_15 0 /* EOC */
Can you follow the convention to use hex value for the config cell,
i.e. s/0/0x0?
Shawn
> + >;
> + };
> };
> };
>
> --
> 1.7.4.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, shc_work@mail.ru
Subject: Re: [PATCH v3] apf27dev: add max1027 in the dts
Date: Mon, 1 Sep 2014 16:24:14 +0800 [thread overview]
Message-ID: <20140901082413.GE3135@dragon> (raw)
In-Reply-To: <1409517629-5918-1-git-send-email-tremyfr@gmail.com>
On Sun, Aug 31, 2014 at 10:40:29PM +0200, Philippe Reynes wrote:
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> arch/arm/boot/dts/imx27-apf27dev.dts | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> Changelog:
> v3: (thanks Alexander Shiyan for the feedback)
> - add datasheet pin name as comment
>
> v2: (thanks Alexander Shiyan for the feedback)
> - spi mode 0 is the default so no need to explicitly define it
>
> diff --git a/arch/arm/boot/dts/imx27-apf27dev.dts b/arch/arm/boot/dts/imx27-apf27dev.dts
> index b982309..0c08fbb 100644
> --- a/arch/arm/boot/dts/imx27-apf27dev.dts
> +++ b/arch/arm/boot/dts/imx27-apf27dev.dts
> @@ -82,6 +82,16 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_cspi1 &pinctrl_cspi1_cs>;
> status = "okay";
> +
> + adc@0 {
> + compatible = "maxim,max1027";
> + reg = <0>;
> + interrupt-parent = <&gpio5>;
> + interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_max1027>;
> + spi-max-frequency = <10000000>;
> + };
> };
>
> &cspi2 {
> @@ -230,6 +240,13 @@
> pinctrl_sdhc2_cd: sdhc2cdgrp {
> fsl,pins = <MX27_PAD_TOUT__GPIO3_14 0x0>;
> };
> +
> + pinctrl_max1027: max1027 {
The pinctrl entries are alphabetically sorted in there. Can you also do
that for your addition?
> + fsl,pins = <
> + MX27_PAD_UART1_CTS__GPIO5_14 0 /* CNVST */
> + MX27_PAD_UART1_RTS__GPIO5_15 0 /* EOC */
Can you follow the convention to use hex value for the config cell,
i.e. s/0/0x0?
Shawn
> + >;
> + };
> };
> };
>
> --
> 1.7.4.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <kernel@pengutronix.de>,
<shc_work@mail.ru>
Subject: Re: [PATCH v3] apf27dev: add max1027 in the dts
Date: Mon, 1 Sep 2014 16:24:14 +0800 [thread overview]
Message-ID: <20140901082413.GE3135@dragon> (raw)
In-Reply-To: <1409517629-5918-1-git-send-email-tremyfr@gmail.com>
On Sun, Aug 31, 2014 at 10:40:29PM +0200, Philippe Reynes wrote:
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> arch/arm/boot/dts/imx27-apf27dev.dts | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> Changelog:
> v3: (thanks Alexander Shiyan for the feedback)
> - add datasheet pin name as comment
>
> v2: (thanks Alexander Shiyan for the feedback)
> - spi mode 0 is the default so no need to explicitly define it
>
> diff --git a/arch/arm/boot/dts/imx27-apf27dev.dts b/arch/arm/boot/dts/imx27-apf27dev.dts
> index b982309..0c08fbb 100644
> --- a/arch/arm/boot/dts/imx27-apf27dev.dts
> +++ b/arch/arm/boot/dts/imx27-apf27dev.dts
> @@ -82,6 +82,16 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_cspi1 &pinctrl_cspi1_cs>;
> status = "okay";
> +
> + adc@0 {
> + compatible = "maxim,max1027";
> + reg = <0>;
> + interrupt-parent = <&gpio5>;
> + interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_max1027>;
> + spi-max-frequency = <10000000>;
> + };
> };
>
> &cspi2 {
> @@ -230,6 +240,13 @@
> pinctrl_sdhc2_cd: sdhc2cdgrp {
> fsl,pins = <MX27_PAD_TOUT__GPIO3_14 0x0>;
> };
> +
> + pinctrl_max1027: max1027 {
The pinctrl entries are alphabetically sorted in there. Can you also do
that for your addition?
> + fsl,pins = <
> + MX27_PAD_UART1_CTS__GPIO5_14 0 /* CNVST */
> + MX27_PAD_UART1_RTS__GPIO5_15 0 /* EOC */
Can you follow the convention to use hex value for the config cell,
i.e. s/0/0x0?
Shawn
> + >;
> + };
> };
> };
>
> --
> 1.7.4.4
>
next prev parent reply other threads:[~2014-09-01 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 20:40 [PATCH v3] apf27dev: add max1027 in the dts Philippe Reynes
2014-08-31 20:40 ` Philippe Reynes
2014-09-01 8:24 ` Shawn Guo [this message]
2014-09-01 8:24 ` Shawn Guo
2014-09-01 8:24 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901082413.GE3135@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.