All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Inha Song <ideal.song@samsung.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, sameo@linux.intel.com,
	pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	cw00.choi@samsung.com, broonie@kernel.org, galak@codeaurora.org,
	ckeepax@opensource.wolfsonmicro.com
Subject: Re: [PATCH v5 2/2] mfd: arizona: Update DT binding to support INn_MODE init_data
Date: Mon, 1 Sep 2014 09:34:00 +0100	[thread overview]
Message-ID: <20140901083400.GD7374@lee--X1> (raw)
In-Reply-To: <1409365639-5320-3-git-send-email-ideal.song@samsung.com>

On Sat, 30 Aug 2014, Inha Song wrote:

> This patch update DT binding to support INn_MODE init_data. Each
> input signal path can be configurated either as a Analogue or
> Digital using the INn_MODE registers.
> 
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied, thanks.

> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 5c7e723..7bd1273 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -42,6 +42,13 @@ Optional properties:
>      the chip default will be used.  If present exactly five values must
>      be specified.
>  
> +  - wlf,inmode : A list of INn_MODE register values, where n is the number
> +    of input signals. Valid values are 0 (Differential), 1 (Single-ended) and
> +    2 (Digital Microphone). If absent, INn_MODE registers set to 0 by default.

Please #define these in include/dt-bindings in a subsequent patch.

And an example?

> +    If present, values must be specified less than or equal to the number of
> +    input singals. If values less than the number of input signals, elements
> +    that has not been specifed are set to 0 by default.
> +
>    - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
>      they are being externally supplied. As covered in
>      Documentation/devicetree/bindings/regulator/regulator.txt

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Inha Song <ideal.song@samsung.com>
Cc: broonie@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, sameo@linux.intel.com,
	ckeepax@opensource.wolfsonmicro.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
	cw00.choi@samsung.com
Subject: Re: [alsa-devel] [PATCH v5 2/2] mfd: arizona: Update DT binding to support INn_MODE init_data
Date: Mon, 1 Sep 2014 09:34:00 +0100	[thread overview]
Message-ID: <20140901083400.GD7374@lee--X1> (raw)
In-Reply-To: <1409365639-5320-3-git-send-email-ideal.song@samsung.com>

On Sat, 30 Aug 2014, Inha Song wrote:

> This patch update DT binding to support INn_MODE init_data. Each
> input signal path can be configurated either as a Analogue or
> Digital using the INn_MODE registers.
> 
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied, thanks.

> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 5c7e723..7bd1273 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -42,6 +42,13 @@ Optional properties:
>      the chip default will be used.  If present exactly five values must
>      be specified.
>  
> +  - wlf,inmode : A list of INn_MODE register values, where n is the number
> +    of input signals. Valid values are 0 (Differential), 1 (Single-ended) and
> +    2 (Digital Microphone). If absent, INn_MODE registers set to 0 by default.

Please #define these in include/dt-bindings in a subsequent patch.

And an example?

> +    If present, values must be specified less than or equal to the number of
> +    input singals. If values less than the number of input signals, elements
> +    that has not been specifed are set to 0 by default.
> +
>    - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
>      they are being externally supplied. As covered in
>      Documentation/devicetree/bindings/regulator/regulator.txt

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-09-01  8:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30  2:27 [alsa-devel] [PATCH v5 0/2] mfd: arizona: add support for INn_MODE register control Inha Song
2014-08-30  2:27 ` Inha Song
     [not found] ` <1409365639-5320-1-git-send-email-ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-08-30  2:27   ` [alsa-devel] [PATCH v5 1/2] mfd: arizona: Add support for INn_Mode " Inha Song
2014-08-30  2:27     ` Inha Song
     [not found]     ` <1409365639-5320-2-git-send-email-ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-01  8:32       ` Lee Jones
2014-09-01  8:32         ` Lee Jones
2014-09-01  9:03         ` Charles Keepax
2014-09-01  9:03           ` Charles Keepax
2014-08-30  2:27 ` [alsa-devel] [PATCH v5 2/2] mfd: arizona: Update DT binding to support INn_MODE init_data Inha Song
2014-09-01  8:34   ` Lee Jones [this message]
2014-09-01  8:34     ` Lee Jones
2014-09-01  9:04     ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140901083400.GD7374@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ideal.song@samsung.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.