From: Jean-Francois Moine <moinejf@free.fr>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.de, kuninori.morimoto.gx@renesas.com, jsarha@ti.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] ASoC: simple-card: Fix bug of forgetting decrement DT node's refcount
Date: Mon, 1 Sep 2014 08:37:28 +0200 [thread overview]
Message-ID: <20140901083728.01454558@armhf> (raw)
In-Reply-To: <1409535327-11449-2-git-send-email-Li.Xiubo@freescale.com>
On Mon, 1 Sep 2014 09:35:26 +0800
Xiubo Li <Li.Xiubo@freescale.com> wrote:
> We shouldn't forget decrement the last DT node when the
> for_each_child_of_node() has finished searching.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> sound/soc/generic/simple-card.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
> index fd8b045..9e170fe 100644
> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -360,6 +360,7 @@ static int asoc_simple_card_parse_of(struct device_node *node,
> }
> i++;
> }
> + of_node_put(np);
> } else {
> ret = asoc_simple_card_dai_link_of(node, dev,
> dai_link, dai_props, true);
No. np is NULL at end of loop.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
<tiwai@suse.de>, <kuninori.morimoto.gx@renesas.com>,
<jsarha@ti.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 1/2] ASoC: simple-card: Fix bug of forgetting decrement DT node's refcount
Date: Mon, 1 Sep 2014 08:37:28 +0200 [thread overview]
Message-ID: <20140901083728.01454558@armhf> (raw)
In-Reply-To: <1409535327-11449-2-git-send-email-Li.Xiubo@freescale.com>
On Mon, 1 Sep 2014 09:35:26 +0800
Xiubo Li <Li.Xiubo@freescale.com> wrote:
> We shouldn't forget decrement the last DT node when the
> for_each_child_of_node() has finished searching.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> sound/soc/generic/simple-card.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
> index fd8b045..9e170fe 100644
> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -360,6 +360,7 @@ static int asoc_simple_card_parse_of(struct device_node *node,
> }
> i++;
> }
> + of_node_put(np);
> } else {
> ret = asoc_simple_card_dai_link_of(node, dev,
> dai_link, dai_props, true);
No. np is NULL at end of loop.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2014-09-01 6:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 1:35 [PATCHv2 0/2] ASoC: simple-card: Fix bug about DT node's refcount Xiubo Li
2014-09-01 1:35 ` Xiubo Li
2014-09-01 1:35 ` [PATCHv2 1/2] ASoC: simple-card: Fix bug of forgetting decrement " Xiubo Li
2014-09-01 1:35 ` Xiubo Li
2014-09-01 6:37 ` Jean-Francois Moine [this message]
2014-09-01 6:37 ` Jean-Francois Moine
2014-09-01 6:52 ` Li.Xiubo
2014-09-01 6:52 ` Li.Xiubo
2014-09-01 1:35 ` [PATCHv2 2/2] ASoC: simple-card: Fix bug of wrong " Xiubo Li
2014-09-01 1:35 ` Xiubo Li
2014-09-01 6:54 ` Jean-Francois Moine
2014-09-01 6:54 ` Jean-Francois Moine
2014-09-01 7:11 ` Li.Xiubo
2014-09-01 7:11 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901083728.01454558@armhf \
--to=moinejf@free.fr \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.