From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Emilio Lopez <emilio@elopez.com.ar>,
chris@printf.net, david.lanzendoerfer@o2s.ch,
ulf.hansson@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
kevin.z.m.zh@gmail.com, sunny@allwinnertech.com,
shuge@allwinnertech.com, zhuzhenhua@allwinnertech.com
Subject: Re: [PATCH v2 10/12] clk: sunxi: mod0: Introduce MMC proper phase handling
Date: Tue, 2 Sep 2014 09:52:34 +0200 [thread overview]
Message-ID: <20140902075234.GO15297@lukather> (raw)
In-Reply-To: <20140901213945.5251.37105@quantum>
[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]
Hi,
On Mon, Sep 01, 2014 at 02:39:45PM -0700, Mike Turquette wrote:
> Quoting Maxime Ripard (2014-08-30 13:03:09)
> > The MMC clock we thought we had until now are actually not one but three
> > different clocks.
> >
> > The main one is unchanged, and will have three outputs:
> > - The clock fed into the MMC
> > - a sample and output clocks, to deal with when should we output/sample data
> > to/from the MMC bus
> >
> > The phase control we had are actually controlling the two latter clocks, but
> > the main MMC one is unchanged.
> >
> > We can adjust the phase with a 3 bits value, from 0 to 7, 0 meaning a 180 phase
> > shift, and the other values being the number of periods from the MMC parent
> > clock to outphase the clock of.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Looks good. Thanks a lot for revisiting this after talking to your
> hardware team!
It's not *our* hardware team, but I'll let them know :)
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 10/12] clk: sunxi: mod0: Introduce MMC proper phase handling
Date: Tue, 2 Sep 2014 09:52:34 +0200 [thread overview]
Message-ID: <20140902075234.GO15297@lukather> (raw)
In-Reply-To: <20140901213945.5251.37105@quantum>
Hi,
On Mon, Sep 01, 2014 at 02:39:45PM -0700, Mike Turquette wrote:
> Quoting Maxime Ripard (2014-08-30 13:03:09)
> > The MMC clock we thought we had until now are actually not one but three
> > different clocks.
> >
> > The main one is unchanged, and will have three outputs:
> > - The clock fed into the MMC
> > - a sample and output clocks, to deal with when should we output/sample data
> > to/from the MMC bus
> >
> > The phase control we had are actually controlling the two latter clocks, but
> > the main MMC one is unchanged.
> >
> > We can adjust the phase with a 3 bits value, from 0 to 7, 0 meaning a 180 phase
> > shift, and the other values being the number of periods from the MMC parent
> > clock to outphase the clock of.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Looks good. Thanks a lot for revisiting this after talking to your
> hardware team!
It's not *our* hardware team, but I'll let them know :)
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140902/3984ede1/attachment-0001.sig>
next prev parent reply other threads:[~2014-09-02 7:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 20:02 [PATCH v2 00/12] clk: sunxi: Improve MMC clocks support Maxime Ripard
2014-08-30 20:02 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 01/12] clk: introduce clk_set_phase function & callback Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 02/12] clk: Include of.h in clock-provider.h Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 03/12] clk: Add a function to retrieve phase Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-31 10:15 ` Hans de Goede
2014-08-31 10:15 ` Hans de Goede
2014-09-01 10:20 ` Maxime Ripard
2014-09-01 10:20 ` Maxime Ripard
2014-09-01 11:27 ` Hans de Goede
2014-09-01 11:27 ` Hans de Goede
2014-09-02 9:50 ` Maxime Ripard
2014-09-02 9:50 ` Maxime Ripard
2014-09-02 11:03 ` David Lanzendörfer
2014-09-02 11:03 ` David Lanzendörfer
2014-09-01 19:00 ` Mike Turquette
2014-09-01 19:00 ` Mike Turquette
2014-09-02 9:34 ` Maxime Ripard
2014-09-02 9:34 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 04/12] clk: sunxi: factors: Invert the probing logic Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 05/12] clk: sunxi: Introduce mbus compatible Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 06/12] ARM: sunxi: dt: Switch to the new " Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 07/12] clk: sunxi: Move mod0 clock to a file of its own Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 08/12] clk: sunxi: Move mbus to mod0 file Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 09/12] ARM: sunxi: dt: Add sample and output mmc clocks Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-09-04 7:31 ` Chen-Yu Tsai
2014-08-30 20:03 ` [PATCH v2 10/12] clk: sunxi: mod0: Introduce MMC proper phase handling Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-09-01 21:39 ` Mike Turquette
2014-09-01 21:39 ` Mike Turquette
2014-09-02 7:52 ` Maxime Ripard [this message]
2014-09-02 7:52 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 11/12] mmc: sunxi: Convert MMC driver to the standard clock phase API Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
2014-08-30 20:03 ` [PATCH v2 12/12] clk: sunxi: Remove custom phase function Maxime Ripard
2014-08-30 20:03 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902075234.GO15297@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=chris@printf.net \
--cc=david.lanzendoerfer@o2s.ch \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=hdegoede@redhat.com \
--cc=kevin.z.m.zh@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
--cc=ulf.hansson@linaro.org \
--cc=zhuzhenhua@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.