* [PATCH] powercap/rapl: add support for cpu model 0x3f
@ 2014-08-13 20:33 Jason Baron
2014-08-13 22:50 ` Jacob Pan
0 siblings, 1 reply; 7+ messages in thread
From: Jason Baron @ 2014-08-13 20:33 UTC (permalink / raw)
To: jacob.jun.pan, rafael.j.wysocki
Cc: durgadoss.r, srivatsa.bhat, srinivas.pandruvada, linux-kernel
I've confirmed that monitoring the package power usage as well
as setting power limits appear to be working as expected. However,
I do see in the logs:
[ 5.082632] intel_rapl: RAPL domain core detection failed
[ 5.088370] intel_rapl: RAPL domain uncore detection failed
So I'm not sure if the h/w simply doesn't support that, or if the
driver could be improved here. In any case, adding the 0x3f makes
the driver useful for me. Tested aginst cpu:
Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
Signed-off-by: Jason Baron <jbaron@akamai.com>
---
drivers/powercap/intel_rapl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b1cda6f..a362dcc 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
{ X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
{ X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
{ X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
+ { X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
{ X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
/* TODO: Add more CPU IDs after testing */
{}
--
1.8.2.rc2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] powercap/rapl: add support for cpu model 0x3f
2014-08-13 20:33 Jason Baron
@ 2014-08-13 22:50 ` Jacob Pan
2014-08-14 14:21 ` Jason Baron
0 siblings, 1 reply; 7+ messages in thread
From: Jacob Pan @ 2014-08-13 22:50 UTC (permalink / raw)
To: Jason Baron
Cc: rafael.j.wysocki, durgadoss.r, srivatsa.bhat, srinivas.pandruvada,
linux-kernel, Rafael J. Wysocki
On Wed, 13 Aug 2014 20:33:26 +0000 (GMT)
Jason Baron <jbaron@akamai.com> wrote:
> I've confirmed that monitoring the package power usage as well
> as setting power limits appear to be working as expected. However,
> I do see in the logs:
>
> [ 5.082632] intel_rapl: RAPL domain core detection failed
> [ 5.088370] intel_rapl: RAPL domain uncore detection failed
>
> So I'm not sure if the h/w simply doesn't support that, or if the
> driver could be improved here. In any case, adding the 0x3f makes
> the driver useful for me. Tested aginst cpu:
>
> Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
>
I don't have this CPU model to test. Most server processors don't
have uncore domain so detection failed is normal. Looks like you just
have package and dram domain?
Thanks for testing it out, looks good to me. can you send it to
linux-pm list and cc rafael?
> Signed-off-by: Jason Baron <jbaron@akamai.com>
> ---
> drivers/powercap/intel_rapl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/powercap/intel_rapl.c
> b/drivers/powercap/intel_rapl.c index b1cda6f..a362dcc 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
> { X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
> { X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
> { X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
> + { X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
> { X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
> /* TODO: Add more CPU IDs after testing */
> {}
[Jacob Pan]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powercap/rapl: add support for cpu model 0x3f
2014-08-13 22:50 ` Jacob Pan
@ 2014-08-14 14:21 ` Jason Baron
0 siblings, 0 replies; 7+ messages in thread
From: Jason Baron @ 2014-08-14 14:21 UTC (permalink / raw)
To: Jacob Pan
Cc: rafael.j.wysocki@intel.com, durgadoss.r@intel.com,
srivatsa.bhat@linux.vnet.ibm.com,
srinivas.pandruvada@linux.intel.com, linux-kernel@vger.kernel.org
On 08/13/2014 06:50 PM, Jacob Pan wrote:
> On Wed, 13 Aug 2014 20:33:26 +0000 (GMT)
> Jason Baron <jbaron@akamai.com> wrote:
>
>> I've confirmed that monitoring the package power usage as well
>> as setting power limits appear to be working as expected. However,
>> I do see in the logs:
>>
>> [ 5.082632] intel_rapl: RAPL domain core detection failed
>> [ 5.088370] intel_rapl: RAPL domain uncore detection failed
>>
>> So I'm not sure if the h/w simply doesn't support that, or if the
>> driver could be improved here. In any case, adding the 0x3f makes
>> the driver useful for me. Tested aginst cpu:
>>
>> Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
>>
> I don't have this CPU model to test. Most server processors don't
> have uncore domain so detection failed is normal. Looks like you just
> have package and dram domain?
Yes.
> Thanks for testing it out, looks good to me. can you send it to
> linux-pm list and cc rafael?
>
Ok.
Thanks,
-Jason
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] powercap/rapl: add support for cpu model 0x3f
@ 2014-08-14 14:26 Jason Baron
2014-09-01 23:49 ` Rafael J. Wysocki
0 siblings, 1 reply; 7+ messages in thread
From: Jason Baron @ 2014-08-14 14:26 UTC (permalink / raw)
To: jacob.jun.pan, linux-pm
Cc: rafael.j.wysocki, durgadoss.r, srinivas.pandruvada
I've confirmed that monitoring the package power usage as well as setting power
limits appear to be working as expected. Supports the package and dram domains.
Tested aginst cpu:
Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
Signed-off-by: Jason Baron <jbaron@akamai.com>
---
drivers/powercap/intel_rapl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b1cda6f..a362dcc 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
{ X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
{ X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
{ X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
+ { X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
{ X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
/* TODO: Add more CPU IDs after testing */
{}
--
1.8.2.rc2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] powercap/rapl: add support for cpu model 0x3f
2014-08-14 14:26 [PATCH] powercap/rapl: add support for cpu model 0x3f Jason Baron
@ 2014-09-01 23:49 ` Rafael J. Wysocki
2014-09-02 14:31 ` Jason Baron
0 siblings, 1 reply; 7+ messages in thread
From: Rafael J. Wysocki @ 2014-09-01 23:49 UTC (permalink / raw)
To: Jason Baron
Cc: jacob.jun.pan, linux-pm, rafael.j.wysocki, durgadoss.r,
srinivas.pandruvada
On Thursday, August 14, 2014 02:26:08 PM Jason Baron wrote:
> I've confirmed that monitoring the package power usage as well as setting power
> limits appear to be working as expected. Supports the package and dram domains.
>
> Tested aginst cpu:
>
> Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
>
> Signed-off-by: Jason Baron <jbaron@akamai.com>
Has this been ACKed by Jacob?
> ---
> drivers/powercap/intel_rapl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index b1cda6f..a362dcc 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
> { X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
> { X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
> { X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
> + { X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
> { X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
> /* TODO: Add more CPU IDs after testing */
> {}
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powercap/rapl: add support for cpu model 0x3f
2014-09-01 23:49 ` Rafael J. Wysocki
@ 2014-09-02 14:31 ` Jason Baron
2014-09-02 17:41 ` Jacob Pan
0 siblings, 1 reply; 7+ messages in thread
From: Jason Baron @ 2014-09-02 14:31 UTC (permalink / raw)
To: Rafael J. Wysocki, jacob.jun.pan@linux.intel.com
Cc: linux-pm@vger.kernel.org, rafael.j.wysocki@intel.com,
durgadoss.r@intel.com, srinivas.pandruvada@linux.intel.com
Hi Rafael,
I think Jacob is ok with it:
https://lkml.org/lkml/2014/8/13/702
but he didn't give it a formal ack.
Thanks,
-Jason
On 09/01/2014 07:49 PM, Rafael J. Wysocki wrote:
> On Thursday, August 14, 2014 02:26:08 PM Jason Baron wrote:
>> I've confirmed that monitoring the package power usage as well as setting power
>> limits appear to be working as expected. Supports the package and dram domains.
>>
>> Tested aginst cpu:
>>
>> Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
>>
>> Signed-off-by: Jason Baron <jbaron@akamai.com>
>
> Has this been ACKed by Jacob?
>
>> ---
>> drivers/powercap/intel_rapl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
>> index b1cda6f..a362dcc 100644
>> --- a/drivers/powercap/intel_rapl.c
>> +++ b/drivers/powercap/intel_rapl.c
>> @@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
>> { X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
>> { X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
>> { X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
>> + { X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
>> { X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
>> /* TODO: Add more CPU IDs after testing */
>> {}
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powercap/rapl: add support for cpu model 0x3f
2014-09-02 14:31 ` Jason Baron
@ 2014-09-02 17:41 ` Jacob Pan
0 siblings, 0 replies; 7+ messages in thread
From: Jacob Pan @ 2014-09-02 17:41 UTC (permalink / raw)
To: Jason Baron
Cc: Rafael J. Wysocki, linux-pm@vger.kernel.org,
rafael.j.wysocki@intel.com, durgadoss.r@intel.com,
srinivas.pandruvada@linux.intel.com
On Tue, 02 Sep 2014 10:31:53 -0400
Jason Baron <jbaron@akamai.com> wrote:
> Hi Rafael,
>
> I think Jacob is ok with it:
>
> https://lkml.org/lkml/2014/8/13/702
>
> but he didn't give it a formal ack.
>
Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Thanks,
>
> -Jason
>
> On 09/01/2014 07:49 PM, Rafael J. Wysocki wrote:
> > On Thursday, August 14, 2014 02:26:08 PM Jason Baron wrote:
> >> I've confirmed that monitoring the package power usage as well as
> >> setting power limits appear to be working as expected. Supports
> >> the package and dram domains.
> >>
> >> Tested aginst cpu:
> >>
> >> Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
> >>
> >> Signed-off-by: Jason Baron <jbaron@akamai.com>
> >
> > Has this been ACKed by Jacob?
> >
> >> ---
> >> drivers/powercap/intel_rapl.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/powercap/intel_rapl.c
> >> b/drivers/powercap/intel_rapl.c index b1cda6f..a362dcc 100644
> >> --- a/drivers/powercap/intel_rapl.c
> >> +++ b/drivers/powercap/intel_rapl.c
> >> @@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
> >> { X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
> >> { X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
> >> { X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
> >> + { X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
> >> { X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
> >> /* TODO: Add more CPU IDs after testing */
> >> {}
> >>
> >
>
[Jacob Pan]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-09-02 17:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-14 14:26 [PATCH] powercap/rapl: add support for cpu model 0x3f Jason Baron
2014-09-01 23:49 ` Rafael J. Wysocki
2014-09-02 14:31 ` Jason Baron
2014-09-02 17:41 ` Jacob Pan
-- strict thread matches above, loose matches on Subject: below --
2014-08-13 20:33 Jason Baron
2014-08-13 22:50 ` Jacob Pan
2014-08-14 14:21 ` Jason Baron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.