From: Mark Rutland <mark.rutland@arm.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"varkabhadram@gmail.com" <varkabhadram@gmail.com>,
"tklauser@distanz.ch" <tklauser@distanz.ch>,
"heiko@sntech.de" <heiko@sntech.de>,
"yingjoe.chen@gmail.com" <yingjoe.chen@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] tty: serial: 8250: Add Mediatek UART driver
Date: Tue, 2 Sep 2014 12:35:30 +0100 [thread overview]
Message-ID: <20140902113530.GC7241@leverpostej> (raw)
In-Reply-To: <1407852737-17265-2-git-send-email-matthias.bgg@gmail.com>
[...]
> +static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p,
> + struct mtk8250_data *data)
> +{
> + int err;
> + struct device_node *np = pdev->dev.of_node;
> +
> + data->clk = of_clk_get(np, 0);
> + if (IS_ERR(data->clk)) {
> + dev_warn(&pdev->dev, "Can't get timer clock\n");
> + return PTR_ERR(data->clk);
> + }
Elsewhere you use devm_ interfaces. Can we not use devm_clk_get?
You might need to give the clock a name, but that's generally a good
thing -- it helps if a future revision has multiple clocks.
Mark.
next prev parent reply other threads:[~2014-09-02 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 14:12 [PATCH v4 0/2] tty: serial: Add mediatek UART driver Matthias Brugger
2014-08-12 14:12 ` Matthias Brugger
2014-08-12 14:12 ` [PATCH v4 1/2] tty: serial: 8250: Add Mediatek " Matthias Brugger
2014-09-02 11:35 ` Mark Rutland [this message]
2014-09-08 22:32 ` Greg KH
2014-08-12 14:12 ` [PATCH v4 2/2] DTS: serial: Add bindings documention for the Mediatek UARTs Matthias Brugger
[not found] ` <1407852737-17265-3-git-send-email-matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-02 11:31 ` Mark Rutland
2014-09-02 11:31 ` Mark Rutland
2014-09-08 22:33 ` Greg KH
2014-09-09 14:55 ` Matthias Brugger
2014-09-02 10:00 ` [PATCH v4 0/2] tty: serial: Add mediatek UART driver Matthias Brugger
[not found] ` <1407852737-17265-1-git-send-email-matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-02 10:08 ` Matthias Brugger
2014-09-02 10:08 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902113530.GC7241@leverpostej \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=alan@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tklauser@distanz.ch \
--cc=varkabhadram@gmail.com \
--cc=yingjoe.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.