From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] jbd2: fold __wait_cp_io into jbd2_log_do_checkpoint()
Date: Tue, 2 Sep 2014 13:00:01 -0400 [thread overview]
Message-ID: <20140902170001.GI6232@thunk.org> (raw)
In-Reply-To: <20140902163033.GC19412@quack.suse.cz>
On Tue, Sep 02, 2014 at 06:30:33PM +0200, Jan Kara wrote:
> Hum, is this really such a win? Unlike __process_buffer(), this function
> is well separated so IMHO the code is better readable before the folding.
I agree it's a closer call. I'm not wedded to folding in
__wait_cp_io. I was reacting more to the fact that the comment right
before the call to __wait_cp_io was horribly misleading, and when I
looked to confirm what I thought __wait_cp_io() was doing, it looked
like another static function used in exactly one place that could be
folded in.
If other folks think that it's more readable w/o this patch, I'm happy
to drop it. Anyone else have an opinion?
Cheers,
- Ted
next prev parent reply other threads:[~2014-09-02 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 2:14 [PATCH 1/2] jbd2: fold __process_buffer() into jbd2_log_do_checkpoint() Theodore Ts'o
2014-09-02 2:14 ` [PATCH 2/2] jbd2: fold __wait_cp_io " Theodore Ts'o
2014-09-02 16:30 ` Jan Kara
2014-09-02 17:00 ` Theodore Ts'o [this message]
2014-09-02 16:53 ` [PATCH 1/2] jbd2: fold __process_buffer() " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902170001.GI6232@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.