All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH] clk: qcom: Fix sdc 144kHz frequency entry
Date: Tue, 02 Sep 2014 14:44:02 -0700	[thread overview]
Message-ID: <20140902214402.5251.75274@quantum> (raw)
In-Reply-To: <1409341766-24366-1-git-send-email-sboyd@codeaurora.org>

Quoting Stephen Boyd (2014-08-29 12:49:26)
> The pre-divider for the sdc clocks only has 2 bits in it, so we
> can't possibly divide by anything larger than 4 here.
> Furthermore, we program the value of ~(n - m) and the n value is
> larger than 8 bits (max of 256). Replace this entry with 200kHz
> which is close enough to 144kHz to be usable.
> 
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Andy Gross <agross@codeaurora.org>
> Fixes: 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global clock controller (GCC)"
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Do you need this pulled into a 3.17-rc?

Regards,
Mike

> ---
>  drivers/clk/qcom/gcc-ipq806x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
> index 4032e510d9aa..3b83b7dd78c7 100644
> --- a/drivers/clk/qcom/gcc-ipq806x.c
> +++ b/drivers/clk/qcom/gcc-ipq806x.c
> @@ -1095,7 +1095,7 @@ static struct clk_branch prng_clk = {
>  };
>  
>  static const struct freq_tbl clk_tbl_sdc[] = {
> -       {    144000, P_PXO,   5, 18,625 },
> +       {    200000, P_PXO,   2, 2, 125 },
>         {    400000, P_PLL8,  4, 1, 240 },
>         {  16000000, P_PLL8,  4, 1,   6 },
>         {  17070000, P_PLL8,  1, 2,  45 },
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: qcom: Fix sdc 144kHz frequency entry
Date: Tue, 02 Sep 2014 14:44:02 -0700	[thread overview]
Message-ID: <20140902214402.5251.75274@quantum> (raw)
In-Reply-To: <1409341766-24366-1-git-send-email-sboyd@codeaurora.org>

Quoting Stephen Boyd (2014-08-29 12:49:26)
> The pre-divider for the sdc clocks only has 2 bits in it, so we
> can't possibly divide by anything larger than 4 here.
> Furthermore, we program the value of ~(n - m) and the n value is
> larger than 8 bits (max of 256). Replace this entry with 200kHz
> which is close enough to 144kHz to be usable.
> 
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Andy Gross <agross@codeaurora.org>
> Fixes: 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global clock controller (GCC)"
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Do you need this pulled into a 3.17-rc?

Regards,
Mike

> ---
>  drivers/clk/qcom/gcc-ipq806x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
> index 4032e510d9aa..3b83b7dd78c7 100644
> --- a/drivers/clk/qcom/gcc-ipq806x.c
> +++ b/drivers/clk/qcom/gcc-ipq806x.c
> @@ -1095,7 +1095,7 @@ static struct clk_branch prng_clk = {
>  };
>  
>  static const struct freq_tbl clk_tbl_sdc[] = {
> -       {    144000, P_PXO,   5, 18,625 },
> +       {    200000, P_PXO,   2, 2, 125 },
>         {    400000, P_PLL8,  4, 1, 240 },
>         {  16000000, P_PLL8,  4, 1,   6 },
>         {  17070000, P_PLL8,  1, 2,  45 },
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

  reply	other threads:[~2014-09-02 21:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 19:49 [PATCH] clk: qcom: Fix sdc 144kHz frequency entry Stephen Boyd
2014-08-29 19:49 ` Stephen Boyd
2014-09-02 21:44 ` Mike Turquette [this message]
2014-09-02 21:44   ` Mike Turquette
2014-09-02 22:01   ` Stephen Boyd
2014-09-02 22:01     ` Stephen Boyd
2014-09-02 23:52     ` Mike Turquette
2014-09-02 23:52       ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140902214402.5251.75274@quantum \
    --to=mturquette@linaro.org \
    --cc=agross@codeaurora.org \
    --cc=galak@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.