From: Matt Fleming <matt@console-pimps.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
linux-ia64@vger.kernel.org, matt.fleming@intel.com,
msalter@redhat.com
Subject: Re: [PATCH 3/5] x86: efi: format EFI memory type & attrs with efi_md_typeattr_format()
Date: Wed, 3 Sep 2014 13:07:51 +0100 [thread overview]
Message-ID: <20140903120751.GC3001@console-pimps.org> (raw)
In-Reply-To: <1409532820-5027-4-git-send-email-lersek@redhat.com>
On Mon, 01 Sep, at 02:53:38AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> arch/x86/platform/efi/efi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
I know this is a straight forward patch in the context of this series,
but you need to include a rationale, so that we know in 6 months, 12
months and 5 years from now why this change made sense.
Something like,
"Reduce the amount of duplicated code by using the helper function"
would be fine.
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
linux-ia64@vger.kernel.org, matt.fleming@intel.com,
msalter@redhat.com
Subject: Re: [PATCH 3/5] x86: efi: format EFI memory type & attrs with efi_md_typeattr_format()
Date: Wed, 03 Sep 2014 12:07:51 +0000 [thread overview]
Message-ID: <20140903120751.GC3001@console-pimps.org> (raw)
In-Reply-To: <1409532820-5027-4-git-send-email-lersek@redhat.com>
On Mon, 01 Sep, at 02:53:38AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> arch/x86/platform/efi/efi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
I know this is a straight forward patch in the context of this series,
but you need to include a rationale, so that we know in 6 months, 12
months and 5 years from now why this change made sense.
Something like,
"Reduce the amount of duplicated code by using the helper function"
would be fine.
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: matt@console-pimps.org (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] x86: efi: format EFI memory type & attrs with efi_md_typeattr_format()
Date: Wed, 3 Sep 2014 13:07:51 +0100 [thread overview]
Message-ID: <20140903120751.GC3001@console-pimps.org> (raw)
In-Reply-To: <1409532820-5027-4-git-send-email-lersek@redhat.com>
On Mon, 01 Sep, at 02:53:38AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> arch/x86/platform/efi/efi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
I know this is a straight forward patch in the context of this series,
but you need to include a rationale, so that we know in 6 months, 12
months and 5 years from now why this change made sense.
Something like,
"Reduce the amount of duplicated code by using the helper function"
would be fine.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-09-03 12:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 0:53 [PATCH 0/5] beautify EFI memmap logs Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
[not found] ` <1409532820-5027-1-git-send-email-lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-09-01 0:53 ` [PATCH 1/5] efi: add macro for EFI_MEMORY_UCE memory attribute Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` [PATCH 2/5] efi: introduce efi_md_typeattr_format() Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-03 12:46 ` Matt Fleming
2014-09-03 12:46 ` Matt Fleming
2014-09-03 12:46 ` Matt Fleming
2014-09-03 12:46 ` Matt Fleming
2014-09-01 0:53 ` [PATCH 4/5] ia64: efi: format EFI memory type & attrs with efi_md_typeattr_format() Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` [PATCH 3/5] x86: " Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-03 12:07 ` Matt Fleming [this message]
2014-09-03 12:07 ` Matt Fleming
2014-09-03 12:07 ` Matt Fleming
2014-09-01 0:53 ` [PATCH 5/5] arm64: " Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 0:53 ` Laszlo Ersek
2014-09-01 7:22 ` [PATCH 0/5] beautify EFI memmap logs Ingo Molnar
2014-09-01 7:22 ` Ingo Molnar
2014-09-01 7:22 ` Ingo Molnar
2014-09-01 9:37 ` Laszlo Ersek
2014-09-01 9:37 ` Laszlo Ersek
2014-09-01 9:37 ` Laszlo Ersek
2014-09-03 9:00 ` Ingo Molnar
2014-09-03 9:00 ` Ingo Molnar
2014-09-03 9:00 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903120751.GC3001@console-pimps.org \
--to=matt@console-pimps.org \
--cc=lersek@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=msalter@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.