From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: 'Geert Uytterhoeven'
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
'linux-spi' <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
'Nicolas Ferre'
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
'Axel Lin' <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>,
'Max Filippov' <jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 2/4] spi: atmel: remove unnecessary #if defined(CONFIG_OF)
Date: Wed, 3 Sep 2014 15:42:04 +0100 [thread overview]
Message-ID: <20140903144204.GS29327@sirena.org.uk> (raw)
In-Reply-To: <009801cfc715$e27d8030$a7788090$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Wed, Sep 03, 2014 at 10:25:02AM +0900, Jingoo Han wrote:
> However, personally I don't like #ifdef guards. I think that
> #ifdef guards can be removed for the same binary, regardless
> of kernel config options.
> In this case, the binary size is more important than #ifdef guards,
> right?
Right. The ideal thing would be to teach the module table stuff to
disable itself when the relevant support isn't in the kernel but that's
probably going to be hard to do in a tasteful fashion; perhaps wrappers
(OF_MODULE_TABLE) might be OK.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-03 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 3:22 [PATCH 1/4] spi: altera: remove unnecessary #ifdef CONFIG_OF Jingoo Han
[not found] ` <002a01cfc65d$2dc86640$895932c0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02 3:24 ` [PATCH 2/4] spi: atmel: remove unnecessary #if defined(CONFIG_OF) Jingoo Han
[not found] ` <002b01cfc65d$569ef570$03dce050$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02 7:49 ` Nicolas Ferre
2014-09-02 10:50 ` Mark Brown
[not found] ` <20140902105018.GR29327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-02 12:15 ` Geert Uytterhoeven
[not found] ` <CAMuHMdU2S_vwv3=CUtgGjqnq-nbh=up42gDWzR35ai6s4ZVaWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-02 16:36 ` Mark Brown
[not found] ` <20140902163658.GA29327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-03 1:25 ` Jingoo Han
[not found] ` <009801cfc715$e27d8030$a7788090$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-03 14:42 ` Mark Brown [this message]
2014-09-02 3:25 ` [PATCH 3/4] spi: oc-tiny: remove unnecessary #ifdef CONFIG_OF Jingoo Han
2014-09-02 3:26 ` [PATCH 4/4] spi: xtensa-xtfpga: " Jingoo Han
[not found] ` <002d01cfc65d$9fa78d90$def6a8b0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02 9:46 ` Max Filippov
2014-09-02 10:50 ` Mark Brown
2014-09-02 5:34 ` [PATCH 1/4] spi: altera: " Axel Lin
[not found] ` <CAFRkauAD7upo4e1Vc08FAMFamv=Lwy2whzJz3vADtse18kjriA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-02 11:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903144204.GS29327@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.