All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	'Mark Brown' <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/4] spi: atmel: remove unnecessary #if defined(CONFIG_OF)
Date: Tue, 2 Sep 2014 09:49:53 +0200	[thread overview]
Message-ID: <540576A1.3040800@atmel.com> (raw)
In-Reply-To: <002b01cfc65d$569ef570$03dce050$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

On 02/09/2014 05:24, Jingoo Han :
> Remove unnecessary  #if defined(CONFIG_OF), because this is
> already handled by the of_match_ptr macro.
> 
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Ok:
Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

> ---
>  drivers/spi/spi-atmel.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 113c83f44b5c..9f5066fa1473 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1481,14 +1481,12 @@ static SIMPLE_DEV_PM_OPS(atmel_spi_pm_ops, atmel_spi_suspend, atmel_spi_resume);
>  #define ATMEL_SPI_PM_OPS	NULL
>  #endif
>  
> -#if defined(CONFIG_OF)
>  static const struct of_device_id atmel_spi_dt_ids[] = {
>  	{ .compatible = "atmel,at91rm9200-spi" },
>  	{ /* sentinel */ }
>  };
>  
>  MODULE_DEVICE_TABLE(of, atmel_spi_dt_ids);
> -#endif
>  
>  static struct platform_driver atmel_spi_driver = {
>  	.driver		= {
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-09-02  7:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02  3:22 [PATCH 1/4] spi: altera: remove unnecessary #ifdef CONFIG_OF Jingoo Han
     [not found] ` <002a01cfc65d$2dc86640$895932c0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02  3:24   ` [PATCH 2/4] spi: atmel: remove unnecessary #if defined(CONFIG_OF) Jingoo Han
     [not found]     ` <002b01cfc65d$569ef570$03dce050$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02  7:49       ` Nicolas Ferre [this message]
2014-09-02 10:50       ` Mark Brown
     [not found]         ` <20140902105018.GR29327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-02 12:15           ` Geert Uytterhoeven
     [not found]             ` <CAMuHMdU2S_vwv3=CUtgGjqnq-nbh=up42gDWzR35ai6s4ZVaWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-02 16:36               ` Mark Brown
     [not found]                 ` <20140902163658.GA29327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-03  1:25                   ` Jingoo Han
     [not found]                     ` <009801cfc715$e27d8030$a7788090$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-03 14:42                       ` Mark Brown
2014-09-02  3:25   ` [PATCH 3/4] spi: oc-tiny: remove unnecessary #ifdef CONFIG_OF Jingoo Han
2014-09-02  3:26   ` [PATCH 4/4] spi: xtensa-xtfpga: " Jingoo Han
     [not found]     ` <002d01cfc65d$9fa78d90$def6a8b0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02  9:46       ` Max Filippov
2014-09-02 10:50       ` Mark Brown
2014-09-02  5:34   ` [PATCH 1/4] spi: altera: " Axel Lin
     [not found]     ` <CAFRkauAD7upo4e1Vc08FAMFamv=Lwy2whzJz3vADtse18kjriA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-02 11:16       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540576A1.3040800@atmel.com \
    --to=nicolas.ferre-aife0yeh4naavxtiumwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.