From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 0/4] clk: mvebu: Improve clock drift
Date: Wed, 03 Sep 2014 10:03:39 -0700 [thread overview]
Message-ID: <20140903170339.11368.17168@quantum> (raw)
In-Reply-To: <902cee907da9c532822dcf5db722b47c@doppler.thel33t.co.uk>
Quoting Leigh Brown (2014-09-03 07:40:56)
> On 2014-09-02 09:15, Gregory CLEMENT wrote:
> > Few users reported a timer drift on the Armada 370 based board such as
> > the mirabox or the Netgear ReadyNAS 102. This is the second series
> > with few improvements after the review of the 1st version.
> >
> > The reason is that when the SSCG (Spread Spectrum Clock Generator) is
> > enabled, it shifts the frequency of the clock. The percentage is no
> > more than 1% but when the clock is used for a timer it leads to a
> > clock drift.
> >
> > This series allows to correct the affected clock when the SSCG is
> > enabled. This drift can happen on all the mvebu SoC on the cpu clock
> > block (ie cpu, ddr and l2 cache). Currently the only notable effect is
> > for the Armada 370 because this SoC use the l2cache clock as source
> > for the timer. That's why even if the series allow any of the mvebu
> > SoC to benefit to this correction, Armada 370 is the only user of it.
> >
> > The first 2 patches should go through the clk subsystem, whereas the
> > third one should go to the arm-soc through the mvebu tree.
> >
> > The last one is just to fix a typo I found while I was reading the clk
> > code.
>
> This is working superbly for me on my Mirabox, and ntpd is now
> completely stable.
>
> Tested-by: Leigh Brown <leigh@solinno.co.uk>
>
Clock patches look good to me.
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Leigh Brown <leigh@solinno.co.uk>,
"Gregory CLEMENT" <gregory.clement@free-electrons.com>
Cc: linux-kernel@vger.kernel.org,
"Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
"Lior Amsalem" <alior@marvell.com>,
"Tawfik Bayouk" <tawfik@marvell.com>,
"Nadav Haklai" <nadavh@marvell.com>,
"Raphael Rigo" <ml-arm@syscall.eu>,
"Arnaud Ebalard" <arno@natisbad.org>,
"Simon Boulay" <simon.boulay@vitec.com>
Subject: Re: [PATCH V2 0/4] clk: mvebu: Improve clock drift
Date: Wed, 03 Sep 2014 10:03:39 -0700 [thread overview]
Message-ID: <20140903170339.11368.17168@quantum> (raw)
In-Reply-To: <902cee907da9c532822dcf5db722b47c@doppler.thel33t.co.uk>
Quoting Leigh Brown (2014-09-03 07:40:56)
> On 2014-09-02 09:15, Gregory CLEMENT wrote:
> > Few users reported a timer drift on the Armada 370 based board such as
> > the mirabox or the Netgear ReadyNAS 102. This is the second series
> > with few improvements after the review of the 1st version.
> >
> > The reason is that when the SSCG (Spread Spectrum Clock Generator) is
> > enabled, it shifts the frequency of the clock. The percentage is no
> > more than 1% but when the clock is used for a timer it leads to a
> > clock drift.
> >
> > This series allows to correct the affected clock when the SSCG is
> > enabled. This drift can happen on all the mvebu SoC on the cpu clock
> > block (ie cpu, ddr and l2 cache). Currently the only notable effect is
> > for the Armada 370 because this SoC use the l2cache clock as source
> > for the timer. That's why even if the series allow any of the mvebu
> > SoC to benefit to this correction, Armada 370 is the only user of it.
> >
> > The first 2 patches should go through the clk subsystem, whereas the
> > third one should go to the arm-soc through the mvebu tree.
> >
> > The last one is just to fix a typo I found while I was reading the clk
> > code.
>
> This is working superbly for me on my Mirabox, and ntpd is now
> completely stable.
>
> Tested-by: Leigh Brown <leigh@solinno.co.uk>
>
Clock patches look good to me.
Regards,
Mike
next prev parent reply other threads:[~2014-09-03 17:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 8:15 [PATCH V2 0/4] clk: mvebu: Improve clock drift Gregory CLEMENT
2014-09-02 8:15 ` Gregory CLEMENT
2014-09-02 8:15 ` [PATCH V2 1/4] clk: mvebu: Fix clk frequency value if SSCG is enabled Gregory CLEMENT
2014-09-02 8:15 ` Gregory CLEMENT
2014-09-02 8:15 ` [PATCH V2 2/4] clk: mvebu: armada-370: Fix timer drift caused by the SSCG deviation Gregory CLEMENT
2014-09-02 8:15 ` Gregory CLEMENT
2014-09-02 8:15 ` [PATCH V2 3/4] ARM: mvebu: add SSCG to Armada 370 Device Tree Gregory CLEMENT
2014-09-02 8:15 ` Gregory CLEMENT
2014-09-02 8:15 ` [PATCH V2 4/4] clk: mvebu: armada-375: Fix the description of the SAR in the comment Gregory CLEMENT
2014-09-02 8:15 ` Gregory CLEMENT
2014-09-03 14:40 ` [PATCH V2 0/4] clk: mvebu: Improve clock drift Leigh Brown
2014-09-03 14:40 ` Leigh Brown
2014-09-03 17:03 ` Mike Turquette [this message]
2014-09-03 17:03 ` Mike Turquette
2014-09-03 17:11 ` Jason Cooper
2014-09-03 17:11 ` Jason Cooper
2014-09-09 15:42 ` Jason Cooper
2014-09-09 15:42 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903170339.11368.17168@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.