Re: [PATCH v3 4/6] ext4: change lru to round-robin in extent status tree shrinker

[Theodore Ts'o <tytso@mit.edu>]

On Thu, Sep 04, 2014 at 12:14:02AM +0200, Jan Kara wrote:
> > I didn't think we were allowed to reschedule or sleep while in
> > shrinker context?
>   I believe we are allowed to sleep in the shrinker if appropriate gfp
> flags are set (__GFP_WAIT) and we enter extent cache shrinker only if
> __GFP_FS is set which guarantees __GFP_WAIT.

I must be missing something.  How is this guaranteed?

I can see how we can determine what gfp_mask was used in the
allocation which triggered the shrinker callback, by checking
shrink->gfp_mask, but I don't see anything that guarantees that the
extent cache shrinker is only entered if __GFP_FS is set.

I guess we could add something like:

	if ((shrink->gfp_mask & __GFP_WAIT) == 0)
		return 0;

to the beginning of ext4_es_scan(), but we're not doing that at the
moment.

       	     	      	      	      	 - Ted