From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH v3 2/6] ext4: track extent status tree shrinker delay statictics
Date: Thu, 4 Sep 2014 11:49:25 -0400 [thread overview]
Message-ID: <20140904154925.GF4047@thunk.org> (raw)
In-Reply-To: <20140904121048.GA13193@gmail.com>
On Thu, Sep 04, 2014 at 08:10:48PM +0800, Zheng Liu wrote:
> > When reading through this again, I realized that we probably don't want
> > this file in /proc/fs/ext4 but rather in /sys/kernel/debug/ext4 because
> > it's really a debugging interface and we don't want any tools to start
> > using it.
>
> Fair enough. I will fix it in next version.
I was actually OK with leaving it in /proc, since we have a number of
other debugging files in /proc/fs/ext4/<dev> already, and I'm not sure
spreading ext4's foot print so that we have some files in /proc, some
in /sys, and some in debugfs is worth decreasing the possibility that
some tool would start depending on the contents of that file --- I
can't really imagine why non-fs developers would ever care about such
statistics.
I probably *would* be in favor of creating a new config option which
disables /proc/fs/ext4/<dev>/mballoc_groups and
/proc/fs/ext4/<dev>/es_shrinker_info, to help with the people who care
shrinking the total footprint of the Linux kernel for embedded
application (kernel tinification), though.
- Ted
next prev parent reply other threads:[~2014-09-04 15:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 3:35 [PATCH v3 0/6] ext4: extents status tree shrinker improvement Zheng Liu
2014-08-07 3:35 ` [PATCH v3 1/6] ext4: improve extents status tree trace point Zheng Liu
2014-09-02 2:25 ` Theodore Ts'o
2014-08-07 3:35 ` [PATCH v3 2/6] ext4: track extent status tree shrinker delay statictics Zheng Liu
2014-08-27 13:26 ` Jan Kara
2014-09-04 12:10 ` Zheng Liu
2014-09-04 15:49 ` Theodore Ts'o [this message]
2014-08-07 3:35 ` [PATCH v3 3/6] ext4: cache extent hole in extent status tree for ext4_da_map_blocks() Zheng Liu
2014-08-27 13:55 ` Jan Kara
2014-09-04 13:05 ` Zheng Liu
2014-09-02 2:43 ` Theodore Ts'o
2014-09-04 13:04 ` Zheng Liu
2014-09-04 15:54 ` Theodore Ts'o
2014-08-07 3:35 ` [PATCH v3 4/6] ext4: change lru to round-robin in extent status tree shrinker Zheng Liu
2014-08-27 15:01 ` Jan Kara
2014-09-03 3:37 ` Theodore Ts'o
2014-09-03 15:31 ` Jan Kara
2014-09-03 20:00 ` Theodore Ts'o
2014-09-03 22:14 ` Jan Kara
2014-09-03 22:38 ` Theodore Ts'o
[not found] ` <20140904071553.GA26930@quack.suse.cz>
2014-09-04 15:44 ` Theodore Ts'o
2014-09-08 15:47 ` Jan Kara
2014-08-07 3:35 ` [PATCH v3 5/6] ext4: use a list to track all reclaimable objects for extent status tree Zheng Liu
2014-08-27 15:13 ` Jan Kara
2014-09-03 3:44 ` Theodore Ts'o
2014-08-07 3:35 ` [PATCH v3 6/6] ext4: use a garbage collection algorithm to manage object Zheng Liu
2014-08-27 15:24 ` Jan Kara
2014-10-20 14:48 ` [PATCH v3 0/6] ext4: extents status tree shrinker improvement Theodore Ts'o
2014-10-21 10:22 ` Jan Kara
2014-10-21 15:58 ` 刘峥(文卿)
2014-11-03 16:10 ` Jan Kara
2014-11-07 2:38 ` Zheng Liu
2014-11-13 23:40 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904154925.GF4047@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.