From: Joerg Roedel <joro@8bytes.org>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: linuxppc-dev@ozlabs.org, iommu@lists.linux-foundation.org,
alex.williamson@redhat.com, Emilian.Medve@freescale.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/fsl: Fix warning resulting from adding PCI device twice
Date: Thu, 4 Sep 2014 12:14:02 +0200 [thread overview]
Message-ID: <20140904101402.GM28786@8bytes.org> (raw)
In-Reply-To: <1409810622-742-1-git-send-email-Varun.Sethi@freescale.com>
On Thu, Sep 04, 2014 at 11:33:42AM +0530, Varun Sethi wrote:
> + if (!iommu_group_get(dev))
> + ret = iommu_group_add_device(group, dev);
>
> iommu_group_put(group);
> return ret;
Doesn't this additional call to iommu_group_get take a reference to the
iommu_group that needs to be released?
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: iommu@lists.linux-foundation.org, alex.williamson@redhat.com,
Emilian.Medve@freescale.com, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/fsl: Fix warning resulting from adding PCI device twice
Date: Thu, 4 Sep 2014 12:14:02 +0200 [thread overview]
Message-ID: <20140904101402.GM28786@8bytes.org> (raw)
In-Reply-To: <1409810622-742-1-git-send-email-Varun.Sethi@freescale.com>
On Thu, Sep 04, 2014 at 11:33:42AM +0530, Varun Sethi wrote:
> + if (!iommu_group_get(dev))
> + ret = iommu_group_add_device(group, dev);
>
> iommu_group_put(group);
> return ret;
Doesn't this additional call to iommu_group_get take a reference to the
iommu_group that needs to be released?
Joerg
next prev parent reply other threads:[~2014-09-04 10:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 6:03 [PATCH] iommu/fsl: Fix warning resulting from adding PCI device twice Varun Sethi
2014-09-04 6:03 ` Varun Sethi
2014-09-04 10:14 ` Joerg Roedel [this message]
2014-09-04 10:14 ` Joerg Roedel
2014-09-04 10:57 ` Varun Sethi
2014-09-04 10:57 ` Varun Sethi
2014-09-04 10:57 ` Varun Sethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904101402.GM28786@8bytes.org \
--to=joro@8bytes.org \
--cc=Emilian.Medve@freescale.com \
--cc=Varun.Sethi@freescale.com \
--cc=alex.williamson@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.