From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Btrfs: kfree()ing ERR_PTRs
Date: Thu, 04 Sep 2014 12:23:02 +0000 [thread overview]
Message-ID: <20140904122302.GP6549@mwanda> (raw)
In-Reply-To: <540856D4.8010903@bfs.de>
On Thu, Sep 04, 2014 at 02:11:00PM +0200, walter harms wrote:
> > ret = btrfs_ioctl_snap_create_transid(file, vol_args->name,
> > vol_args->fd, subvol, ptr,
> > readonly, inherit);
> > + if (ret)
> > + goto free_inherit;
> >
> > - if (ret = 0 && ptr &&
> > - copy_to_user(arg +
> > - offsetof(struct btrfs_ioctl_vol_args_v2,
> > - transid), ptr, sizeof(*ptr)))
> > + if (ptr && copy_to_user(arg +
> > + offsetof(struct btrfs_ioctl_vol_args_v2,
> > + transid),
> > + ptr, sizeof(*ptr)))
> > ret = -EFAULT;
>
>
> this is hard to read.
> perhaps it would help to move ptr into the other other
>
> if (ret || !ptr )
> goto free_inherit;
I don't think that's an improvement.
>
> both are modified by the call btrfs_ioctl_snap_create_transid().
>
I think you are mixing up ptr and *ptr so that's why you're confused.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Btrfs: kfree()ing ERR_PTRs
Date: Thu, 4 Sep 2014 15:23:02 +0300 [thread overview]
Message-ID: <20140904122302.GP6549@mwanda> (raw)
In-Reply-To: <540856D4.8010903@bfs.de>
On Thu, Sep 04, 2014 at 02:11:00PM +0200, walter harms wrote:
> > ret = btrfs_ioctl_snap_create_transid(file, vol_args->name,
> > vol_args->fd, subvol, ptr,
> > readonly, inherit);
> > + if (ret)
> > + goto free_inherit;
> >
> > - if (ret == 0 && ptr &&
> > - copy_to_user(arg +
> > - offsetof(struct btrfs_ioctl_vol_args_v2,
> > - transid), ptr, sizeof(*ptr)))
> > + if (ptr && copy_to_user(arg +
> > + offsetof(struct btrfs_ioctl_vol_args_v2,
> > + transid),
> > + ptr, sizeof(*ptr)))
> > ret = -EFAULT;
>
>
> this is hard to read.
> perhaps it would help to move ptr into the other other
>
> if (ret || !ptr )
> goto free_inherit;
I don't think that's an improvement.
>
> both are modified by the call btrfs_ioctl_snap_create_transid().
>
I think you are mixing up ptr and *ptr so that's why you're confused.
regards,
dan carpenter
next prev parent reply other threads:[~2014-09-04 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 11:09 [patch] Btrfs: kfree()ing ERR_PTRs Dan Carpenter
2014-09-04 11:09 ` Dan Carpenter
2014-09-04 12:11 ` walter harms
2014-09-04 12:11 ` walter harms
2014-09-04 12:23 ` Dan Carpenter [this message]
2014-09-04 12:23 ` Dan Carpenter
2014-09-04 12:48 ` Chris Mason
2014-09-04 12:48 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904122302.GP6549@mwanda \
--to=dan.carpenter@oracle.com \
--cc=clm@fb.com \
--cc=jbacik@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.