From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: frank.blaschka@de.ibm.com
Cc: qemu-devel@nongnu.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, aik@ozlabs.ru, pbonzini@redhat.com,
agraf@suse.de
Subject: Re: [RFC][patch 3/6] KVM: s390: Add GISA support
Date: Thu, 4 Sep 2014 16:19:42 +0200 [thread overview]
Message-ID: <20140904141942.GB4206@osiris> (raw)
In-Reply-To: <20140904105337.081387456@de.ibm.com>
On Thu, Sep 04, 2014 at 12:52:26PM +0200, frank.blaschka@de.ibm.com wrote:
> +void kvm_s390_gisa_register_alert(struct kvm *kvm, u32 gisc)
> +{
> + int bito = BITS_PER_BYTE * 7 + gisc;
> +
> + set_bit(bito ^ (BITS_PER_LONG - 1), &kvm->arch.iam);
> +}
Just a very minor nit: you could also use set_bit_inv() & friends.
> +static inline u64 kvm_s390_get_base_disp_rxy(struct kvm_vcpu *vcpu)
> +{
> + u32 x2 = (vcpu->arch.sie_block->ipa & 0x000f);
> + u32 base2 = vcpu->arch.sie_block->ipb >> 28;
> + u32 disp2 = ((vcpu->arch.sie_block->ipb & 0x0fff0000) >> 16) +
> + ((vcpu->arch.sie_block->ipb & 0xff00) << 4);
> +
> + return (base2 ? vcpu->run->s.regs.gprs[base2] : 0) +
> + (x2 ? vcpu->run->s.regs.gprs[x2] : 0) + (u64)disp2;
> +}
Not very readable ;) However.. for the RXY instruction format the 20 bit
displacement is usually signed and not unsigned like your code seems to
treat it.
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: frank.blaschka@de.ibm.com
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, aik@ozlabs.ru,
agraf@suse.de, qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC][patch 3/6] KVM: s390: Add GISA support
Date: Thu, 4 Sep 2014 16:19:42 +0200 [thread overview]
Message-ID: <20140904141942.GB4206@osiris> (raw)
In-Reply-To: <20140904105337.081387456@de.ibm.com>
On Thu, Sep 04, 2014 at 12:52:26PM +0200, frank.blaschka@de.ibm.com wrote:
> +void kvm_s390_gisa_register_alert(struct kvm *kvm, u32 gisc)
> +{
> + int bito = BITS_PER_BYTE * 7 + gisc;
> +
> + set_bit(bito ^ (BITS_PER_LONG - 1), &kvm->arch.iam);
> +}
Just a very minor nit: you could also use set_bit_inv() & friends.
> +static inline u64 kvm_s390_get_base_disp_rxy(struct kvm_vcpu *vcpu)
> +{
> + u32 x2 = (vcpu->arch.sie_block->ipa & 0x000f);
> + u32 base2 = vcpu->arch.sie_block->ipb >> 28;
> + u32 disp2 = ((vcpu->arch.sie_block->ipb & 0x0fff0000) >> 16) +
> + ((vcpu->arch.sie_block->ipb & 0xff00) << 4);
> +
> + return (base2 ? vcpu->run->s.regs.gprs[base2] : 0) +
> + (x2 ? vcpu->run->s.regs.gprs[x2] : 0) + (u64)disp2;
> +}
Not very readable ;) However.. for the RXY instruction format the 20 bit
displacement is usually signed and not unsigned like your code seems to
treat it.
next prev parent reply other threads:[~2014-09-04 14:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 10:52 [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390 frank.blaschka
2014-09-04 10:52 ` [Qemu-devel] " frank.blaschka
2014-09-04 10:52 ` [RFC][patch 1/6] s390: cio: chsc function to register GIB frank.blaschka
2014-09-04 10:52 ` [Qemu-devel] " frank.blaschka
2014-09-04 10:52 ` [RFC][patch 2/6] s390: pci: export pci functions for pass-through usage frank.blaschka
2014-09-04 10:52 ` [Qemu-devel] " frank.blaschka
2014-09-04 10:52 ` [RFC][patch 3/6] KVM: s390: Add GISA support frank.blaschka
2014-09-04 10:52 ` [Qemu-devel] " frank.blaschka
2014-09-04 14:19 ` Heiko Carstens [this message]
2014-09-04 14:19 ` Heiko Carstens
2014-09-05 8:29 ` Alexander Graf
2014-09-05 8:29 ` [Qemu-devel] " Alexander Graf
2014-09-05 10:52 ` Frank Blaschka
2014-09-05 10:52 ` [Qemu-devel] " Frank Blaschka
2014-09-04 10:52 ` [RFC][patch 4/6] KVM: s390: Add PCI pass-through support frank.blaschka
2014-09-04 10:52 ` [Qemu-devel] " frank.blaschka
2014-09-05 8:37 ` Alexander Graf
2014-09-05 8:37 ` [Qemu-devel] " Alexander Graf
2014-09-04 10:52 ` [RFC][patch 5/6] s390: Add PCI bus support frank.blaschka
2014-09-04 10:52 ` [Qemu-devel] " frank.blaschka
2014-09-04 10:52 ` [RFC][patch 6/6] s390: Add PCI pass-through device support frank.blaschka
2014-09-04 10:52 ` [Qemu-devel] " frank.blaschka
2014-09-04 13:16 ` [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390 Alex Williamson
2014-09-04 13:16 ` [Qemu-devel] " Alex Williamson
2014-09-05 7:46 ` Frank Blaschka
2014-09-05 7:46 ` [Qemu-devel] " Frank Blaschka
2014-09-05 8:35 ` Alexander Graf
2014-09-05 8:35 ` [Qemu-devel] " Alexander Graf
2014-09-05 11:55 ` Frank Blaschka
2014-09-05 11:55 ` [Qemu-devel] " Frank Blaschka
2014-09-05 23:03 ` Alexander Graf
2014-09-05 23:03 ` [Qemu-devel] " Alexander Graf
2014-09-05 8:21 ` Alexander Graf
2014-09-05 8:21 ` [Qemu-devel] " Alexander Graf
2014-09-05 11:39 ` Frank Blaschka
2014-09-05 11:39 ` [Qemu-devel] " Frank Blaschka
2014-09-05 23:19 ` Alexander Graf
2014-09-05 23:19 ` [Qemu-devel] " Alexander Graf
2014-09-08 9:20 ` Paolo Bonzini
2014-09-08 9:20 ` [Qemu-devel] " Paolo Bonzini
2014-09-08 14:19 ` Alex Williamson
2014-09-08 14:19 ` [Qemu-devel] " Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904141942.GB4206@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=frank.blaschka@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.