All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org,
	mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
	sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org,
	kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH v9 2/3] clk: RK808: Add clkout driver for RK808
Date: Thu, 4 Sep 2014 10:40:24 -0700	[thread overview]
Message-ID: <20140904174024.GD10224@core.coreip.homeip.net> (raw)
In-Reply-To: <1409793159-2573-3-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Hi Chris,

On Thu, Sep 04, 2014 at 09:12:38AM +0800, Chris Zhong wrote:
> +	rk808_clkout->clk_data.clks = clk_table;
> +	rk808_clkout->clk_data.clk_num = RK808_NR_OUTPUT;
> +
> +	return of_clk_add_provider(node, of_clk_src_onecell_get,
> +				   &rk808_clkout->clk_data);
> +}
> +
> +static struct platform_driver rk808_clkout_driver = {
> +	.probe = rk808_clkout_probe,
> +	.driver		= {
> +		.name	= "rk808-clkout",
> +	},
> +};

Shouldn't there also be:

static int rk808_clkout_probe(struct platform_device *pdev)
{
	of_clk_del_provider(pdev->dev.of_node);

	/* The rest of resources are managed ones */

	return 0;
}

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Zhong <zyw@rock-chips.com>
Cc: dianders@chromium.org, heiko@sntech.de, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	sameo@linux.intel.com, lee.jones@linaro.org, lgirdwood@gmail.com,
	a.zummo@towertech.it, mturquette@linaro.org,
	akpm@linux-foundation.org, broonie@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	rtc-linux@googlegroups.com, grant.likely@linaro.org,
	hl@rock-chips.com, huangtao@rock-chips.com, cf@rock-chips.com,
	zhangqing@rock-chips.com, xxx@rock-chips.com, olof@lixom.net,
	sonnyrao@chromium.org, javier.martinez@collabora.co.uk,
	kever.yang@rock-chips.com
Subject: Re: [PATCH v9 2/3] clk: RK808: Add clkout driver for RK808
Date: Thu, 4 Sep 2014 10:40:24 -0700	[thread overview]
Message-ID: <20140904174024.GD10224@core.coreip.homeip.net> (raw)
In-Reply-To: <1409793159-2573-3-git-send-email-zyw@rock-chips.com>

Hi Chris,

On Thu, Sep 04, 2014 at 09:12:38AM +0800, Chris Zhong wrote:
> +	rk808_clkout->clk_data.clks = clk_table;
> +	rk808_clkout->clk_data.clk_num = RK808_NR_OUTPUT;
> +
> +	return of_clk_add_provider(node, of_clk_src_onecell_get,
> +				   &rk808_clkout->clk_data);
> +}
> +
> +static struct platform_driver rk808_clkout_driver = {
> +	.probe = rk808_clkout_probe,
> +	.driver		= {
> +		.name	= "rk808-clkout",
> +	},
> +};

Shouldn't there also be:

static int rk808_clkout_probe(struct platform_device *pdev)
{
	of_clk_del_provider(pdev->dev.of_node);

	/* The rest of resources are managed ones */

	return 0;
}

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2014-09-04 17:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04  1:12 [PATCH v9 0/3] Add rockchip RK808 pmic driver Chris Zhong
2014-09-04  1:12 ` Chris Zhong
2014-09-04  1:12 ` [PATCH v9 1/3] RTC: RK808: add RTC driver for RK808 Chris Zhong
     [not found]   ` <1409793159-2573-2-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-04  4:18     ` Doug Anderson
2014-09-04  4:18       ` Doug Anderson
     [not found]       ` <CAD=FV=U8XK945vJTnsY8FG3+WasOrMnoCYOF+b360HTyXVccfw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-04 17:33         ` Dmitry Torokhov
2014-09-04 17:33           ` Dmitry Torokhov
2014-09-04 19:04           ` Doug Anderson
2014-09-04 19:04             ` Doug Anderson
     [not found]             ` <CAD=FV=VDG=PteMYCkju1GGpK1CNLZeY8precPJkgxYY4udD-eg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-04 20:08               ` Dmitry Torokhov
2014-09-04 20:08                 ` Dmitry Torokhov
2014-09-04  1:12 ` [PATCH v9 2/3] clk: RK808: Add clkout " Chris Zhong
     [not found]   ` <1409793159-2573-3-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-04 17:40     ` Dmitry Torokhov [this message]
2014-09-04 17:40       ` Dmitry Torokhov
     [not found]       ` <20140904174024.GD10224-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2014-09-04 18:02         ` Heiko Stübner
2014-09-04 18:02           ` Heiko Stübner
2014-09-04 18:34           ` Dmitry Torokhov
2014-09-04 18:34             ` Dmitry Torokhov
2014-09-05  1:35     ` Mike Turquette
2014-09-05  1:35       ` Mike Turquette
2014-09-04  1:12 ` [PATCH v9 3/3] regulator: RK808: Remove pdata from the regulator Chris Zhong
     [not found]   ` <1409793159-2573-4-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-04  4:21     ` Doug Anderson
2014-09-04  4:21       ` Doug Anderson
2014-09-04 19:07     ` Doug Anderson
2014-09-04 19:07       ` Doug Anderson
     [not found] ` <1409793159-2573-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-09 11:45   ` [PATCH v9 0/3] Add rockchip RK808 pmic driver Heiko Stübner
2014-09-09 11:45     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140904174024.GD10224@core.coreip.homeip.net \
    --to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
    --cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.