From: b.galvani@gmail.com (Beniamino Galvani)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/4] ethernet: arc: Add support for Rockchip SoC layer device tree bindings
Date: Thu, 4 Sep 2014 23:38:21 +0200 [thread overview]
Message-ID: <20140904213821.GA13511@gmail.com> (raw)
In-Reply-To: <3809311.80Auz8fbHu@wuerfel>
On Thu, Sep 04, 2014 at 11:33:38AM +0200, Arnd Bergmann wrote:
> This is a recurring problem:
>
> driver a depends on x and selects y
> driver b depends on y and selects x
>
> Maybe we should teach Kconfig to not worry about it when x and y are
> both user-selectable as well.
>
> However, a nicer solution would be if we could agree for each symbol
> on who is supposed to 'select' or 'depends on' it. In particular,
> we are inconsistent about CONFIG_REGULATOR:
>
> MDIO_SUN4I probably should not 'select' it but instead 'depends on'
> this symbol if anything. It would be nice if someone could submit
> a patch to that effect. EMAC_ROCKCHIP could also drop the dependency
> on REGULATOR: you can still build the driver without that subsystem
> being enabled, but then all the regulators have to be set up by
> the boot loader.
Thanks, things are clearer now.
If I understand correctly the dependency of MDIO_SUN4I on REGULATOR
can be dropped as well for the same reason; I will send a patch for
that.
Beniamino
>
> There isn't much we can do about the PHYLIB dependency, unless we
> turn it into a silent symbol that gets selected by all phy drivers,
> or we change all network drivers that currently 'select' it to
> 'depends on'. I don't really want to get involved in that discussion ;-)
>
> Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Beniamino Galvani <b.galvani@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Romain Perier <romain.perier@gmail.com>,
heiko@sntech.de, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/4] ethernet: arc: Add support for Rockchip SoC layer device tree bindings
Date: Thu, 4 Sep 2014 23:38:21 +0200 [thread overview]
Message-ID: <20140904213821.GA13511@gmail.com> (raw)
In-Reply-To: <3809311.80Auz8fbHu@wuerfel>
On Thu, Sep 04, 2014 at 11:33:38AM +0200, Arnd Bergmann wrote:
> This is a recurring problem:
>
> driver a depends on x and selects y
> driver b depends on y and selects x
>
> Maybe we should teach Kconfig to not worry about it when x and y are
> both user-selectable as well.
>
> However, a nicer solution would be if we could agree for each symbol
> on who is supposed to 'select' or 'depends on' it. In particular,
> we are inconsistent about CONFIG_REGULATOR:
>
> MDIO_SUN4I probably should not 'select' it but instead 'depends on'
> this symbol if anything. It would be nice if someone could submit
> a patch to that effect. EMAC_ROCKCHIP could also drop the dependency
> on REGULATOR: you can still build the driver without that subsystem
> being enabled, but then all the regulators have to be set up by
> the boot loader.
Thanks, things are clearer now.
If I understand correctly the dependency of MDIO_SUN4I on REGULATOR
can be dropped as well for the same reason; I will send a patch for
that.
Beniamino
>
> There isn't much we can do about the PHYLIB dependency, unless we
> turn it into a silent symbol that gets selected by all phy drivers,
> or we change all network drivers that currently 'select' it to
> 'depends on'. I don't really want to get involved in that discussion ;-)
>
> Arnd
next prev parent reply other threads:[~2014-09-04 21:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 16:52 [PATCH v5 1/4] ethernet: arc: Add support for Rockchip SoC layer device tree bindings Romain Perier
2014-09-03 16:52 ` Romain Perier
2014-09-03 16:52 ` [PATCH v2 2/4] dt-bindings: Document EMAC Rockchip Romain Perier
2014-09-03 16:52 ` Romain Perier
2014-09-03 18:41 ` PERIER Romain
2014-09-04 12:13 ` Heiko Stübner
2014-09-04 12:13 ` Heiko Stübner
2014-09-03 16:52 ` [PATCH 3/4] ARM: dts: Add emac nodes to the rk3188 device tree Romain Perier
2014-09-03 16:52 ` Romain Perier
2014-09-04 12:11 ` Heiko Stübner
2014-09-04 12:11 ` Heiko Stübner
2014-09-03 16:52 ` [PATCH v2 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards Romain Perier
2014-09-03 16:52 ` Romain Perier
2014-09-03 18:17 ` [PATCH v5 1/4] ethernet: arc: Add support for Rockchip SoC layer device tree bindings Arnd Bergmann
2014-09-03 18:17 ` Arnd Bergmann
2014-09-03 21:12 ` Beniamino Galvani
2014-09-03 21:12 ` Beniamino Galvani
2014-09-04 8:45 ` PERIER Romain
2014-09-04 19:30 ` Beniamino Galvani
2014-09-04 19:30 ` Beniamino Galvani
2014-09-04 9:33 ` Arnd Bergmann
2014-09-04 21:38 ` Beniamino Galvani [this message]
2014-09-04 21:38 ` Beniamino Galvani
2014-09-04 12:05 ` Heiko Stübner
2014-09-04 12:05 ` Heiko Stübner
2014-09-05 22:10 ` David Miller
2014-09-05 22:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904213821.GA13511@gmail.com \
--to=b.galvani@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.