From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv4 2/2] dt-bindings: regulator: Add regulator suspend state for PM state
Date: Thu, 4 Sep 2014 23:53:03 +0100 [thread overview]
Message-ID: <20140904225303.GY29327@sirena.org.uk> (raw)
In-Reply-To: <1408343223-4043-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On Mon, Aug 18, 2014 at 03:27:03PM +0900, Chanwoo Choi wrote:
> +- regulator-initial-state: initial state for suspend state, cnd set initial
> + state among following defined suspend states:
> + <3>: PM_SUSPEND_MEM - Setup regulator according to regulator-state-mem
> + <4>: PM_SUSPEND_MAX - Setup regulator according to regulator-state-disk
Please add defines for these in include/dt-bindings. Probably worth
pointing out that if absent the state is the hardware default (same for
most of these.
> +- regulator-state-[mem/disk] node has following common properties:
> + - regulator-volt: voltage consumers may set in suspend state.
We use -uV rather than -volt in other bits of the bindings.
> + - regulator-on-in-suspend: regulator should be on in suspend state.
> + - regulator-off-in-suspend: regulator should be off in suspend state.
> + If node don't include regulator-[on/off]-in-suspend, can't change
> + regulator state in suspend mode and only should sustain the regulator
> + state of normal state.
Probably better to say that the OS will not manage the state here -
otherwise we have to explicitly override any hardware default that's
there which drivers and the core don't do right now.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: lgirdwood@gmail.com, grant.likely@linaro.org, robh+dt@kernel.org,
kyungmin.park@samsung.com, k.kozlowski@samsung.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv4 2/2] dt-bindings: regulator: Add regulator suspend state for PM state
Date: Thu, 4 Sep 2014 23:53:03 +0100 [thread overview]
Message-ID: <20140904225303.GY29327@sirena.org.uk> (raw)
In-Reply-To: <1408343223-4043-3-git-send-email-cw00.choi@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On Mon, Aug 18, 2014 at 03:27:03PM +0900, Chanwoo Choi wrote:
> +- regulator-initial-state: initial state for suspend state, cnd set initial
> + state among following defined suspend states:
> + <3>: PM_SUSPEND_MEM - Setup regulator according to regulator-state-mem
> + <4>: PM_SUSPEND_MAX - Setup regulator according to regulator-state-disk
Please add defines for these in include/dt-bindings. Probably worth
pointing out that if absent the state is the hardware default (same for
most of these.
> +- regulator-state-[mem/disk] node has following common properties:
> + - regulator-volt: voltage consumers may set in suspend state.
We use -uV rather than -volt in other bits of the bindings.
> + - regulator-on-in-suspend: regulator should be on in suspend state.
> + - regulator-off-in-suspend: regulator should be off in suspend state.
> + If node don't include regulator-[on/off]-in-suspend, can't change
> + regulator state in suspend mode and only should sustain the regulator
> + state of normal state.
Probably better to say that the OS will not manage the state here -
otherwise we have to explicitly override any hardware default that's
there which drivers and the core don't do right now.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-04 22:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 6:27 [PATCHv4 0/2] regulator: of: Add support for pasing regulator suspend state Chanwoo Choi
2014-08-18 6:27 ` Chanwoo Choi
2014-08-18 6:27 ` [PATCHv4 1/2] regulator: of: Add support for parsing regulator_state for " Chanwoo Choi
[not found] ` <1408343223-4043-2-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-04 22:49 ` Mark Brown
2014-09-04 22:49 ` Mark Brown
[not found] ` <20140904224948.GX29327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-29 0:40 ` Chanwoo Choi
2014-09-29 0:40 ` Chanwoo Choi
2014-08-18 6:27 ` [PATCHv4 2/2] dt-bindings: regulator: Add regulator suspend state for PM state Chanwoo Choi
[not found] ` <1408343223-4043-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-04 22:53 ` Mark Brown [this message]
2014-09-04 22:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904225303.GY29327@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.