From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] arm64, thunder: Add Kconfig option for Cavium Thunder SoC Family
Date: Fri, 5 Sep 2014 10:36:47 +0100 [thread overview]
Message-ID: <20140905093647.GH2172@leverpostej> (raw)
In-Reply-To: <20140905092507.GH13515@arm.com>
On Fri, Sep 05, 2014 at 10:25:08AM +0100, Will Deacon wrote:
> On Fri, Sep 05, 2014 at 10:21:35AM +0100, Robert Richter wrote:
> > On 05.09.14 09:39:32, Will Deacon wrote:
> > > On Fri, Sep 05, 2014 at 08:46:42AM +0100, Robert Richter wrote:
> > > > From: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> > > >
> > > > Increase maximum numbers of cpus to 32. This relates to current
> > > > maximal possible cpu number. Increasing this to 64 cpus will be a
> > > > separate patch not part of this enablement patches.
> > >
> > > Just out of interest, does raising the current maximum limit actually break
> > > any existing code? If not, then doing this as two patches doesn't seem worth
> > > it.
> >
> > Increasing to 64 should be fine from the perspective of cpu mask
> > implementation. Memory foot print should be the same already as this
> > uses long which is 64 bit. So this wouldn't hurt.
> >
> > However, I felt a bit uncomfortable having a dependency here to
> > enabling 64 cpus and getting this patch set upstream. Support for more
> > than 32 cpus is not well tested yet and there still might be problems
> > with e.g. interrupt delivery or topology.
>
> All I mean is, if the kernel doesn't explode on existing systems by changing
> the upper limit to 64, then we should do that. If you're not comfortable
> that the Thunder code can handle that, then leave the thunder default as 32,
> like you do in the current patch. It just seems odd not to change the
> maximum number, since it's an arbitrary limit from my perspective.
FWIW my Juno happily boots with a NR_CPUS=64 kernel.
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Robert Richter <rric@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Radha Mohan Chintakuntla <rchintakuntla@cavium.com>,
Olof Johansson <olof@lixom.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Robert Richter <rrichter@cavium.com>
Subject: Re: [PATCH v2 1/4] arm64, thunder: Add Kconfig option for Cavium Thunder SoC Family
Date: Fri, 5 Sep 2014 10:36:47 +0100 [thread overview]
Message-ID: <20140905093647.GH2172@leverpostej> (raw)
In-Reply-To: <20140905092507.GH13515@arm.com>
On Fri, Sep 05, 2014 at 10:25:08AM +0100, Will Deacon wrote:
> On Fri, Sep 05, 2014 at 10:21:35AM +0100, Robert Richter wrote:
> > On 05.09.14 09:39:32, Will Deacon wrote:
> > > On Fri, Sep 05, 2014 at 08:46:42AM +0100, Robert Richter wrote:
> > > > From: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> > > >
> > > > Increase maximum numbers of cpus to 32. This relates to current
> > > > maximal possible cpu number. Increasing this to 64 cpus will be a
> > > > separate patch not part of this enablement patches.
> > >
> > > Just out of interest, does raising the current maximum limit actually break
> > > any existing code? If not, then doing this as two patches doesn't seem worth
> > > it.
> >
> > Increasing to 64 should be fine from the perspective of cpu mask
> > implementation. Memory foot print should be the same already as this
> > uses long which is 64 bit. So this wouldn't hurt.
> >
> > However, I felt a bit uncomfortable having a dependency here to
> > enabling 64 cpus and getting this patch set upstream. Support for more
> > than 32 cpus is not well tested yet and there still might be problems
> > with e.g. interrupt delivery or topology.
>
> All I mean is, if the kernel doesn't explode on existing systems by changing
> the upper limit to 64, then we should do that. If you're not comfortable
> that the Thunder code can handle that, then leave the thunder default as 32,
> like you do in the current patch. It just seems odd not to change the
> maximum number, since it's an arbitrary limit from my perspective.
FWIW my Juno happily boots with a NR_CPUS=64 kernel.
Mark.
next prev parent reply other threads:[~2014-09-05 9:36 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 7:46 [PATCH v2 0/4] arm64, thunder: Enable Cavium Thunder SoC Family Robert Richter
2014-09-05 7:46 ` Robert Richter
2014-09-05 7:46 ` [PATCH v2 1/4] arm64, thunder: Add Kconfig option for " Robert Richter
2014-09-05 7:46 ` Robert Richter
2014-09-05 8:39 ` Will Deacon
2014-09-05 8:39 ` Will Deacon
2014-09-05 9:21 ` Robert Richter
2014-09-05 9:21 ` Robert Richter
2014-09-05 9:25 ` Will Deacon
2014-09-05 9:25 ` Will Deacon
2014-09-05 9:36 ` Mark Rutland [this message]
2014-09-05 9:36 ` Mark Rutland
2014-09-05 10:51 ` Robert Richter
2014-09-05 10:51 ` Robert Richter
2014-09-05 9:32 ` Russell King - ARM Linux
2014-09-05 9:32 ` Russell King - ARM Linux
2014-09-05 10:45 ` Robert Richter
2014-09-05 10:45 ` Robert Richter
2014-09-05 11:05 ` Russell King - ARM Linux
2014-09-05 11:05 ` Russell King - ARM Linux
2014-09-05 12:51 ` Mark Rutland
2014-09-05 12:51 ` Mark Rutland
2014-09-05 14:04 ` Arnd Bergmann
2014-09-05 14:04 ` Arnd Bergmann
2014-09-05 14:22 ` Mark Rutland
2014-09-05 14:22 ` Mark Rutland
2014-09-05 16:25 ` Arnd Bergmann
2014-09-05 16:25 ` Arnd Bergmann
2014-09-08 11:01 ` Robert Richter
2014-09-08 11:01 ` Robert Richter
2014-09-08 12:29 ` Arnd Bergmann
2014-09-08 12:29 ` Arnd Bergmann
2014-09-08 18:25 ` Rob Herring
2014-09-08 18:25 ` Rob Herring
2014-09-05 7:46 ` [PATCH v2 2/4] arm64, thunder: Add initial dts for Cavium Thunder SoC Robert Richter
2014-09-05 7:46 ` Robert Richter
2014-09-05 11:21 ` Arnd Bergmann
2014-09-05 11:21 ` Arnd Bergmann
2014-09-05 11:21 ` Arnd Bergmann
2014-09-11 14:51 ` Robert Richter
2014-09-11 14:51 ` Robert Richter
2014-09-11 14:51 ` Robert Richter
2014-09-05 7:46 ` [PATCH v2 3/4] arm64, thunder: Document devicetree bindings " Robert Richter
2014-09-05 7:46 ` Robert Richter
2014-09-05 8:42 ` Will Deacon
2014-09-05 8:42 ` Will Deacon
2014-09-05 8:42 ` Will Deacon
2014-09-05 9:32 ` Robert Richter
2014-09-05 9:32 ` Robert Richter
2014-09-05 9:39 ` Mark Rutland
2014-09-05 9:39 ` Mark Rutland
2014-09-05 9:39 ` Mark Rutland
2014-09-08 7:54 ` Robert Richter
2014-09-08 7:54 ` Robert Richter
2014-09-08 7:54 ` Robert Richter
2014-09-05 7:46 ` [PATCH v2 4/4] arm64, defconfig: Enable Cavium Thunder SoC in defconfig Robert Richter
2014-09-05 7:46 ` Robert Richter
2014-09-05 8:42 ` [PATCH v2 0/4] arm64, thunder: Enable Cavium Thunder SoC Family Will Deacon
2014-09-05 8:42 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905093647.GH2172@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.