From: Oleg Nesterov <oleg@redhat.com>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
falcon@meizu.com, tiwai@suse.de, tj@kernel.org,
arjan@linux.intel.com, linux-kernel@vger.kernel.org,
hare@suse.com, akpm@linux-foundation.org,
penguin-kernel@i-love.sakura.ne.jp,
joseph.salisbury@canonical.com, bpoirier@suse.de,
santosh@chelsio.com, "Luis R. Rodriguez" <mcgrof@suse.com>,
Kay Sievers <kay@vrfy.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Tim Gardner <tim.gardner@canonical.com>,
Pierre Fersing <pierre-fersing@pierref.org>,
Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
Casey Leedom <leedom@chelsio.com>,
Hariprasad S <hariprasad@chelsio.com>,
MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
netdev@vger.
Subject: Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM
Date: Fri, 5 Sep 2014 12:59:49 +0200 [thread overview]
Message-ID: <20140905105949.GA22778@redhat.com> (raw)
In-Reply-To: <1409899047-13045-4-git-send-email-mcgrof@do-not-panic.com>
On 09/04, Luis R. Rodriguez wrote:
>
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>
> The new umh kill option has allowed kthreads to receive
> kill signals but they are generally accepting all sources
> of kill signals
And I think this is right,
> while the original motivation was to enable
> through the OOM from sending the kill.
even if the main concern was OOM.
> Users can provide a log output and it should be clear on
> the trace what probe / driver got the kill signal.
Well, if you need a WARN output, perhaps you could just add
WARN_ON(fatal_signal_pending()) at the end of load_module() ?
Not only kthread_create() can fail if systemd sends SIGKILL.
> Although Oleg had rejected a
> similar change a while ago
And honestly, I still dislike this change.
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
falcon@meizu.com, tiwai@suse.de, tj@kernel.org,
arjan@linux.intel.com, linux-kernel@vger.kernel.org,
hare@suse.com, akpm@linux-foundation.org,
penguin-kernel@i-love.sakura.ne.jp,
joseph.salisbury@canonical.com, bpoirier@suse.de,
santosh@chelsio.com, "Luis R. Rodriguez" <mcgrof@suse.com>,
Kay Sievers <kay@vrfy.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Tim Gardner <tim.gardner@canonical.com>,
Pierre Fersing <pierre-fersing@pierref.org>,
Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
Casey Leedom <leedom@chelsio.com>,
Hariprasad S <hariprasad@chelsio.com>,
MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM
Date: Fri, 5 Sep 2014 12:59:49 +0200 [thread overview]
Message-ID: <20140905105949.GA22778@redhat.com> (raw)
In-Reply-To: <1409899047-13045-4-git-send-email-mcgrof@do-not-panic.com>
On 09/04, Luis R. Rodriguez wrote:
>
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>
> The new umh kill option has allowed kthreads to receive
> kill signals but they are generally accepting all sources
> of kill signals
And I think this is right,
> while the original motivation was to enable
> through the OOM from sending the kill.
even if the main concern was OOM.
> Users can provide a log output and it should be clear on
> the trace what probe / driver got the kill signal.
Well, if you need a WARN output, perhaps you could just add
WARN_ON(fatal_signal_pending()) at the end of load_module() ?
Not only kthread_create() can fail if systemd sends SIGKILL.
> Although Oleg had rejected a
> similar change a while ago
And honestly, I still dislike this change.
Oleg.
next prev parent reply other threads:[~2014-09-05 10:59 UTC|newest]
Thread overview: 227+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 6:37 [RFC v2 0/6] driver-core: add asynch probe support Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 1/6] driver-core: generalize freeing driver private member Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 2/6] driver-core: add driver async_probe support Luis R. Rodriguez
2014-09-05 11:24 ` Oleg Nesterov
2014-09-05 11:24 ` Oleg Nesterov
2014-09-05 17:25 ` Luis R. Rodriguez
2014-09-05 17:25 ` Luis R. Rodriguez
2014-09-05 22:10 ` Dmitry Torokhov
2014-10-20 23:43 ` Luis R. Rodriguez
2014-10-20 23:43 ` Luis R. Rodriguez
2014-10-20 23:43 ` Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 3/6] kthread: warn on kill signal if not OOM Luis R. Rodriguez
2014-09-05 6:37 ` Luis R. Rodriguez
2014-09-05 7:19 ` Tejun Heo
2014-09-05 7:19 ` Tejun Heo
2014-09-05 7:47 ` Luis R. Rodriguez
2014-09-05 7:47 ` Luis R. Rodriguez
2014-09-05 7:47 ` Luis R. Rodriguez
2014-09-05 9:14 ` Mike Galbraith
2014-09-05 9:14 ` Mike Galbraith
2014-09-05 9:14 ` Mike Galbraith
2014-09-05 14:12 ` Tejun Heo
2014-09-05 14:12 ` Tejun Heo
2014-09-05 14:12 ` Tejun Heo
2014-09-05 16:44 ` Dmitry Torokhov
2014-09-05 16:44 ` Dmitry Torokhov
2014-09-05 17:49 ` Tejun Heo
2014-09-05 17:49 ` Tejun Heo
2014-09-05 18:10 ` Dmitry Torokhov
2014-09-05 18:10 ` Dmitry Torokhov
2014-09-05 22:29 ` Tejun Heo
2014-09-05 22:29 ` Tejun Heo
2014-09-05 22:31 ` Tejun Heo
2014-09-05 22:31 ` Tejun Heo
2014-09-05 22:49 ` Dmitry Torokhov
2014-09-05 22:49 ` Dmitry Torokhov
2014-09-05 22:55 ` Tejun Heo
2014-09-05 22:55 ` Tejun Heo
2014-09-05 23:22 ` Dmitry Torokhov
2014-09-05 23:22 ` Dmitry Torokhov
2014-09-05 23:32 ` Tejun Heo
2014-09-05 23:32 ` Tejun Heo
2014-09-05 22:45 ` Arjan van de Ven
2014-09-05 22:45 ` Arjan van de Ven
2014-09-05 22:52 ` Dmitry Torokhov
2014-09-05 22:52 ` Dmitry Torokhov
2014-09-05 22:52 ` Dmitry Torokhov
2014-09-05 22:57 ` Tejun Heo
2014-09-05 22:57 ` Tejun Heo
2014-09-05 23:05 ` Arjan van de Ven
2014-09-05 23:05 ` Arjan van de Ven
2014-09-05 23:05 ` Arjan van de Ven
2014-09-05 23:18 ` Dmitry Torokhov
2014-09-05 23:18 ` Dmitry Torokhov
2014-09-05 23:18 ` Dmitry Torokhov
2014-09-05 18:12 ` Luis R. Rodriguez
2014-09-05 18:12 ` Luis R. Rodriguez
2014-09-05 18:12 ` Luis R. Rodriguez
2014-09-05 18:29 ` Dmitry Torokhov
2014-09-05 18:29 ` Dmitry Torokhov
2014-09-05 18:29 ` Dmitry Torokhov
2014-09-05 22:40 ` Tejun Heo
2014-09-05 22:40 ` Tejun Heo
2014-09-05 22:40 ` Tejun Heo
2014-09-09 1:04 ` Luis R. Rodriguez
2014-09-09 1:04 ` Luis R. Rodriguez
2014-09-09 1:04 ` Luis R. Rodriguez
2014-09-09 1:10 ` Tejun Heo
2014-09-09 1:10 ` Tejun Heo
2014-09-09 1:10 ` Tejun Heo
2014-09-09 1:13 ` Tejun Heo
2014-09-09 1:13 ` Tejun Heo
2014-09-09 1:13 ` Tejun Heo
2014-09-09 1:22 ` Tejun Heo
2014-09-09 1:22 ` Tejun Heo
2014-09-09 1:22 ` Tejun Heo
2014-09-09 1:26 ` Luis R. Rodriguez
2014-09-09 1:26 ` Luis R. Rodriguez
2014-09-09 1:26 ` Luis R. Rodriguez
2014-09-09 1:29 ` Tejun Heo
2014-09-09 1:29 ` Tejun Heo
2014-09-09 1:29 ` Tejun Heo
2014-09-09 1:38 ` Luis R. Rodriguez
2014-09-09 1:38 ` Luis R. Rodriguez
2014-09-09 1:38 ` Luis R. Rodriguez
2014-09-09 1:47 ` Tejun Heo
2014-09-09 1:47 ` Tejun Heo
2014-09-09 1:47 ` Tejun Heo
2014-09-09 2:28 ` Luis R. Rodriguez
2014-09-09 2:28 ` Luis R. Rodriguez
2014-09-09 2:28 ` Luis R. Rodriguez
2014-09-09 2:39 ` Tejun Heo
2014-09-09 2:39 ` Tejun Heo
2014-09-09 2:39 ` Tejun Heo
2014-09-09 2:57 ` Luis R. Rodriguez
2014-09-09 2:57 ` Luis R. Rodriguez
2014-09-09 2:57 ` Luis R. Rodriguez
2014-09-09 3:03 ` Tejun Heo
2014-09-09 3:03 ` Tejun Heo
2014-09-09 3:03 ` Tejun Heo
2014-09-09 3:19 ` Luis R. Rodriguez
2014-09-09 3:19 ` Luis R. Rodriguez
2014-09-09 3:19 ` Luis R. Rodriguez
2014-09-09 3:25 ` Tejun Heo
2014-09-09 3:25 ` Tejun Heo
2014-09-09 3:25 ` Tejun Heo
2014-09-09 23:03 ` Tejun Heo
2014-09-09 23:03 ` Tejun Heo
2014-09-09 23:03 ` Tejun Heo
2014-09-12 20:14 ` Luis R. Rodriguez
2014-09-12 20:14 ` Luis R. Rodriguez
2014-09-22 16:36 ` Luis R. Rodriguez
2014-09-22 16:36 ` Luis R. Rodriguez
2014-09-10 5:13 ` Tom Gundersen
2014-09-10 5:13 ` Tom Gundersen
2014-09-10 5:13 ` Tom Gundersen
2014-09-09 5:38 ` James Bottomley
2014-09-09 5:38 ` James Bottomley
2014-09-09 5:38 ` James Bottomley
2014-09-09 19:16 ` Luis R. Rodriguez
2014-09-09 19:16 ` Luis R. Rodriguez
2014-09-09 19:16 ` Luis R. Rodriguez
2014-09-09 19:35 ` James Bottomley
2014-09-09 19:35 ` James Bottomley
2014-09-09 19:35 ` James Bottomley
2014-09-09 20:45 ` Luis R. Rodriguez
2014-09-09 20:45 ` Luis R. Rodriguez
2014-09-09 20:45 ` Luis R. Rodriguez
2014-09-10 6:46 ` Tom Gundersen
2014-09-10 6:46 ` Tom Gundersen
2014-09-10 6:46 ` [systemd-devel] " Tom Gundersen
2014-09-10 10:07 ` Ceriel Jacobs
2014-09-10 10:07 ` Ceriel Jacobs
2014-09-10 10:07 ` Ceriel Jacobs
2014-09-10 13:31 ` James Bottomley
2014-09-10 13:31 ` James Bottomley
2014-09-10 13:31 ` James Bottomley
2014-09-10 21:10 ` Luis R. Rodriguez
2014-09-10 21:10 ` Luis R. Rodriguez
2014-09-10 21:10 ` [systemd-devel] " Luis R. Rodriguez
2014-09-11 5:42 ` Alexander E. Patrakov
2014-09-11 5:42 ` Alexander E. Patrakov
2014-09-11 5:42 ` [systemd-devel] " Alexander E. Patrakov
2014-09-11 21:43 ` Tom Gundersen
2014-09-11 21:43 ` Tom Gundersen
2014-09-11 21:43 ` [systemd-devel] " Tom Gundersen
2014-09-11 22:26 ` Luis R. Rodriguez
2014-09-11 22:26 ` Luis R. Rodriguez
2014-09-11 22:26 ` Luis R. Rodriguez
2014-09-12 5:48 ` Tom Gundersen
2014-09-12 5:48 ` Tom Gundersen
2014-09-12 5:48 ` [systemd-devel] " Tom Gundersen
2014-09-12 20:09 ` Luis R. Rodriguez
2014-09-12 20:09 ` Luis R. Rodriguez
2014-09-12 20:09 ` [systemd-devel] " Luis R. Rodriguez
2014-10-10 21:54 ` Anatol Pomozov
2014-10-10 21:54 ` Anatol Pomozov
2014-10-10 21:54 ` [systemd-devel] " Anatol Pomozov
2014-10-10 22:45 ` Tom Gundersen
2014-10-10 22:45 ` Tom Gundersen
2014-10-10 22:45 ` [systemd-devel] " Tom Gundersen
2014-10-15 19:41 ` Anatol Pomozov
2014-10-15 19:41 ` Anatol Pomozov
2014-10-15 19:41 ` [systemd-devel] " Anatol Pomozov
2014-10-15 19:46 ` Alexander E. Patrakov
2014-10-15 19:46 ` Alexander E. Patrakov
2014-10-15 19:46 ` [systemd-devel] " Alexander E. Patrakov
2014-09-09 21:42 ` Tejun Heo
2014-09-09 21:42 ` Tejun Heo
2014-09-09 21:42 ` Tejun Heo
2014-09-09 22:26 ` James Bottomley
2014-09-09 22:26 ` James Bottomley
2014-09-09 22:26 ` James Bottomley
2014-09-09 22:41 ` Tejun Heo
2014-09-09 22:41 ` Tejun Heo
2014-09-09 22:41 ` Tejun Heo
2014-09-09 22:46 ` James Bottomley
2014-09-09 22:46 ` James Bottomley
2014-09-09 22:46 ` James Bottomley
2014-09-09 22:52 ` Tejun Heo
2014-09-09 22:52 ` Tejun Heo
2014-09-09 22:52 ` Tejun Heo
2014-09-09 23:01 ` Dmitry Torokhov
2014-09-09 23:01 ` Dmitry Torokhov
2014-09-09 23:01 ` Dmitry Torokhov
2014-09-11 19:59 ` James Bottomley
2014-09-11 19:59 ` James Bottomley
2014-09-11 19:59 ` James Bottomley
2014-09-11 20:23 ` Dmitry Torokhov
2014-09-11 20:23 ` Dmitry Torokhov
2014-09-11 20:23 ` Dmitry Torokhov
2014-09-11 20:42 ` Luis R. Rodriguez
2014-09-11 20:42 ` Luis R. Rodriguez
2014-09-11 20:42 ` Luis R. Rodriguez
2014-09-11 20:53 ` Dmitry Torokhov
2014-09-11 20:53 ` Dmitry Torokhov
2014-09-11 20:53 ` Dmitry Torokhov
2014-09-11 21:08 ` Luis R. Rodriguez
2014-09-11 21:08 ` Luis R. Rodriguez
2014-09-11 21:08 ` Luis R. Rodriguez
2014-09-22 19:49 ` Pavel Machek
2014-09-22 19:49 ` Pavel Machek
2014-09-22 19:49 ` Pavel Machek
2014-09-22 20:23 ` Dmitry Torokhov
2014-09-22 20:23 ` Dmitry Torokhov
2014-09-22 20:23 ` Dmitry Torokhov
2014-09-30 21:06 ` Pavel Machek
2014-09-30 21:06 ` Pavel Machek
2014-09-30 21:06 ` Pavel Machek
2014-09-30 21:34 ` Dmitry Torokhov
2014-09-30 21:34 ` Dmitry Torokhov
2014-09-30 21:34 ` Dmitry Torokhov
2014-09-09 22:00 ` Jiri Kosina
2014-09-09 22:00 ` Jiri Kosina
2014-09-09 22:00 ` Jiri Kosina
2014-09-05 10:59 ` Oleg Nesterov [this message]
2014-09-05 10:59 ` Oleg Nesterov
2014-09-05 17:35 ` Luis R. Rodriguez
2014-09-05 17:35 ` Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 4/6] cxgb4: use async probe Luis R. Rodriguez
2014-09-05 6:37 ` [RFC v2 5/6] mptsas: " Luis R. Rodriguez
2014-09-05 7:16 ` Tejun Heo
2014-09-05 7:23 ` Hannes Reinecke
2014-09-05 6:37 ` [RFC v2 6/6] pata_marvell: " Luis R. Rodriguez
2014-09-05 6:59 ` Alexander E. Patrakov
2014-09-05 7:15 ` Tejun Heo
2014-09-05 7:11 ` [RFC v2 0/6] driver-core: add asynch probe support Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905105949.GA22778@redhat.com \
--to=oleg@redhat.com \
--cc=MPT-FusionLinux.pdl@avagotech.com \
--cc=abhijit.mahajan@avagotech.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bpoirier@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=falcon@meizu.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=hariprasad@chelsio.com \
--cc=joseph.salisbury@canonical.com \
--cc=kay@vrfy.org \
--cc=leedom@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=nagalakshmi.nandigama@avagotech.com \
--cc=netdev@vger. \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pierre-fersing@pierref.org \
--cc=praveen.krishnamoorthy@avagotech.com \
--cc=santosh@chelsio.com \
--cc=sreekanth.reddy@avagotech.com \
--cc=tim.gardner@canonical.com \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.