From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Varun Sethi <Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Emilian.Medve-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] iommu/fsl: Fix warning resulting from adding PCI device twice
Date: Fri, 5 Sep 2014 16:04:15 +0200 [thread overview]
Message-ID: <20140905140414.GA11931@8bytes.org> (raw)
In-Reply-To: <1409830725-4469-1-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
On Thu, Sep 04, 2014 at 05:08:45PM +0530, Varun Sethi wrote:
> iommu_group_get_for_dev determines the iommu group for the PCI device and adds
> the device to the group.
>
> In the PAMU driver we were again adding the device to the same group without checking
> if the device already had an iommu group. This resulted in the following warning.
>
> [...]
>
> Signed-off-by: Varun Sethi <Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> v2 changes
> - directly check for the device iommu_group
>
> drivers/iommu/fsl_pamu_domain.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Applied to iommu/fixes and added stable tag, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: linuxppc-dev@ozlabs.org, iommu@lists.linux-foundation.org,
alex.williamson@redhat.com, Emilian.Medve@freescale.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/fsl: Fix warning resulting from adding PCI device twice
Date: Fri, 5 Sep 2014 16:04:15 +0200 [thread overview]
Message-ID: <20140905140414.GA11931@8bytes.org> (raw)
In-Reply-To: <1409830725-4469-1-git-send-email-Varun.Sethi@freescale.com>
On Thu, Sep 04, 2014 at 05:08:45PM +0530, Varun Sethi wrote:
> iommu_group_get_for_dev determines the iommu group for the PCI device and adds
> the device to the group.
>
> In the PAMU driver we were again adding the device to the same group without checking
> if the device already had an iommu group. This resulted in the following warning.
>
> [...]
>
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
> v2 changes
> - directly check for the device iommu_group
>
> drivers/iommu/fsl_pamu_domain.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Applied to iommu/fixes and added stable tag, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: iommu@lists.linux-foundation.org, alex.williamson@redhat.com,
Emilian.Medve@freescale.com, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/fsl: Fix warning resulting from adding PCI device twice
Date: Fri, 5 Sep 2014 16:04:15 +0200 [thread overview]
Message-ID: <20140905140414.GA11931@8bytes.org> (raw)
In-Reply-To: <1409830725-4469-1-git-send-email-Varun.Sethi@freescale.com>
On Thu, Sep 04, 2014 at 05:08:45PM +0530, Varun Sethi wrote:
> iommu_group_get_for_dev determines the iommu group for the PCI device and adds
> the device to the group.
>
> In the PAMU driver we were again adding the device to the same group without checking
> if the device already had an iommu group. This resulted in the following warning.
>
> [...]
>
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
> v2 changes
> - directly check for the device iommu_group
>
> drivers/iommu/fsl_pamu_domain.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Applied to iommu/fixes and added stable tag, thanks.
next prev parent reply other threads:[~2014-09-05 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 11:38 [PATCH v2] iommu/fsl: Fix warning resulting from adding PCI device twice Varun Sethi
2014-09-04 11:38 ` Varun Sethi
[not found] ` <1409830725-4469-1-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-09-04 20:56 ` Emil Medve
2014-09-04 20:56 ` Emil Medve
2014-09-05 14:04 ` Joerg Roedel [this message]
2014-09-05 14:04 ` Joerg Roedel
2014-09-05 14:04 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905140414.GA11931@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=Emilian.Medve-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.