From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: klightspeed@killerwolves.net
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Arnaud Ebalard <arno@natisbad.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Gregory Clement <gregory.clement@free-electrons.com>,
Brian Norris <computersforpeace@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC
Date: Fri, 5 Sep 2014 12:41:40 -0300 [thread overview]
Message-ID: <20140905154140.GA1377@arch.hh.imgtec.org> (raw)
In-Reply-To: <1409898233-9273-1-git-send-email-klightspeed@killerwolves.net>
(Fixing Cc list: dropping devicetree guys, and adding Brian and MTD instead)
On 05 Sep 04:23 PM, klightspeed@killerwolves.net wrote:
> The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC
> (strength = 4), while the pxa3xx NAND driver by default uses
> Hamming ECC (strength = 1).
>
Hm, I guess the device (Hynix H27U1G8F2BTR) does not support ONFI,
and the kernel is just taking the legacy ECC. The flash specs makes no
mention to ONFI, so probably no ONFI here.
> This patch changes the ECC mode on these machines to match that
> of the bootloader and of the stock firmware, so that for example
> updating the kernel is possible without requiring a serial
> connection.
>
> This patch depends on commit 5b3e507 (mtd: nand: pxa3xx: Use ECC
> strength and step size devicetree binding)
>
> Signed-off-by: Ben Peddell <klightspeed@killerwolves.net>
Looks good to me, since Arnaud reports this is the correct ECC scheme:
http://natisbad.org/NAS2/index.html#hw-nand
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Thanks for the fix,
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC
Date: Fri, 5 Sep 2014 12:41:40 -0300 [thread overview]
Message-ID: <20140905154140.GA1377@arch.hh.imgtec.org> (raw)
In-Reply-To: <1409898233-9273-1-git-send-email-klightspeed@killerwolves.net>
(Fixing Cc list: dropping devicetree guys, and adding Brian and MTD instead)
On 05 Sep 04:23 PM, klightspeed at killerwolves.net wrote:
> The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC
> (strength = 4), while the pxa3xx NAND driver by default uses
> Hamming ECC (strength = 1).
>
Hm, I guess the device (Hynix H27U1G8F2BTR) does not support ONFI,
and the kernel is just taking the legacy ECC. The flash specs makes no
mention to ONFI, so probably no ONFI here.
> This patch changes the ECC mode on these machines to match that
> of the bootloader and of the stock firmware, so that for example
> updating the kernel is possible without requiring a serial
> connection.
>
> This patch depends on commit 5b3e507 (mtd: nand: pxa3xx: Use ECC
> strength and step size devicetree binding)
>
> Signed-off-by: Ben Peddell <klightspeed@killerwolves.net>
Looks good to me, since Arnaud reports this is the correct ECC scheme:
http://natisbad.org/NAS2/index.html#hw-nand
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Thanks for the fix,
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC
Date: Fri, 5 Sep 2014 12:41:40 -0300 [thread overview]
Message-ID: <20140905154140.GA1377@arch.hh.imgtec.org> (raw)
In-Reply-To: <1409898233-9273-1-git-send-email-klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
(Fixing Cc list: dropping devicetree guys, and adding Brian and MTD instead)
On 05 Sep 04:23 PM, klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org wrote:
> The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC
> (strength = 4), while the pxa3xx NAND driver by default uses
> Hamming ECC (strength = 1).
>
Hm, I guess the device (Hynix H27U1G8F2BTR) does not support ONFI,
and the kernel is just taking the legacy ECC. The flash specs makes no
mention to ONFI, so probably no ONFI here.
> This patch changes the ECC mode on these machines to match that
> of the bootloader and of the stock firmware, so that for example
> updating the kernel is possible without requiring a serial
> connection.
>
> This patch depends on commit 5b3e507 (mtd: nand: pxa3xx: Use ECC
> strength and step size devicetree binding)
>
> Signed-off-by: Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
Looks good to me, since Arnaud reports this is the correct ECC scheme:
http://natisbad.org/NAS2/index.html#hw-nand
Acked-by: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks for the fix,
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: klightspeed@killerwolves.net
Cc: linux-arm-kernel@lists.infradead.org,
Arnaud Ebalard <arno@natisbad.org>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC
Date: Fri, 5 Sep 2014 12:41:40 -0300 [thread overview]
Message-ID: <20140905154140.GA1377@arch.hh.imgtec.org> (raw)
In-Reply-To: <1409898233-9273-1-git-send-email-klightspeed@killerwolves.net>
(Fixing Cc list: dropping devicetree guys, and adding Brian and MTD instead)
On 05 Sep 04:23 PM, klightspeed@killerwolves.net wrote:
> The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC
> (strength = 4), while the pxa3xx NAND driver by default uses
> Hamming ECC (strength = 1).
>
Hm, I guess the device (Hynix H27U1G8F2BTR) does not support ONFI,
and the kernel is just taking the legacy ECC. The flash specs makes no
mention to ONFI, so probably no ONFI here.
> This patch changes the ECC mode on these machines to match that
> of the bootloader and of the stock firmware, so that for example
> updating the kernel is possible without requiring a serial
> connection.
>
> This patch depends on commit 5b3e507 (mtd: nand: pxa3xx: Use ECC
> strength and step size devicetree binding)
>
> Signed-off-by: Ben Peddell <klightspeed@killerwolves.net>
Looks good to me, since Arnaud reports this is the correct ECC scheme:
http://natisbad.org/NAS2/index.html#hw-nand
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Thanks for the fix,
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-05 15:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 6:23 [PATCH] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC klightspeed at killerwolves.net
2014-09-05 6:23 ` klightspeed
2014-09-05 6:23 ` klightspeed
2014-09-05 15:41 ` Ezequiel Garcia [this message]
2014-09-05 15:41 ` Ezequiel Garcia
2014-09-05 15:41 ` Ezequiel Garcia
2014-09-05 15:41 ` Ezequiel Garcia
2014-09-05 20:49 ` Arnaud Ebalard
2014-09-05 20:49 ` Arnaud Ebalard
2014-09-05 20:49 ` Arnaud Ebalard
2014-09-05 20:49 ` Arnaud Ebalard
2014-09-06 2:18 ` Ben Peddell
2014-09-06 2:18 ` Ben Peddell
2014-09-06 2:18 ` Ben Peddell
2014-09-06 2:18 ` Ben Peddell
-- strict thread matches above, loose matches on Subject: below --
2014-09-05 6:18 klightspeed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905154140.GA1377@arch.hh.imgtec.org \
--to=ezequiel.garcia@free-electrons.com \
--cc=arno@natisbad.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=klightspeed@killerwolves.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.