Re: [PATCH 2/6] dts, kbuild: Factor out dtbs install rules to Makefile.dtbinst

[Robert Richter <rric@kernel.org>]

On 05.09.14 07:48:30, Rob Herring wrote:
> On Fri, Sep 5, 2014 at 1:48 AM, Robert Richter <rric@kernel.org> wrote:
> > From: Robert Richter <rrichter@cavium.com>
> >
> > Move dtbs install rules to Makefile.dtbinst. This change is needed to
> > implement support for dts vendor subdirs. The change makes Makefiles
> > easier and smaller as no longer the dtbs_install rule needs to be
> > defined. Another advantage is that install goals are not encoded in
> > targets anymore (%.dtb_dtbinst_).
> >
> > Signed-off-by: Robert Richter <rrichter@cavium.com>
> > ---
> >  arch/arm/Makefile            |  6 +++++-
> >  arch/arm/boot/dts/Makefile   |  2 --
> >  arch/arm64/Makefile          |  6 +++++-
> >  arch/arm64/boot/dts/Makefile |  2 --
> >  scripts/Kbuild.include       |  6 ++++++
> >  scripts/Makefile.dtbinst     | 38 ++++++++++++++++++++++++++++++++++++++
> >  scripts/Makefile.lib         | 12 ------------
> >  7 files changed, 54 insertions(+), 18 deletions(-)
> >  create mode 100644 scripts/Makefile.dtbinst
> >
> > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > index 0ce9d0f71f2a..1963d9a9a2c4 100644
> > --- a/arch/arm/Makefile
> > +++ b/arch/arm/Makefile
> > @@ -313,9 +313,13 @@ $(BOOT_TARGETS): vmlinux
> >         $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@
> >
> >  PHONY += dtbs dtbs_install
> > -dtbs dtbs_install: prepare scripts
> > +
> > +dtbs: prepare scripts
> >         $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $@
> >
> > +dtbs_install:
> > +       $(Q)$(MAKE) $(dtbinst)=$(boot)/dts MACHINE=$(MACHINE)
> 
> Can't you get rid of MACHINE here, too?

I moved this change to the end of this patch series to let maintainers
the choise to drop the change if they are not fine with it.

-Robert