From: Josh Triplett <josh@joshtriplett.org>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Huang Shijie <shijie8@gmail.com>,
linux-kernel@vger.kernel.org,
Rashika Kheria <rashika.kheria@gmail.com>,
linux-mtd@lists.infradead.org,
"grmoore@altera.com" <grmoore@altera.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 5/7] mtd: denali: remove a set-but-unused variable
Date: Mon, 8 Sep 2014 01:30:57 -0700 [thread overview]
Message-ID: <20140908083057.GB5361@thin> (raw)
In-Reply-To: <1410163813-31783-6-git-send-email-yamada.m@jp.panasonic.com>
On Mon, Sep 08, 2014 at 05:10:11PM +0900, Masahiro Yamada wrote:
> The variable "retry" in wait_for_irq() is set, but not referenced.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Sure enough.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
> drivers/mtd/nand/denali.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 259ca0ba..d37c2e1 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -697,7 +697,6 @@ static uint32_t wait_for_irq(struct denali_nand_info *denali, uint32_t irq_mask)
> {
> unsigned long comp_res;
> uint32_t intr_status;
> - bool retry = false;
> unsigned long timeout = msecs_to_jiffies(1000);
>
> do {
> @@ -717,7 +716,6 @@ static uint32_t wait_for_irq(struct denali_nand_info *denali, uint32_t irq_mask)
> * need to wait again
> */
> spin_unlock_irq(&denali->irq_lock);
> - retry = true;
> }
> } while (comp_res != 0);
>
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Josh Triplett <josh@joshtriplett.org>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Huang Shijie <shijie8@gmail.com>,
Rashika Kheria <rashika.kheria@gmail.com>,
"grmoore@altera.com" <grmoore@altera.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] mtd: denali: remove a set-but-unused variable
Date: Mon, 8 Sep 2014 01:30:57 -0700 [thread overview]
Message-ID: <20140908083057.GB5361@thin> (raw)
In-Reply-To: <1410163813-31783-6-git-send-email-yamada.m@jp.panasonic.com>
On Mon, Sep 08, 2014 at 05:10:11PM +0900, Masahiro Yamada wrote:
> The variable "retry" in wait_for_irq() is set, but not referenced.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Sure enough.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
> drivers/mtd/nand/denali.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 259ca0ba..d37c2e1 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -697,7 +697,6 @@ static uint32_t wait_for_irq(struct denali_nand_info *denali, uint32_t irq_mask)
> {
> unsigned long comp_res;
> uint32_t intr_status;
> - bool retry = false;
> unsigned long timeout = msecs_to_jiffies(1000);
>
> do {
> @@ -717,7 +716,6 @@ static uint32_t wait_for_irq(struct denali_nand_info *denali, uint32_t irq_mask)
> * need to wait again
> */
> spin_unlock_irq(&denali->irq_lock);
> - retry = true;
> }
> } while (comp_res != 0);
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-09-08 8:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 8:10 [PATCH 0/7] mtd: denali: A collection of trivial coding style fixes Masahiro Yamada
2014-09-08 8:10 ` Masahiro Yamada
2014-09-08 8:10 ` [PATCH 1/7] mtd: denali: fix the format of comment blocks Masahiro Yamada
2014-09-08 8:10 ` Masahiro Yamada
2014-09-08 8:29 ` Josh Triplett
2014-09-08 8:29 ` Josh Triplett
2014-09-08 8:10 ` [PATCH 2/7] mtd: denali: remove unnecessary variable initializations Masahiro Yamada
2014-09-08 8:10 ` Masahiro Yamada
2014-09-08 8:10 ` [PATCH 3/7] mtd: denali: remove unnecessary casts Masahiro Yamada
2014-09-08 8:10 ` Masahiro Yamada
2014-09-08 8:10 ` [PATCH 4/7] mtd: denali: change the type of iterators to int Masahiro Yamada
2014-09-08 8:10 ` Masahiro Yamada
2014-09-08 8:10 ` [PATCH 5/7] mtd: denali: remove a set-but-unused variable Masahiro Yamada
2014-09-08 8:10 ` Masahiro Yamada
2014-09-08 8:30 ` Josh Triplett [this message]
2014-09-08 8:30 ` Josh Triplett
2014-09-08 8:10 ` [PATCH 6/7] mtd: denali: remove unnecessary parentheses Masahiro Yamada
2014-09-08 8:10 ` Masahiro Yamada
2014-09-08 8:34 ` Josh Triplett
2014-09-08 8:34 ` Josh Triplett
2014-09-08 8:10 ` [PATCH 7/7] mtd: denali: fix indentations and other trivial things Masahiro Yamada
2014-09-08 8:10 ` Masahiro Yamada
2014-09-08 8:39 ` Josh Triplett
2014-09-08 8:39 ` Josh Triplett
2014-09-08 9:14 ` Masahiro Yamada
2014-09-08 9:14 ` Masahiro Yamada
2014-09-08 10:00 ` Sudip Mukherjee
2014-09-08 10:00 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908083057.GB5361@thin \
--to=josh@joshtriplett.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=grmoore@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rashika.kheria@gmail.com \
--cc=shijie8@gmail.com \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.