From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang
Date: Mon, 8 Sep 2014 11:53:07 +0100 [thread overview]
Message-ID: <20140908105307.GF26030@arm.com> (raw)
In-Reply-To: <1409959460-15989-1-git-send-email-behanw@converseincode.com>
On Sat, Sep 06, 2014 at 12:24:20AM +0100, behanw at converseincode.com wrote:
> From: Mark Charlebois <charlebm@gmail.com>
>
> Fix variable types for 64-bit inline assembly.
>
> This patch now works with both gcc and clang.
Really? This looks like something the clang needs to do better on, as I
really don't see people adding these casts to future code. They're ugly and
redundant (or GCC).
This hunk:
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index c555672..6894ef3 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -94,7 +94,7 @@ static int __init early_cachepolicy(char *p)
> */
> asm volatile(
> " mrs %0, mair_el1\n"
> - " bfi %0, %1, #%2, #8\n"
> + " bfi %0, %1, %2, #8\n"
> " msr mair_el1, %0\n"
> " isb\n"
> : "=&r" (tmp)
also looks fishy. Does gas accept that without the '#' prefix?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: "behanw@converseincode.com" <behanw@converseincode.com>
Cc: "anderson@redhat.com" <anderson@redhat.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"cl@linux.com" <cl@linux.com>,
"cov@codeaurora.org" <cov@codeaurora.org>,
"jays.lee@samsung.com" <jays.lee@samsung.com>,
"msalter@redhat.com" <msalter@redhat.com>,
"sandeepa.prabhu@linaro.org" <sandeepa.prabhu@linaro.org>,
"srivatsa.bhat@linux.vnet.ibm.com"
<srivatsa.bhat@linux.vnet.ibm.com>,
"steve.capper@linaro.org" <steve.capper@linaro.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
"takahiro.akashi@linaro.org" <takahiro.akashi@linaro.org>,
"Vijaya.Kumar@caviumnetworks.com"
<Vijaya.Kumar@caviumnetworks.com>,
"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
"acme@kernel.org" <acme@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Matthew Leach <Matthew.Leach@arm.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"olof@lixom.net" <olof@lixom.net>,
"paulus@samba.org" <paulus@samba.org>,
Mark Charlebois <charlebm@gmail.com>
Subject: Re: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang
Date: Mon, 8 Sep 2014 11:53:07 +0100 [thread overview]
Message-ID: <20140908105307.GF26030@arm.com> (raw)
In-Reply-To: <1409959460-15989-1-git-send-email-behanw@converseincode.com>
On Sat, Sep 06, 2014 at 12:24:20AM +0100, behanw@converseincode.com wrote:
> From: Mark Charlebois <charlebm@gmail.com>
>
> Fix variable types for 64-bit inline assembly.
>
> This patch now works with both gcc and clang.
Really? This looks like something the clang needs to do better on, as I
really don't see people adding these casts to future code. They're ugly and
redundant (or GCC).
This hunk:
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index c555672..6894ef3 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -94,7 +94,7 @@ static int __init early_cachepolicy(char *p)
> */
> asm volatile(
> " mrs %0, mair_el1\n"
> - " bfi %0, %1, #%2, #8\n"
> + " bfi %0, %1, %2, #8\n"
> " msr mair_el1, %0\n"
> " isb\n"
> : "=&r" (tmp)
also looks fishy. Does gas accept that without the '#' prefix?
Will
next prev parent reply other threads:[~2014-09-08 10:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 23:24 [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang behanw at converseincode.com
2014-09-05 23:24 ` behanw
2014-09-08 9:30 ` Olof Johansson
2014-09-08 9:30 ` Olof Johansson
2014-09-10 17:38 ` Will Deacon
2014-09-10 17:38 ` Will Deacon
2014-09-10 17:49 ` Ard Biesheuvel
2014-09-10 17:49 ` Ard Biesheuvel
2014-09-08 10:53 ` Will Deacon [this message]
2014-09-08 10:53 ` Will Deacon
2014-09-08 18:35 ` Mark Charlebois
2014-09-08 18:35 ` Mark Charlebois
2014-09-09 10:15 ` Will Deacon
2014-09-09 10:15 ` Will Deacon
2014-09-15 5:30 ` behanw at converseincode.com
2014-09-15 5:30 ` behanw
2014-09-15 16:02 ` Will Deacon
2014-09-15 16:02 ` Will Deacon
2014-09-15 16:26 ` Catalin Marinas
2014-09-15 16:26 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908105307.GF26030@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.