All of lore.kernel.org
 help / color / mirror / Atom feed
From: b38343@freescale.com (Robin Gong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
Date: Wed, 10 Sep 2014 13:16:16 +0800	[thread overview]
Message-ID: <20140910051615.GA29006@Robin-OptiPlex-780> (raw)
In-Reply-To: <20140910032128.GD18566@dragon>

On Wed, Sep 10, 2014 at 11:21:30AM +0800, Shawn Guo wrote:
> On Wed, Sep 10, 2014 at 09:33:36AM +0800, Robin Gong wrote:
> > There is one weird data in rxfifo after one full rx/tx transfer
> > done sometimes. It looks a design issue and hard to workaround
> > totally, so disable dma functhion here. And will re-enable it
> > once the root cause found.
> > 
> > Signed-off-by: Robin Gong <b38343@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6dl.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi
> > index b453e0e..e84a1ff 100644
> > --- a/arch/arm/boot/dts/imx6dl.dtsi
> > +++ b/arch/arm/boot/dts/imx6dl.dtsi
> > @@ -102,6 +102,22 @@
> >  	};
> >  };
> >  
> > +&ecspi1 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi2 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi3 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi4 {
> > +	dma-names = "", "";
> > +};
> > +
> 
> This looks odd.  Can we drop the dma properties from imx6qdl.dtsi,
> and only add them in imx6q.dtsi instead?
> 
> Shawn
>
Ok, I'll send v2.
> >  &hdmi {
> >  	compatible = "fsl,imx6dl-hdmi";
> >  };
> > -- 
> > 1.9.1
> > 

WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <b38343@freescale.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux@arm.linux.org.uk, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, kernel@pengutronix.de, galak@codeaurora.org,
	Frank.Li@freescale.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
Date: Wed, 10 Sep 2014 13:16:16 +0800	[thread overview]
Message-ID: <20140910051615.GA29006@Robin-OptiPlex-780> (raw)
In-Reply-To: <20140910032128.GD18566@dragon>

On Wed, Sep 10, 2014 at 11:21:30AM +0800, Shawn Guo wrote:
> On Wed, Sep 10, 2014 at 09:33:36AM +0800, Robin Gong wrote:
> > There is one weird data in rxfifo after one full rx/tx transfer
> > done sometimes. It looks a design issue and hard to workaround
> > totally, so disable dma functhion here. And will re-enable it
> > once the root cause found.
> > 
> > Signed-off-by: Robin Gong <b38343@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6dl.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi
> > index b453e0e..e84a1ff 100644
> > --- a/arch/arm/boot/dts/imx6dl.dtsi
> > +++ b/arch/arm/boot/dts/imx6dl.dtsi
> > @@ -102,6 +102,22 @@
> >  	};
> >  };
> >  
> > +&ecspi1 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi2 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi3 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi4 {
> > +	dma-names = "", "";
> > +};
> > +
> 
> This looks odd.  Can we drop the dma properties from imx6qdl.dtsi,
> and only add them in imx6q.dtsi instead?
> 
> Shawn
>
Ok, I'll send v2.
> >  &hdmi {
> >  	compatible = "fsl,imx6dl-hdmi";
> >  };
> > -- 
> > 1.9.1
> > 

WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <b38343@freescale.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: <kernel@pengutronix.de>, <robh+dt@kernel.org>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
	<linux@arm.linux.org.uk>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<Frank.Li@freescale.com>
Subject: Re: [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
Date: Wed, 10 Sep 2014 13:16:16 +0800	[thread overview]
Message-ID: <20140910051615.GA29006@Robin-OptiPlex-780> (raw)
In-Reply-To: <20140910032128.GD18566@dragon>

On Wed, Sep 10, 2014 at 11:21:30AM +0800, Shawn Guo wrote:
> On Wed, Sep 10, 2014 at 09:33:36AM +0800, Robin Gong wrote:
> > There is one weird data in rxfifo after one full rx/tx transfer
> > done sometimes. It looks a design issue and hard to workaround
> > totally, so disable dma functhion here. And will re-enable it
> > once the root cause found.
> > 
> > Signed-off-by: Robin Gong <b38343@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6dl.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi
> > index b453e0e..e84a1ff 100644
> > --- a/arch/arm/boot/dts/imx6dl.dtsi
> > +++ b/arch/arm/boot/dts/imx6dl.dtsi
> > @@ -102,6 +102,22 @@
> >  	};
> >  };
> >  
> > +&ecspi1 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi2 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi3 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi4 {
> > +	dma-names = "", "";
> > +};
> > +
> 
> This looks odd.  Can we drop the dma properties from imx6qdl.dtsi,
> and only add them in imx6q.dtsi instead?
> 
> Shawn
>
Ok, I'll send v2.
> >  &hdmi {
> >  	compatible = "fsl,imx6dl-hdmi";
> >  };
> > -- 
> > 1.9.1
> > 

  reply	other threads:[~2014-09-10  5:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  1:33 [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl Robin Gong
2014-09-10  1:33 ` Robin Gong
2014-09-10  1:33 ` Robin Gong
2014-09-10  3:21 ` Shawn Guo
2014-09-10  3:21   ` Shawn Guo
2014-09-10  3:21   ` Shawn Guo
2014-09-10  5:16   ` Robin Gong [this message]
2014-09-10  5:16     ` Robin Gong
2014-09-10  5:16     ` Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910051615.GA29006@Robin-OptiPlex-780 \
    --to=b38343@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.