[PATCH] ipvsadm: do not truncate ipv6 members of v4 services

[PATCH] ipvsadm: do not truncate ipv6 members of v4 services

[Alex Gartrell]

We need to compare to the entry af instead of the service af or else we'll
pop a nul byte into the middle of a v6 real server address.

Signed-off-by: Alex Gartrell <agartrell@fb.com>
---
 ipvsadm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipvsadm.c b/ipvsadm.c
index d12070e..ef19091 100644
--- a/ipvsadm.c
+++ b/ipvsadm.c
@@ -1629,7 +1629,7 @@ print_service_entry(ipvs_service_entry_t *se, unsigned int format)
 			fprintf(stderr, "addrport_to_anyname fails\n");
 			exit(1);
 		}
-		if (!(format & FMT_RULE) && (se->af != AF_INET6))
+		if (!(format & FMT_RULE) && (e->af != AF_INET6))
 			dname[28] = '\0';
 
 		if (format & FMT_RULE) {
-- 
1.8.1

Re: [PATCH] ipvsadm: do not truncate ipv6 members of v4 services

[Julian Anastasov]

	Hello,

On Tue, 9 Sep 2014, Alex Gartrell wrote:

> We need to compare to the entry af instead of the service af or else we'll
> pop a nul byte into the middle of a v6 real server address.
> 
> Signed-off-by: Alex Gartrell <agartrell@fb.com>

Acked-by: Julian Anastasov <ja@ssi.bg>

	Jesper, I think you can now push all recent
changes to the ipvsadm tree. This includes:

ipvsadm: specify real server address family to netlink socket
by Alex, from August 29

ipvsadm: restrict different address family
ipvsadm: allow different address family in connection listing
by me, from August 30

and finally this patch.

> ---
>  ipvsadm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ipvsadm.c b/ipvsadm.c
> index d12070e..ef19091 100644
> --- a/ipvsadm.c
> +++ b/ipvsadm.c
> @@ -1629,7 +1629,7 @@ print_service_entry(ipvs_service_entry_t *se, unsigned int format)
>  			fprintf(stderr, "addrport_to_anyname fails\n");
>  			exit(1);
>  		}
> -		if (!(format & FMT_RULE) && (se->af != AF_INET6))
> +		if (!(format & FMT_RULE) && (e->af != AF_INET6))
>  			dname[28] = '\0';
>  
>  		if (format & FMT_RULE) {
> -- 
> 1.8.1

Regards

--
Julian Anastasov <ja@ssi.bg>

Re: [PATCH] ipvsadm: do not truncate ipv6 members of v4 services

[Jesper Dangaard Brouer]

On Wed, 10 Sep 2014 09:38:35 +0300 (EEST) Julian Anastasov <ja@ssi.bg> wrote:

> 	Jesper, I think you can now push all recent
> changes to the ipvsadm tree. This includes:
>
> ipvsadm: specify real server address family to netlink socket
> by Alex, from August 29
> 
> ipvsadm: restrict different address family
> ipvsadm: allow different address family in connection listing
> by me, from August 30
> 
> and finally this patch.

Sound good! -- Just applied an pushed patches to:
 https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/

Thanks every one!
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer