From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: sparclinux@vger.kernel.org
Subject: q about ldc_bind after irq save
Date: Wed, 10 Sep 2014 18:49:26 +0000 [thread overview]
Message-ID: <20140910184926.GC14466@oracle.com> (raw)
This one (below) was flagged by lockdep. While it is a corner-case,
it does create lockdep noise, so I'm trying to figure out
the smallest fix for it:
irq event stamp: 0
hardirqs last enabled at (0): [< (null)>] (null)
hardirqs last disabled at (0): [<0000000000466c7c>] copy_process+0x33c/0xcc0
softirqs last enabled at (0): [<0000000000466c7c>] copy_process+0x33c/0xcc0
softirqs last disabled at (0): [< (null)>] (null)
Call Trace:
[00000000004a0738] __might_sleep+0xf8/0x120
[000000000058bea4] kmem_cache_alloc_trace+0x184/0x2c0
[00000000004faf80] request_threaded_irq+0x80/0x160
[000000000044f71c] ldc_bind+0x7c/0x220
[0000000000452454] vio_port_up+0x54/0xe0
[00000000101f6778] probe_disk+0x38/0x220 [sunvdc]
[00000000101f6b8c] vdc_port_probe+0x22c/0x300 [sunvdc]
[0000000000451a88] vio_device_probe+0x48/0x60
[000000000074c56c] really_probe+0x6c/0x300
[000000000074c83c] driver_probe_device+0x3c/0xa0
[000000000074c92c] __driver_attach+0x8c/0xa0
[000000000074a6ec] bus_for_each_dev+0x6c/0xa0
[000000000074c1dc] driver_attach+0x1c/0x40
[000000000074b0fc] bus_add_driver+0xbc/0x280
I think vio_port_up needs to do the irqsave before the ldc_bind
so that it can examine ldc_state() safely.
But is there a reason we can't move the request_irq from ldc_bind
and into ldc_alloc itself? Or is there a simpler fix?
--Sowmini
next reply other threads:[~2014-09-10 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 18:49 Sowmini Varadhan [this message]
2014-09-12 20:36 ` q about ldc_bind after irq save David Miller
2014-09-15 13:12 ` Sowmini Varadhan
2014-09-15 21:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910184926.GC14466@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.