From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: sparclinux@vger.kernel.org
Subject: Re: q about ldc_bind after irq save
Date: Mon, 15 Sep 2014 13:12:46 +0000 [thread overview]
Message-ID: <20140915131246.GB2346@oracle.com> (raw)
In-Reply-To: <20140910184926.GC14466@oracle.com>
On (09/12/14 16:36), David Miller wrote:
>
> > But is there a reason we can't move the request_irq from ldc_bind
> > and into ldc_alloc itself? Or is there a simpler fix?
>
> Because we don't have the string name for the IRQ until we get it
> from the ldc_bind() call, for one.
but that's not insurmountable. The name used by vnet/vdc is vio->name
(initialized in vio_driver_init(), before ldc_alloc() is called),
and ds uses a const string. So, by passing an extra const char *name
argument to ldc_alloc(), the request_irq()s can be moved out of ldc_bind(),
avoiding the lockdep warning?
I'll submit a patch for this later today/tomorrow, unless there's
something else I'm missing.
--Sowmini
next prev parent reply other threads:[~2014-09-15 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 18:49 q about ldc_bind after irq save Sowmini Varadhan
2014-09-12 20:36 ` David Miller
2014-09-15 13:12 ` Sowmini Varadhan [this message]
2014-09-15 21:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915131246.GB2346@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.