From: Peter Feiner <pfeiner@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Pavel Emelyanov <xemul@parallels.com>,
Jamie Liu <jamieliu@google.com>, Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH] mm: softdirty: unmapped addresses between VMAs are clean
Date: Wed, 10 Sep 2014 22:41:04 -0700 [thread overview]
Message-ID: <20140911054104.GA31069@google.com> (raw)
In-Reply-To: <20140910163628.66302ac77f7835ba5df2f49c@linux-foundation.org>
On Wed, Sep 10, 2014 at 04:36:28PM -0700, Andrew Morton wrote:
> On Wed, 10 Sep 2014 16:24:46 -0700 Peter Feiner <pfeiner@google.com> wrote:
> > @@ -1048,32 +1048,51 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
> > + while (1) {
> > + unsigned long vm_start = end;
>
> Did you really mean to do that? If so, perhaps a little comment to
> explain how it works?
It's the same idea that I used in the pagemap_pte_hole patch that I submitted
today: if vma is NULL, then we fill in the pagemap from (addr) to (end) with
non-present pagemap entries.
Should I submit a v2 with a comment?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Feiner <pfeiner@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Pavel Emelyanov <xemul@parallels.com>,
Jamie Liu <jamieliu@google.com>, Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH] mm: softdirty: unmapped addresses between VMAs are clean
Date: Wed, 10 Sep 2014 22:41:04 -0700 [thread overview]
Message-ID: <20140911054104.GA31069@google.com> (raw)
In-Reply-To: <20140910163628.66302ac77f7835ba5df2f49c@linux-foundation.org>
On Wed, Sep 10, 2014 at 04:36:28PM -0700, Andrew Morton wrote:
> On Wed, 10 Sep 2014 16:24:46 -0700 Peter Feiner <pfeiner@google.com> wrote:
> > @@ -1048,32 +1048,51 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
> > + while (1) {
> > + unsigned long vm_start = end;
>
> Did you really mean to do that? If so, perhaps a little comment to
> explain how it works?
It's the same idea that I used in the pagemap_pte_hole patch that I submitted
today: if vma is NULL, then we fill in the pagemap from (addr) to (end) with
non-present pagemap entries.
Should I submit a v2 with a comment?
next prev parent reply other threads:[~2014-09-11 5:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 23:24 [PATCH] mm: softdirty: unmapped addresses between VMAs are clean Peter Feiner
2014-09-10 23:24 ` Peter Feiner
2014-09-10 23:36 ` Andrew Morton
2014-09-10 23:36 ` Andrew Morton
2014-09-11 5:41 ` Peter Feiner [this message]
2014-09-11 5:41 ` Peter Feiner
2014-09-11 19:54 ` Andrew Morton
2014-09-11 19:54 ` Andrew Morton
2014-09-15 18:40 ` [PATCH v2] " Peter Feiner
2014-09-15 18:40 ` Peter Feiner
2014-09-26 20:33 ` Naoya Horiguchi
2014-09-26 20:33 ` Naoya Horiguchi
2014-10-02 0:25 ` Peter Feiner
2014-10-02 0:25 ` Peter Feiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911054104.GA31069@google.com \
--to=pfeiner@google.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=hughd@google.com \
--cc=jamieliu@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.